workflow: reject unknown step settings at save (strict decode for step types) #1139

Closed
opened 2026-10-27 13:39:10 +00:00 by sam · 0 comments
Owner

internal/domain/workflow/repo_steps.go:43 decodeSettings and factories in agent_run.go, command_run.go, finish_step.go, workflow_call.go use non-strict settings.Decode, while settings-less steps ignore settings entirely. ParseDefinition KnownFields(true) does not recurse into yaml.Node settings. Misspelled keys like readOnly instead of read_only or ifEmpty are silently dropped. Done when every step type strictly decodes settings and rejects unknown keys at save.

Close reason

Fixed on fix/workflow-eda-audit (PR #1627)


Imported from beads archie-core-8b5nk · GitHub #1603 · type bug · priority P1 · created 2026-10-11 · closed 2026-10-11

internal/domain/workflow/repo_steps.go:43 decodeSettings and factories in agent_run.go, command_run.go, finish_step.go, workflow_call.go use non-strict settings.Decode, while settings-less steps ignore settings entirely. ParseDefinition KnownFields(true) does not recurse into yaml.Node settings. Misspelled keys like readOnly instead of read_only or ifEmpty are silently dropped. Done when every step type strictly decodes settings and rejects unknown keys at save. ### Close reason Fixed on fix/workflow-eda-audit (PR #1627) --- _Imported from beads `archie-core-8b5nk` · GitHub #1603 · type bug · priority P1 · created 2026-10-11 · closed 2026-10-11_
sam added the highbug labels 2026-10-27 13:39:10 +00:00
sam self-assigned this 2026-10-27 13:39:10 +00:00
sam closed this issue 2026-10-27 13:39:11 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1139