deploy.yml concurrency cancels tag runs, so dist-zip never produces a release zip #1134

Closed
opened 2026-10-27 13:39:09 +00:00 by sam · 0 comments
Owner

deploy.yml groups concurrency on deploy-${{ github.sha }} with cancel-in-progress: true. 'git push origin main --follow-tags' pushes main plus archied/v* and archie/v* at the same SHA, so all three runs share one group and two get cancelled. The survivor is whichever started last, and for the v1.23.0 push that was the main-branch run (ref refs/heads/main).

dist-zip is gated on: startsWith(github.ref, 'refs/tags/archied/v'). The main-branch survivor does not match, so dist-zip is skipped and the tag runs that would have matched were cancelled.

Observed on v1.23.0: runs 34616798566 and 34616799470 cancelled at 2-4s, run 34616802847 (main) skipped dist-zip, 0 artifacts across all three. No distribution zip exists for archied v1.23.0.

The concurrency comment reasons about images only ('both jobs push :latest'), which is sound for build-and-push but wrong for a ref-conditional job. Note also that no workflow creates GitHub releases; the archied v1.22.0 release appears to be hand-made.

Acceptance criteria

A single 'git push --follow-tags' of a release produces the distribution zip exactly once, without racing redundant image builds.

Close reason

Closed


Imported from beads archie-core-803r · GitHub #802 · type bug · priority P1 · created 2026-09-11 · closed 2026-09-11

deploy.yml groups concurrency on deploy-${{ github.sha }} with cancel-in-progress: true. 'git push origin main --follow-tags' pushes main plus archied/v* and archie/v* at the same SHA, so all three runs share one group and two get cancelled. The survivor is whichever started last, and for the v1.23.0 push that was the main-branch run (ref refs/heads/main). dist-zip is gated on: startsWith(github.ref, 'refs/tags/archied/v'). The main-branch survivor does not match, so dist-zip is skipped and the tag runs that would have matched were cancelled. Observed on v1.23.0: runs 34616798566 and 34616799470 cancelled at 2-4s, run 34616802847 (main) skipped dist-zip, 0 artifacts across all three. No distribution zip exists for archied v1.23.0. The concurrency comment reasons about images only ('both jobs push :latest'), which is sound for build-and-push but wrong for a ref-conditional job. Note also that no workflow creates GitHub releases; the archied v1.22.0 release appears to be hand-made. ### Acceptance criteria A single 'git push --follow-tags' of a release produces the distribution zip exactly once, without racing redundant image builds. ### Close reason Closed --- _Imported from beads `archie-core-803r` · GitHub #802 · type bug · priority P1 · created 2026-09-11 · closed 2026-09-11_
sam added the highbug labels 2026-10-27 13:39:09 +00:00
sam self-assigned this 2026-10-27 13:39:09 +00:00
sam closed this issue 2026-10-27 13:39:09 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1134