bot_user has no config default or validation, so curator silently skips every session #1069

Closed
opened 2026-10-27 13:38:53 +00:00 by sam · 0 comments
Owner

Residual from archie-core-ga6i (commit 56fc7231). cfg.BotUser has no config-level default and no validation - only setup.go:34's interactive default. A hand-written config.toml without bot_user therefore leaves it empty: the session curator now skips every session with reason 'no agent id: agent-user memory needs an agent and a user' (visible and non-fatal) while the chat turn path already ran with the same empty agent. Fail-closed in both directions, but the operator sees skips rather than a configuration error, and the diagnostic does not name bot_user. Fix direction: validate or default bot_user at config load, or make the skip reason name the missing setting.

Close reason

Shipped in d5763a4e: applyIdentityDefaults now adopts a sole identities entry as the root single-identity values (BotUser, and BotEmail when unset), so a one-identity deployment can no longer leave the root empty and make the curator skip every session for want of an agent. The root is left alone when two or more identities leave no single answer, and when the operator sets it explicitly. The curator's skip reason now names the setting ('no agent id: bot_user is unset (agent-user memory needs an agent and a user)'), so the remaining multi-identity case is diagnosable rather than looking like a data problem. Red-first: the sole-identity default test failed before the change. Root cause was validateIdentityStructure only running validateSingleIdentity when len(Identities)==0, while the curator is built with the root cfg.BotUser (bootstrap.go:1343).


Imported from beads archie-core-4slp · GitHub #1134 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-02

Residual from archie-core-ga6i (commit 56fc7231). cfg.BotUser has no config-level default and no validation - only setup.go:34's interactive default. A hand-written config.toml without bot_user therefore leaves it empty: the session curator now skips every session with reason 'no agent id: agent-user memory needs an agent and a user' (visible and non-fatal) while the chat turn path already ran with the same empty agent. Fail-closed in both directions, but the operator sees skips rather than a configuration error, and the diagnostic does not name bot_user. Fix direction: validate or default bot_user at config load, or make the skip reason name the missing setting. ### Close reason Shipped in d5763a4e: applyIdentityDefaults now adopts a sole [[identities]] entry as the root single-identity values (BotUser, and BotEmail when unset), so a one-identity deployment can no longer leave the root empty and make the curator skip every session for want of an agent. The root is left alone when two or more identities leave no single answer, and when the operator sets it explicitly. The curator's skip reason now names the setting ('no agent id: bot_user is unset (agent-user memory needs an agent and a user)'), so the remaining multi-identity case is diagnosable rather than looking like a data problem. Red-first: the sole-identity default test failed before the change. Root cause was validateIdentityStructure only running validateSingleIdentity when len(Identities)==0, while the curator is built with the root cfg.BotUser (bootstrap.go:1343). --- _Imported from beads `archie-core-4slp` · GitHub #1134 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-02_
sam added the mediumbug labels 2026-10-27 13:38:53 +00:00
sam self-assigned this 2026-10-27 13:38:53 +00:00
sam closed this issue 2026-10-27 13:38:54 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1069