Commit Graph
2292 Commits
Author SHA1 Message Date
sam cd8e69b07f Merge branch 'main' into codex/control-plane-4q28 2026-10-09 20:03:52 +11:00
sam bd4050eb6e style: remove space between icons and labels 2026-10-09 19:56:27 +11:00
sam be31522e6a fix(kit): migrate runtime to sandbox kit m8 2026-10-09 18:31:56 +11:00
sam aa61ce2bc5 feat(ui): author parallel workflow branches on canvas 2026-10-09 18:18:45 +11:00
sam 69c58320e1 docs(agents): omit status the maintainer can already see 2026-10-09 18:16:45 +11:00
sam fa4a91d219 docs(agents): post externally only when told 2026-10-09 18:09:11 +11:00
sam 9b375cd3ef docs(agents): act on clear direction and keep replies short 2026-10-09 18:04:38 +11:00
sam 37c0c62b26 feat(ui): edit workflow call interfaces on the canvas 2026-10-09 18:04:08 +11:00
sam ffacc10766 fix(daemon): reconcile call waits from durable steps 2026-10-09 17:56:15 +11:00
sam 8c13485652 chore(release): v1.52.0 2026-10-09 13:09:59 +11:00
sam b395c17066 feat(harness): create the setup PTY at the browser's size
The setup terminal created its PTY at a fixed 24x80 while the browser
measured its own box and threw the measurement away, so a full-screen CLI
login drew into a corner of a much larger xterm.

OpenRequest now carries a ConsoleSize with the target frame; the route
reads cols/rows from the WebSocket URL, falling back to 24x80 when they
are absent or out of range, and the daemon creates the PTY at that
geometry. The component sends the size it measured before connecting.

Live resize is the follow-on: it needs a control channel on the WebSocket,
which today is a raw byte copy.
2026-10-09 13:07:29 +11:00
sam 96dde2ec88 fix(harness): keep the setup container alive with archie's own binary
A setup session started its container with "sleep infinity" and opened the
PTY with "sh -l". Neither binary is guaranteed: the spec capability whose
floor is a shell and bash is com.docker.sandbox/sbx@1, and archie's
supported map does not list it, so a Kit image need not provide either. A
missing sleep killed the container at start and a missing sh failed the
exec, both as an opaque error.

The container now runs archie-agent hold as its entrypoint. The agent
binary is archie's own and already mounted into every Kit, so the
keepalive needs nothing the image may lack and the container env stays
empty. Before opening the PTY, harnesssession probes for bash then sh and
returns ErrNoShell naming the Kit reference when neither is present.

Test: TestPickShell covers bash-preferred, sh-only, neither, and a probe
that cannot run.
2026-10-09 13:05:05 +11:00
sam 076dc8c92f fix(channels): normalize stored settings and deduplicate save errors 2026-10-09 13:02:23 +11:00
sam 9102fee350 test(ui): prune brittle checks and document agent rules 2026-10-09 12:51:57 +11:00
sam 583cc876f8 fix(ui): clean dependencies and add task table sorting 2026-10-09 12:46:05 +11:00
sam dd41d7a0cd chore(lint): pin the linter to 2.14.0
The setup task is the only installer, so the pin follows the version in
use rather than holding it back, and CI follows the pin.
2026-10-09 12:32:05 +11:00
sam be3efd4fc4 fix(egress): use context-aware dial and request in the token-endpoint test
net.Dial and httptest.NewRequest fail the noctx linter, so the gate was red
on the commit that added the test.
2026-10-09 12:27:45 +11:00
sam f28c0a8dee chore(task): install the pinned tooling with task setup
task setup installs the golangci-lint CI pins, the protobuf generators and
the dashboard dependencies, and warns by name about the tools it cannot
install (Go, Task, Node, Docker).

The linter version now lives in one file read by both the setup task and
both workflows, so a local checkout and the gate cannot run different
linters.
2026-10-09 12:27:45 +11:00
sam 045fc5fc31 test(archieui): restore the archie-ui import-boundary check
Only the daemon owns containers, and the dashboard consumes a harness
session over its gRPC contract. Go imports are atomic, so a single
reference relinks a runtime, and the boundary holds only while something
re-measures it. cmd/archie-ui/architecture_test.go enforced this until it
was purged with the test suite; nothing enforced it since.

The restored check runs go list -deps . and fails if the dashboard links
internal/container, internal/app/archied or internal/agentexec. It is
transitive, which is what "links" means, and runs in the existing test
step.
2026-10-09 11:42:39 +11:00
sam f5cf74df45 fix(egress): refuse a token endpoint the run is not granted
forward intercepted a declared OAuth credential's token endpoint only when
the run was granted the service. For an optional credential it fell
through to the reverse proxy, so the provider's real access and refresh
tokens reached the container un-sentinelized, contradicting the harness
contract's "the real credential never enters the container".

A matched token endpoint is now refused when the service is not granted
(403 for an optional credential; a required one keeps its existing 502).
The table test drives forward against a recording upstream and asserts
both the status and that the upstream was never contacted.
2026-10-09 11:42:39 +11:00
sam 7438c3211c fix(deps): pin sandbox-kit-spec to the API the code is written against
The dependency bump moved sandbox-kit-spec from v3.0.0-m.6 to m.8 without
adapting the code, so the tree no longer builds: CredentialCapability.Phase
is now spec.Phases, not a string (internal/infrastructure/egress), and
Client.Assemble became a package-level fetch.Assemble that takes a Loader
and a LayerValidator instead of spec.MergeOptions (internal/infrastructure/
kitrun).

Migrating to m.8 is not a version-string change: m.8 pushes kit integrity,
safe layer extraction and resource limits onto the caller, so it is
security-relevant work, not an unblock. Pin back to m.6, which the code is
written against, and leave the migration to a deliberate change.

Verified: go build ./..., go vet ./..., go test -short ./... all pass with
this pin. The gate's ui:check and lint steps fail for unrelated
toolchain reasons recorded separately.
2026-10-09 11:42:33 +11:00
sam 9fcf9fa6f3 ```
chore: update ui dependencies
```
2026-10-09 11:27:48 +11:00
sam 5991fc3ea2 chore: bump Go dependencies and toolchain 2026-10-09 11:23:04 +11:00
sam e2edc1bd5c fix(config): normalize default org for harness credentials 2026-10-09 10:01:35 +11:00
sam ae416320f1 feat(settings): classify startup and live runtime settings 2026-10-09 09:57:57 +11:00
sam 45e908374b feat(logging): aggregate recent service logs in dashboard 2026-10-09 09:57:57 +11:00
sam 32f69a60fc fix(gateway): attribute chat settings to signed-in users 2026-10-09 09:57:57 +11:00
sam b03a610535 fix(webui): explain personal token availability 2026-10-09 09:57:57 +11:00
sam 84d1286211 refactor(webui): remove unused configuration schema 2026-10-09 09:57:57 +11:00
sam 018f549055 fix(settings): show configuration reload failures 2026-10-09 09:57:57 +11:00
sam dd203997a8 fix(gateway): read task logs through state store 2026-10-09 09:57:57 +11:00
sam 756a76a7bb fix(ui): render unknown routes and correct status description 2026-10-09 09:57:56 +11:00
sam 8b1fafd1d6 fix(configuration): reject unknown conf.d files 2026-10-09 09:57:56 +11:00
sam 88760b8d5a feat(curators): edit and apply definitions live 2026-10-09 09:57:56 +11:00
sam a8e91b3ba2 feat(settings): edit profiles bindings and playbooks 2026-10-09 09:57:56 +11:00
sam 6f612befb7 feat(settings): show resource consumers and apply status 2026-10-09 09:57:56 +11:00
sam 8513d7ff9d feat(presence): report workers and broker on status 2026-10-09 09:57:56 +11:00
sam 6671f23673 feat(presence): expose service dependency checks 2026-10-09 09:57:56 +11:00
sam 422b2f413e fix(daemon): inherit live settings for identity tasks 2026-10-09 09:57:56 +11:00
sam 143ac94c40 test: verify enablement reports channel running 2026-10-09 02:24:47 +11:00
sam 741dbb1c7e fix(workflow): enforce optional result booleans only when required 2026-10-09 02:22:19 +11:00
sam 0248cc35f8 fix(messaging): refuse failed channels as enablement success 2026-10-09 02:22:19 +11:00
sam b24d336f81 fix(workflow): retry a transient read while awaiting a callee 2026-10-09 02:21:49 +11:00
sam 502899cef6 fix(workflow): preserve a reference's type between steps 2026-10-09 02:10:43 +11:00
sam d201257382 feat(harness): serve a daemon-side setup session to the dashboard
The dashboard's setup terminal was a 503: it had a WebSocket route, an
authorizer and an xterm.js surface, but nothing owned a container. The
daemon owns containers, so the session contract lands there and the
dashboard consumes it over a new gRPC contract.

One session concept, two targets. A setup session is addressed by Kit
profile and is ephemeral; a run session (archie-core-qi91) is addressed by
task and attempt and is bounded by the task. This slice serves setup and
answers Unimplemented for run.

The contract, the authorisation, the lifetime and the egress phase are
settled in docs/prds/external-agent-harness.md, "Session contract". The
short version: the daemon serves harness.v1.HarnessService; the dashboard
authorizes the operator as an update on the secret and then dials the
daemon with the harness service token, required even on loopback because a
session is a shell holding an org's credential; the setup container runs
no worker, mounts no worktree, holds a keepalive, and carries an empty
container environment. Install hooks run at the install phase and the
session enters runtime before the shell, so a runtime-phase credential's
token endpoint is the one the proxy intercepts.

Capture is gated by the egress proxy on a granted service, and a setup
session has no task, so the daemon registers a session grant: the
session's proxy token resolves to the org's bindings for the Kit's
declared services. The real token never enters the container: the token
endpoint response is sentinelized and stored as the org's harness secret.

Every teardown path releases the pool slot, revokes the egress session and
the grant, removes the sandbox network, and removes the session's volumes.
The listener requires HARNESS_TOKEN and stops with a 10s grace before
Stop, so an open session cannot hold shutdown to the watchdog leash.
2026-10-09 01:38:41 +11:00
sam 1adbc6a5f9 fix(container): reap orphaned processes in Kit containers 2026-10-09 01:37:57 +11:00
sam 78df7bd454 chore(lint): drop nolint directives that suppress nothing
29 of 59 directives did nothing. Removing each one individually and
re-running the gate revealed no issue from any of them: 20 named gosec,
which is not enabled in .golangci.yml and never has been, plus 4 nilerr
in functions that return no error, 2 dupl where dupl reports nothing
repo-wide, and one each of contextcheck, nestif and unused. The funlen
name on settings.go:147 is gone for the same reason; its gocyclo and
cyclop names are both live.

The unused directive in webui/authorize.go sat on `var _ = slog.Default`,
a statement that only existed to keep the log/slog import alive. Both go.

The 30 remaining directives all suppress a real issue.
2026-10-08 23:29:19 +11:00
sam 64a8c56aee fix(modelcatalog): never serve a disabled provider from the ambient key
disableProvider already cleared a failed provider's credential, but that
made it indistinguishable from a provider nobody configured, so
usableProvider fell back to the catalog's ambient env var (e.g.
OPENAI_API_KEY) and sent turns with a key the operator did not choose.
Mark the provider Disabled when its key fails to resolve, refuse it in
usableProvider, and carry the flag through mergeProviders so a catalog
refresh cannot resurrect it.
2026-10-08 22:59:23 +11:00
sam f968f0518f fix(webui): keep the dashboard token out of the startup log
DashboardURL no longer takes a token, so the startup line cannot embed
?t=<token> in the printed URL. The log now names the token file instead.
2026-10-08 22:57:28 +11:00
sam 0a3ecf268b feat(scheduling): refuse a job payload that names a dangerous command
A scheduled job runs unattended, so a payload that restarts the daemon,
formats a disk or powers the machine down is refused when the job is
created rather than when it fires. scheduling.RefuseDangerousJob is the
one rule every creation path reaches: the dashboard, any control-plane
client and the config seed all replace the schedules document through the
same validator, so a new token is added in one place.
2026-10-08 22:45:28 +11:00