chore(beads): close session-memory curator reference implementation
This commit is contained in:
1 parent
c4871569ce
commit
fdbfc20d54
2 files changed
+2
-1
No files matched your search
@@ -163,3 +163,4 @@
|
||||
{"id":"int-8e36a6b86a595feaebaa50956eb01382","kind":"field_change","created_at":"2026-09-01T16:51:00.094507904Z","actor":"Sam Catlow","issue_id":"archie-core-1786637499161-356-e424e40d.1","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Fixed, but not as originally framed. Investigated wiring RegisterExternal\nfor real: there is no external MemoryProvider implementation anywhere in\nthe repo to construct and pass to it (only internal/memory/builtin.Provider\nexists) -- calling RegisterExternal would be dead plumbing to nothing, not\na fix.\n\nThe actual fix: configuration.validateMemory now rejects memory.provider\nbeing set at all, with a clear reason, instead of accepting it and doing\nnothing. Turns the silent no-op into a loud one. setupMemory's doc comment\nand config.example.toml updated to match; the now-pointless\nprovider_config example section removed.\n\ntoml struct tags (the other half of this bug) were already fixed in\narchie-core-1786637490043's commit.\n\nDrop the rejection once a real external provider (or the domain/memory\nengine family's Honcho proof, archie-core-1786637492031) gives the field\nan effect again.\n\nTestValidateMemoryRejectsProviderSetToAnything covers it. task check is\ngreen."}}
|
||||
{"id":"int-9633d649a25f789b25865683d74755f7","kind":"field_change","created_at":"2026-09-01T16:51:58.124722776Z","actor":"Sam Catlow","issue_id":"archie-core-1786637492031-86-0fcaccc0","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Deprioritized by Sam (2026-09-02): not a current priority. Re-open when there's actual appetite to build against a live Honcho instance -- the engine contract it would implement against (domain/memory.MemoryEngine) is done and stable, so this is unblocked whenever picked back up, not superseded by anything."}}
|
||||
{"id":"int-c7c4a97f5d0d3b21df35da16c9f6ac8e","kind":"field_change","created_at":"2026-09-01T16:58:46.750078973Z","actor":"Sam Catlow","issue_id":"archie-core-1786637499206-358-54f29252","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Complete, all three AC clauses. Design decided first in\ndocs/prds/skill-curator.md (no settled design existed for what \"review,\nprune, improve\" means as concrete behavior): v1 is mechanical validation\nplus safe whitespace normalization only -- no LLM-authored rewrites, no\ndeletion. See the doc for the full \"why this scope, not more\" reasoning.\n\n- Registers and runs through curator.Registry with no curator-specific\n special-casing: uses the existing Register/Runtime path unchanged\n (TestRegistersAndRunsThroughTheRegistry).\n- Its changes are observable and attributable: every write is preceded\n by an Action naming what changed and why (skill.normalized), surfaced\n through the existing curator activity tracker\n (archie-core-1786637489932, already shipped) -- no new observability\n surface needed.\n- Operates within its declared tool set: Manifest.Tools is empty, and\n nothing in the implementation ever touches Registrar.Tools\n (TestManifestDeclaresOnlySkills).\n\ninternal/infrastructure/skillcurator/{store,skillcurator}.go implement\ncurator.SkillStore and curator.CuratorEngine. The store deliberately does\nnot delegate to internal/skill.Discover, which aborts its whole call on\nany one skill's parse failure -- wrong for \"review each skill\nindependently\" (TestPassReviewsEverySkillIndependently covers the\nregression this would otherwise cause). Wired into\ninternal/app/archied/bootstrap.go:setupCurators, rooted the same way\nloadWorkflows resolves skillsBase.\n\ntask check is green (full Go suite + dashboard tests)."}}
|
||||
{"id":"int-1a3b692dbe849f86296f99adc893c60d","kind":"field_change","created_at":"2026-09-01T17:09:13.072769525Z","actor":"Sam Catlow","issue_id":"archie-core-1786637499114-354-e5b475b4","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Complete, all four AC clauses. Design decided first in\ndocs/prds/session-memory-curator.md, most notably: Observation.Identity\nis the session ID, not a user/cross-session identity -- migration-\ndecisions.md#5's memory-scope mapping is still explicitly open and this\nissue has no business deciding it unilaterally.\n\n- Registers and runs through curator.Registry with no special-casing\n (TestRegistersAndRunsThroughTheRegistry).\n- Writes through the memory engine contract, never a concrete store:\n Registrar.MemoryEngines.Get(name).Write, same trust model every other\n curator capability uses.\n- Extraction runs off the hot path: the model call happens inside Pass,\n which the curator runtime already runs off a chat turn's own\n goroutine.\n- What it wrote and why is inspectable: one memory.extracted Action per\n session with a count, through the existing curator activity tracker.\n- Honours the trigger-accounting invariant: Manifest.OnInput = true\n wakes it via the existing WakeOnPrimaryInput wiring, which already\n excludes every curator-derived event kind -- no new code needed for\n that guarantee to hold here.\n\nWired end to end: internal/app/archied/bootstrap.go:setupCurators,\nadapters for gateway.SessionStore (internal/infrastructure/\nsessioncurator/adapter.go) and the shared ai-sdk runtime\n(curatorLLMRunner, main.go).\n\nCaught and fixed during implementation: a model-call failure and an\nunparseable model response were originally conflated into the same\nswallowed-error path, which would have hidden a real provider outage as\n\"nothing to extract.\" Split into two paths;\nTestPassPropagatesALLMFailure is the regression test.\n\ntask check is green (full Go suite + dashboard tests)."}}
|
||||
+1
-1
@@ -254,7 +254,7 @@
|
||||
{"_type":"issue","id":"archie-core-1786637499183-357-e3f7603f","title":"fix(gateway): redelivery dedups the stored turn but still re-runs the model","description":"archie-core-963 made SaveMessage idempotent, but nothing upstream consults the result. cmd/archied/telegram_setup.go:158 respond() calls SaveMessage (now a no-op on redelivery) then unconditionally loads history, calls the model, and saves the reply -- which carries no SourceID, so it always gets a fresh random ID and always appends.\n\nCONFIRMED at store level on both backends: redelivering tg-1 leaves [ping, pong, pong], plus a second billed model turn with any tool side effects executed twice.\n\nThe bead's stated problem ('a re-delivered Telegram update appends a duplicate turn') is half fixed. SaveMessage returns no already-seen signal for the caller to act on.","status":"closed","priority":2,"issue_type":"bug","created_at":"2026-08-08T14:54:50Z","updated_at":"2026-08-08T14:54:52Z","closed_at":"2026-08-08T14:54:53Z","external_ref":"https://github.com/samcharles93/archie-core/issues/378","source_system":"github:https://github.com/samcharles93/archie-core/issues/378:378","metadata":null,"labels":["bug"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637499161-356-e424e40d","title":"[EPIC] Pluggable memory engine: typed family + external providers","description":"Make the memory subsystem a pluggable engine family so an external memory backend (Honcho, or a future alternative) can be bolted on without touching the agent loop, while the file-writing store ships as the default. internal/memory already has a Manager and lifecycle hooks (TurnStartHook, SessionEndHook, SessionSwitchHook); this epic promotes that into a conforming engine family per the strict plugin engine rule in ARCHITECTURE.md rather than inventing a parallel abstraction.\n\n### Design\n\nConstraint from the plugin engine rule: 'engine' requires a typed domain contract, an owning Registry or Manager, explicit lifecycle/health, and narrow typed registrars -- providers never receive *daemon.Daemon or untyped hook maps. The contract must express real memory operations (write observation, query, list, forget), not just Name/Version.\n\n### Acceptance Criteria\n\nMemory is a typed engine family with an owning registry/manager, start/health/stop lifecycle, and narrow typed host access, satisfying every invariant in ARCHITECTURE.md 'Plugin engine rule (strict)' and passing internal/plugin/architecture_test.go. The builtin file-writing store is the shipped default engine and remains the behaviour when nothing is configured. At least one external engine is implementable against the contract without changes to the agent loop or gateway. Engine selection and per-engine settings are configurable, validated, and documented. Failure of a non-default engine degrades to a reported error rather than taking down a turn.","status":"open","priority":2,"issue_type":"epic","created_at":"2026-08-08T14:54:47Z","updated_at":"2026-08-08T14:54:47Z","external_ref":"https://github.com/samcharles93/archie-core/issues/377","source_system":"github:https://github.com/samcharles93/archie-core/issues/377:377","metadata":null,"labels":["epic"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637499136-355-c766a8ee","title":"Quiet autonomous execution and correct forge linkage","description":"Reduce Archie forge noise and make issue/branch/PR lifecycle authoritative. Automatic plan/progress/retry/state-label comments must be disabled; human decisions must remain available through messaging and the Web UI; pushed task branches must be linked to their source issues through the forge API before PR creation.\n\n### Acceptance Criteria\n\nNo automatic plan/progress/retry/state-label comments are emitted; configured human decisions remain actionable through messaging or Web UI; the source issue has a forge branch link after push; PR creation does not rely on a comment or closing directive for linkage; focused tests cover both in-process and RPC forge paths.","status":"closed","priority":2,"issue_type":"feature","created_at":"2026-08-08T14:54:42Z","updated_at":"2026-08-08T14:54:44Z","closed_at":"2026-08-08T14:54:45Z","external_ref":"https://github.com/samcharles93/archie-core/issues/376","source_system":"github:https://github.com/samcharles93/archie-core/issues/376:376","metadata":null,"labels":["enhancement"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637499114-354-e5b475b4","title":"Persistent session-memory curator (reference implementation)","description":"Ship a curator that maintains durable memory across sessions -- extracting and consolidating what is worth keeping from conversation history into the attached memory engine. The second contract consumer, and the one that exercises the curator/memory-engine binding.\n\n### Acceptance Criteria\n\nRegisters and runs through the registry with no special-casing. Writes through the memory engine contract rather than any concrete store. Extraction runs off the hot path so a chat turn never waits on it. What it wrote and why is inspectable. Honours the trigger-accounting invariant so its own writes do not reschedule it.","status":"open","priority":2,"issue_type":"feature","created_at":"2026-08-08T14:54:39Z","updated_at":"2026-08-08T14:54:39Z","external_ref":"https://github.com/samcharles93/archie-core/issues/375","source_system":"github:https://github.com/samcharles93/archie-core/issues/375:375","metadata":null,"labels":["enhancement"],"dependencies":[{"issue_id":"archie-core-1786637499114-354-e5b475b4","depends_on_id":"archie-core-1786637500725-414-9d66a52b","type":"parent-child","created_at":"2026-09-01T15:50:28Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637499114-354-e5b475b4","title":"Persistent session-memory curator (reference implementation)","description":"Ship a curator that maintains durable memory across sessions -- extracting and consolidating what is worth keeping from conversation history into the attached memory engine. The second contract consumer, and the one that exercises the curator/memory-engine binding.\n\n### Acceptance Criteria\n\nRegisters and runs through the registry with no special-casing. Writes through the memory engine contract rather than any concrete store. Extraction runs off the hot path so a chat turn never waits on it. What it wrote and why is inspectable. Honours the trigger-accounting invariant so its own writes do not reschedule it.","status":"closed","priority":2,"issue_type":"feature","created_at":"2026-08-08T14:54:39Z","updated_at":"2026-09-01T17:09:13Z","closed_at":"2026-09-01T17:09:13Z","close_reason":"Complete, all four AC clauses. Design decided first in\ndocs/prds/session-memory-curator.md, most notably: Observation.Identity\nis the session ID, not a user/cross-session identity -- migration-\ndecisions.md#5's memory-scope mapping is still explicitly open and this\nissue has no business deciding it unilaterally.\n\n- Registers and runs through curator.Registry with no special-casing\n (TestRegistersAndRunsThroughTheRegistry).\n- Writes through the memory engine contract, never a concrete store:\n Registrar.MemoryEngines.Get(name).Write, same trust model every other\n curator capability uses.\n- Extraction runs off the hot path: the model call happens inside Pass,\n which the curator runtime already runs off a chat turn's own\n goroutine.\n- What it wrote and why is inspectable: one memory.extracted Action per\n session with a count, through the existing curator activity tracker.\n- Honours the trigger-accounting invariant: Manifest.OnInput = true\n wakes it via the existing WakeOnPrimaryInput wiring, which already\n excludes every curator-derived event kind -- no new code needed for\n that guarantee to hold here.\n\nWired end to end: internal/app/archied/bootstrap.go:setupCurators,\nadapters for gateway.SessionStore (internal/infrastructure/\nsessioncurator/adapter.go) and the shared ai-sdk runtime\n(curatorLLMRunner, main.go).\n\nCaught and fixed during implementation: a model-call failure and an\nunparseable model response were originally conflated into the same\nswallowed-error path, which would have hidden a real provider outage as\n\"nothing to extract.\" Split into two paths;\nTestPassPropagatesALLMFailure is the regression test.\n\ntask check is green (full Go suite + dashboard tests).","external_ref":"https://github.com/samcharles93/archie-core/issues/375","source_system":"github:https://github.com/samcharles93/archie-core/issues/375:375","metadata":null,"labels":["enhancement"],"dependencies":[{"issue_id":"archie-core-1786637499114-354-e5b475b4","depends_on_id":"archie-core-1786637500725-414-9d66a52b","type":"parent-child","created_at":"2026-09-01T15:50:28Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637499092-353-ed4800d2","title":"Regression tests: NellDB adapter — edge cases, error recovery, concurrent access","description":"internal/nell/adapter_test.go has 7 tests covering the happy path. Missing: corrupted log recovery, concurrent Enqueue/ClaimNext, Get/List with empty store, oversized event payloads, context cancellation during operations, observer callback error isolation.","status":"closed","priority":2,"issue_type":"task","created_at":"2026-08-08T14:54:34Z","updated_at":"2026-08-08T14:54:36Z","closed_at":"2026-08-08T14:54:37Z","external_ref":"https://github.com/samcharles93/archie-core/issues/374","source_system":"github:https://github.com/samcharles93/archie-core/issues/374:374","metadata":null,"labels":["task"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637499063-352-c2b85c1a","title":"fix(gateway): synchronize sessionTracker.active","description":"sessionTracker.active is a plain map with no mutex. go-telegram/bot dispatches each update in its own goroutine, so resolve() writes it while getActive() reads it concurrently. Backend-agnostic Go data race.","status":"closed","priority":2,"issue_type":"task","created_at":"2026-08-08T14:54:29Z","updated_at":"2026-08-08T15:34:03Z","closed_at":"2026-08-08T15:34:04Z","external_ref":"https://github.com/samcharles93/archie-core/issues/373","source_system":"github:https://github.com/samcharles93/archie-core/issues/373:373","metadata":null,"labels":["task"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637499041-351-b4253aa3","title":"Link pushed task branch to source issue before opening PR","description":"After the task branch is successfully pushed, call the forge branch-link operation for the source issue, then create the PR without relying on a PR comment or Closes directive to associate it. Propagate link failures and cover Gitea plus forge RPC behavior.","status":"closed","priority":2,"issue_type":"bug","created_at":"2026-08-08T14:54:23Z","updated_at":"2026-08-08T14:54:26Z","closed_at":"2026-08-08T14:54:27Z","external_ref":"https://github.com/samcharles93/archie-core/issues/372","source_system":"github:https://github.com/samcharles93/archie-core/issues/372:372","metadata":null,"labels":["bug"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
|
||||
Reference in new issue
Block a user