docs(skill): drop comments that named the deleted skill.Discover
Lane F deleted skill.Discover/skill.DiscoverPlugins/skill.Skill (no
production caller) in 952bf4d, which left three comments in packages it did
not own describing or contrasting behaviour against a symbol that no longer
exists -- a dangling reference is the same drift class as an unreachable
code path, just cheaper to fix.
The behavioural statements are kept; only the dead names go. internal/skill's
Catalog skips a SKILL.md it cannot read, while this curator's store reports
the per-skill failure as an Action, so the test's rationale still holds
without naming the removed function.
Comment-only: no behaviour change, task check exit 0.
This commit is contained in:
1 parent
280b744d8c
commit
f4e32ee6d4
3 files changed
+12
-13
No files matched your search
@@ -13,10 +13,10 @@ import (
|
||||
// ── regression: Gap 7 -- plugins discovered but not executed ─────────
|
||||
|
||||
func TestSkillPluginsAvailableDuringStageExecution(t *testing.T) {
|
||||
// Gap 7: skill.Discover() populates Skill.Plugins but nothing calls
|
||||
// plugin.Run() during stage execution. Plugins must be loaded from
|
||||
// the skill directory alongside the SKILL.md body and made available
|
||||
// to the agent as tools during stage runs.
|
||||
// Regression: plugins shipped alongside a skill were loaded from the
|
||||
// skill directory but never executed during a stage. Plugins must be
|
||||
// loaded from the skill directory alongside the SKILL.md body and made
|
||||
// available to the agent as tools during stage runs.
|
||||
//
|
||||
// This test creates a worktree with a skill that has a bundled plugin.
|
||||
// It runs an AgentStage and verifies the plugin was loaded and is
|
||||
|
||||
@@ -148,7 +148,7 @@ func TestPassLeavesACleanSkillUntouchedWithNoAction(t *testing.T) {
|
||||
func TestPassReviewsEverySkillIndependently(t *testing.T) {
|
||||
// A parse failure in one skill must not abort review of the others --
|
||||
// the whole reason this curator has its own store instead of
|
||||
// delegating List/Read to internal/skill.Discover.
|
||||
// delegating List/Read to a single bulk discovery call.
|
||||
t.Parallel()
|
||||
root := t.TempDir()
|
||||
writeSkill(t, root, "broken", "---\nname: [unterminated\n---\n")
|
||||
|
||||
@@ -23,12 +23,10 @@ const skillsDir = ".agents/skills"
|
||||
const skillFile = "SKILL.md"
|
||||
|
||||
// Store implements curator.SkillStore over one root directory's
|
||||
// .agents/skills/*/SKILL.md files. Unlike internal/skill.Discover, which
|
||||
// parses every skill up front and fails the whole call if any one of
|
||||
// them doesn't parse, Store's List and Read never parse frontmatter
|
||||
// themselves beyond a best-effort Description -- a per-skill parse
|
||||
// failure is the curator's problem to report as an Action, not this
|
||||
// store's problem to abort on. See docs/prds/skill-curator.md.
|
||||
// .agents/skills/*/SKILL.md files. List and Read never parse frontmatter
|
||||
// themselves beyond a best-effort Description: a per-skill parse failure is
|
||||
// the curator's problem to report as an Action, not this store's problem to
|
||||
// abort on. See docs/prds/skill-curator.md.
|
||||
type Store struct {
|
||||
root string
|
||||
}
|
||||
@@ -47,8 +45,9 @@ func (s *Store) skillPath(name string) string {
|
||||
}
|
||||
|
||||
// List returns every skill directory under root, in directory order. A
|
||||
// directory with no SKILL.md is skipped -- consistent with
|
||||
// internal/skill.Discover's own treatment of that case -- and a missing
|
||||
// directory with no SKILL.md is skipped -- consistent with internal/skill's
|
||||
// Catalog, which treats an unreadable or absent SKILL.md as "no skill here"
|
||||
// rather than an error -- and a missing
|
||||
// skills directory returns an empty list, not an error, matching
|
||||
// internal/skill's discovery convention (missing directory is not an
|
||||
// error).
|
||||
|
||||
Reference in new issue
Block a user