chore(beads): close archie-core-1786637500926-421-7c63bcd3
This commit is contained in:
1 parent
3bb68671b7
commit
f0b984a40b
2 files changed
+2
-1
No files matched your search
@@ -205,3 +205,4 @@
|
||||
{"id":"int-632b5998e10e3eb8dfab5e44c132b945","kind":"field_change","created_at":"2026-09-02T20:48:07.710891177Z","actor":"Sam Catlow","issue_id":"archie-core-7d5u.6","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"ARCHITECTURE.md and plugins-and-extensions.md reconciled with shipped webhook intake and the 7d5u.1 decision; config.example.toml already documented the intake flag/default; CLAUDE.md gained the internal/forge/webhook trap. Commit 8b53dc3."}}
|
||||
{"id":"int-2ad57b7174de600220357961732784fe","kind":"field_change","created_at":"2026-09-02T20:49:56.069736209Z","actor":"Sam Catlow","issue_id":"archie-core-1786637499814-382-b27575d6","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Stale as of 2026-08-08's 56-issue count; verified today golangci-lint run ./... reports 0 issues (same command Taskfile's lint target runs), thresholds unchanged (cyclop max-complexity 15, gocognit min-complexity 30 in .golangci.yml), no threshold loosening. All 21 remaining //nolint suppressions (nilerr x14, contextcheck x4, others) carry a documented reason in an adjacent comment. Acceptance criteria met."}}
|
||||
{"id":"int-cb5978db917dc01665cd1aa1b8dcef5e","kind":"field_change","created_at":"2026-09-02T20:50:07.413197403Z","actor":"Sam Catlow","issue_id":"archie-core-1786637499664-377-c2818afd","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Verified 2026-09-03: golangci-lint run ./... reports 0 issues repo-wide (thresholds unchanged from 9298afd's config: cyclop 15, gocognit 30). The gate this epic's description called RED is green. Its last known child (Phase 5, the 56-finding remainder) closed for the same reason -- see archie-core-1786637499814-382-b27575d6."}}
|
||||
{"id":"int-f308fd1259b3570d6fe3c3ac585b7757","kind":"field_change","created_at":"2026-09-02T20:57:28.723473462Z","actor":"Sam Catlow","issue_id":"archie-core-1786637500926-421-7c63bcd3","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Fixed in ui/src/dashboard/dashboard.css: .dash-top > div now flexes and .card grows to fill it, scoped to the HEALTH row only. Verified via a static HTML repro using the real project CSS (Playwright, computed geometry before/after) -- card heights and bottom edges now match. task check green, ui/dist rebuilt. Commit a9a056c."}}
|
||||
+1
-1
@@ -221,7 +221,7 @@
|
||||
{"_type":"issue","id":"archie-core-1786637501009-424-5b8332dd","title":"daemon: label dispatch trigger with empty label matches every open issue","description":"`internal/daemon/daemon.go` `pollIssuesWithConfig()`, the `\"label\"` (and `\"either\"`) trigger branch calls:\n\n```go\nissues, err := fg.IssuesWithLabel(ctx, repo.Owner, repo.Name, cfg.Label)\n```\n\n`cfg.Label` is a top-level `Config.Label` field (`internal/config/config.go:364`) -- a different field from `[dispatch.labels]`, which maps task *states* (queued/working/waiting/pr/parked) to their forge labels for a different purpose. It's easy to configure `[dispatch.labels]` and reasonably assume the label-trigger match target is covered, while leaving the actual `label` field that controls trigger matching unset.\n\n`GitHubClient.IssuesWithLabel` (`internal/forge/github.go:103`) passes that straight through as `Labels: []string{label}` to the GitHub issues-list API. With `label == \"\"`, GitHub does not filter by label at all -- it returns every open issue in the repo.\n\n### Impact (live incident, 2026-08-09)\n\nDeployed `dispatch.trigger = \"label\"` on carina without setting `label`. The daemon queued 124 unrelated open issues in one poll cycle (everything from epics to unrelated feature requests), and one reached a running agent container before it was caught and stopped manually.\n\n### Expected\n\n`pollIssuesWithConfig`'s `\"label\"` branch should refuse to poll (log an error and return, same as any other misconfiguration) when `cfg.Label` is empty, rather than silently falling through to an unfiltered API call. Ideally this is also caught at config-validation time (`internal/infrastructure/configuration/validate.go`) when `dispatch.trigger` is `\"label\"` or `\"either\"` and `label` is blank.\n","status":"closed","priority":2,"issue_type":"bug","assignee":"samcharles93","created_at":"2026-08-08T16:26:41Z","updated_at":"2026-08-20T13:02:18Z","started_at":"2026-08-20T12:57:03Z","closed_at":"2026-08-20T13:02:18Z","close_reason":"Fixed in fix/label-dispatch-empty-label (31efdcf): pollIssuesWithConfig/pollEitherWithConfig now refuse the label poll when cfg.Label is empty, and validateDispatch rejects the misconfiguration at load time. Adversarially reviewed; one weak test strengthened to actually verify assignee matches survive.","external_ref":"https://github.com/samcharles93/archie-core/issues/445","source_system":"github:https://github.com/samcharles93/archie-core/issues/445:445","metadata":null,"labels":["bug"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637500980-423-12a63a68","title":"webui(chat): dynamic header content breaks the fixed no-scroll chat layout","description":"The Chat page's layout (`ui/src/chat/chat.css`) is built for a fixed, no-scroll chat window: `.chat-workspace` uses `grid-template-rows: auto minmax(0, 1fr) auto` with `overflow: hidden`, and only `.chat-transcript` (the message list) is meant to scroll. `.chat-page` only sets `min-height: calc(100vh - 5rem)`, not a fixed height.\n\nAny dynamic content injected above `.chat-layout` -- the status/error banner (see #443), extra status pills, a long \"Reload Telegram\"/\"Check updates\" row wrapping on a narrower viewport -- has no height budget accounted for, so it just pushes the whole grid down and grows total page height past the viewport. That breaks the intended design: the page itself scrolls instead of just the transcript.\n\nScreenshot: Chat page with the 501 error banner (see #443) visibly adding an extra row that isn't accounted for in the fixed layout.\n\n### Expected\n\nThe top status/banner region should have a bounded height (or the page should reserve space for it) so injecting a banner or wrapping the status pills never causes page-level scroll -- only `.chat-transcript` should ever scroll.\n","status":"closed","priority":2,"issue_type":"bug","created_at":"2026-08-08T16:17:47Z","updated_at":"2026-08-08T16:45:42Z","closed_at":"2026-08-08T16:45:43Z","external_ref":"https://github.com/samcharles93/archie-core/issues/444","source_system":"github:https://github.com/samcharles93/archie-core/issues/444:444","metadata":null,"labels":["bug"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637500953-422-01075562","title":"webui(chat): raw 501 error banner when update-check is unconfigured","description":"The Chat page shows a raw \"501 Not Implemented\" banner across the top when the release-update-check feature isn't configured. `POST /api/chat/update` correctly returns 501 when `chat.telegram.update_check_command` is unset in config (`cmd/archied/telegram_setup.go` `makeUpdateService` returns nil in that case, which is a legitimate, expected \"not configured\" state -- same category as an unconfigured channel).\n\nThe bug is in the frontend's handling of that response. `ui/src/chat/chat.js` `refreshUpdate()` is called unconditionally on page load (line ~365) with no guard, and its catch block does:\n\n```js\n} catch (err) {\n updatePanel.replaceChildren(el(\"span\", err.message || \"Updates unavailable\"));\n}\n```\n\nThis renders the raw fetch error text (including the literal HTTP status) directly into a visible page banner, rather than treating \"updates not configured\" as a quiet empty state -- the same pattern already used for an unconfigured channel on the Channels page (\"Not configured\", not an error).\n\n### Expected\n\nA 501/\"not configured\" response from `/api/chat/update` should render nothing (or a subtle \"update checks not configured\" note), not a raw HTTP error banner.\n\nScreenshot: Chat page, banner reading \"501 Not Implemented\" directly under the top status bar.\n","status":"closed","priority":2,"issue_type":"bug","created_at":"2026-08-08T16:17:37Z","updated_at":"2026-08-08T16:44:14Z","closed_at":"2026-08-08T16:44:15Z","external_ref":"https://github.com/samcharles93/archie-core/issues/443","source_system":"github:https://github.com/samcharles93/archie-core/issues/443:443","metadata":null,"labels":["bug"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637500926-421-7c63bcd3","title":"webui: Gate pulse card content should top-align with Finish setting up card","description":"On the dashboard's HEALTH section, the \"Gate pulse\" card doesn't visually align with the \"Finish setting up\" card next to it. \"Finish setting up\" is top-aligned (title, progress bar, checklist all stacked from the top), while \"Gate pulse\"'s empty-state content (\"No completed runs yet\" / \"Once Archie finishes a task...\") is vertically centered in the card, leaving large uneven whitespace above and below relative to its sibling.\n\nScreenshot: dashboard HEALTH row, two cards side by side -- left card (\"Finish setting up\") content flows from the top; right card (\"Gate pulse\") content floats centered.\n\n### Expected\n\nThe \"Gate pulse\" card's content (including its empty state) should top-align the same way \"Finish setting up\" does, so the two HEALTH cards read as one consistent row rather than two different layout patterns.\n","status":"in_progress","priority":2,"issue_type":"task","assignee":"Sam Catlow","created_at":"2026-08-08T16:15:17Z","updated_at":"2026-09-02T20:57:15Z","started_at":"2026-09-02T20:57:15Z","lease_expires_at":"2026-09-02T21:02:15Z","heartbeat_at":"2026-09-02T20:57:15Z","external_ref":"https://github.com/samcharles93/archie-core/issues/442","source_system":"github:https://github.com/samcharles93/archie-core/issues/442:442","metadata":null,"labels":["task"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637500926-421-7c63bcd3","title":"webui: Gate pulse card content should top-align with Finish setting up card","description":"On the dashboard's HEALTH section, the \"Gate pulse\" card doesn't visually align with the \"Finish setting up\" card next to it. \"Finish setting up\" is top-aligned (title, progress bar, checklist all stacked from the top), while \"Gate pulse\"'s empty-state content (\"No completed runs yet\" / \"Once Archie finishes a task...\") is vertically centered in the card, leaving large uneven whitespace above and below relative to its sibling.\n\nScreenshot: dashboard HEALTH row, two cards side by side -- left card (\"Finish setting up\") content flows from the top; right card (\"Gate pulse\") content floats centered.\n\n### Expected\n\nThe \"Gate pulse\" card's content (including its empty state) should top-align the same way \"Finish setting up\" does, so the two HEALTH cards read as one consistent row rather than two different layout patterns.\n","status":"closed","priority":2,"issue_type":"task","assignee":"Sam Catlow","created_at":"2026-08-08T16:15:17Z","updated_at":"2026-09-02T20:57:29Z","started_at":"2026-09-02T20:57:15Z","closed_at":"2026-09-02T20:57:29Z","close_reason":"Fixed in ui/src/dashboard/dashboard.css: .dash-top \u003e div now flexes and .card grows to fill it, scoped to the HEALTH row only. Verified via a static HTML repro using the real project CSS (Playwright, computed geometry before/after) -- card heights and bottom edges now match. task check green, ui/dist rebuilt. Commit a9a056c.","external_ref":"https://github.com/samcharles93/archie-core/issues/442","source_system":"github:https://github.com/samcharles93/archie-core/issues/442:442","metadata":null,"labels":["task"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637500900-420-335d8bbb","title":"archied: [[repos]] entries can't span more than one forge","description":"`[forge]` is a single top-level block resolved once (`resolveForge` in `cmd/archied/main.go:332`) into one `forge.Forge` client, shared by every entry in `[[repos]]`. The `Repo` struct (`internal/config/config.go:56`) has no per-repo `type`/`host`/`token` override -- `owner`/`name` are the only identity fields, so every repo is assumed to live on whatever single forge the daemon is configured for.\n\nThis blocks a `[[repos]]` list spanning more than one forge (e.g. one repo on GitHub, another on a Gitea instance) under a single archied identity. Discovered live on carina 2026-08-09: switching `[forge]` to `type = \"github\"` for `archie-core` made the daemon start querying the `tau` repo entry (still Gitea-hosted) against `api.github.com`, producing repeated 404s (`get repo sam/tau: GET https://api.github.com/repos/sam/tau: 404 Not Found`) until the `tau` entry was removed as a workaround.\n\n### Expected\n\nEach `[[repos]]` entry should be able to declare (or inherit a default) its own forge type/host/token, and the daemon should resolve a forge client per repo rather than one globally, so repos on different forges can be dispatched from the same archied instance.\n\n### Workaround in place\n\n`tau`'s `[[repos]]` entry was removed from carina's `config.toml` so `archie-core` (now GitHub) doesn't try to poll it against the wrong forge. `tau` gets no automated dispatch from this instance until this is fixed or it gets a separate identity.\n","status":"open","priority":2,"issue_type":"bug","assignee":"samcharles93","created_at":"2026-08-08T16:09:53Z","updated_at":"2026-08-12T03:40:29Z","external_ref":"https://github.com/samcharles93/archie-core/issues/441","source_system":"github:https://github.com/samcharles93/archie-core/issues/441:441","metadata":null,"labels":["bug"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637500871-419-5bee4d20","title":"fix(webui): open redirect in dashboard token-exchange handler","description":"CodeQL alert (`go/unvalidated-url-redirection`, medium severity): the dashboard token-exchange handler in `internal/webui/auth.go` redirected to a Location built directly from the incoming request's path and query, with no validation.\n\nA request whose path starts with `//` (e.g. `GET //evil.example/x?t=\u003ctoken\u003e`) causes `clean.RequestURI()` to reproduce `//evil.example/x` verbatim. Browsers treat a Location header starting with `//` as protocol-relative, so this redirects the client off-host after a legitimate token exchange -- a classic open-redirect via the Go `net/url` double-slash gotcha.\n\n### Fix\n\nAdded `sameOriginPath()` in `internal/webui/auth.go`, which collapses any leading `//` down to a single `/` before the value ever reaches `http.Redirect`. Covered by a red-then-green test in `internal/webui/auth_test.go` (`TestRequireToken_RedirectRejectsProtocolRelativePath`) that reproduces the exploit path and asserts the Location header is never protocol-relative.\n\nRef: [code-scanning alert #4](https://github.com/samcharles93/archie-core/security/code-scanning/4) (dismissed alerts #1-3 on that same scan were false positives -- allocations already bounded by `min()`, see their dismissal comments).\n","status":"closed","priority":2,"issue_type":"bug","created_at":"2026-08-08T15:13:11Z","updated_at":"2026-08-08T15:48:10Z","closed_at":"2026-08-08T15:48:11Z","external_ref":"https://github.com/samcharles93/archie-core/issues/440","source_system":"github:https://github.com/samcharles93/archie-core/issues/440:440","metadata":null,"labels":["bug"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637500839-418-cad065a6","title":"SOUL loader with per-turn reload and default fallback","description":"Load the SOUL file from the config dir into the identity slot of the rendered prompt, re-reading it per turn so an edit takes effect on the next message with no restart.\n\n### Acceptance Criteria\n\nSOUL content is rendered into the identity slot ahead of the invariant sections. An absent, empty or unreadable SOUL falls back to the shipped default identity rather than rendering nothing. Editing the file changes the next turn's prompt with no restart. A read error is logged once and degrades to the default; it never fails the turn. Size is bounded so an oversized SOUL cannot crowd out the rules.","status":"open","priority":2,"issue_type":"feature","created_at":"2026-08-08T14:59:24Z","updated_at":"2026-08-08T14:59:24Z","external_ref":"https://github.com/samcharles93/archie-core/issues/439","source_system":"github:https://github.com/samcharles93/archie-core/issues/439:439","metadata":null,"labels":["enhancement"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
|
||||
Reference in new issue
Block a user