chore(beads): record t2db.19 Forge/Channel scoping update
This commit is contained in:
1 parent
c08988e1f3
commit
f08b9b2bc4
1 file changed
+1
-1
+1
-1
@@ -95,7 +95,7 @@
|
||||
{"_type":"issue","id":"archie-core-tb3a","title":"Fix streaming review blockers for inline tool calls","description":"Resolve the four evidence-gated findings in merged inline tool-call streaming: preserve the authoritative Telegram reply when final edits fail; keep Telegram network I/O off the model FullStream consumer and cancellable; correlate tool inputs with results and render a bounded redacted parameter summary; snapshot show_tool_calls per live reply to avoid reload races. Add regression tests for every path and run task check plus lint/race validation.","acceptance_criteria":"Regression tests fail on the merged implementation and pass after the fix. Final edit failure falls back to normal split delivery. Delta and ToolCall callbacks do not wait on Telegram HTTP and stop cancels in-flight rendering. Completed tool events include bounded redacted parameters correlated by tool-call ID. Reload cannot race an in-flight reply's show_tool_calls setting. task check passes, golangci-lint reports no new findings, and focused race tests pass.","notes":"Implemented in worktree /tmp/archie-core-tb3a on branch fix/archie-core-tb3a. Added cancellable async Telegram rendering, final edit failure fallback through normal split delivery, call-ID-correlated bounded conservative parameter summaries, atomic per-reply show_tool_calls snapshots, SSE/UI parameter rendering, rebuilt ui/dist, and regression tests. Validation: GOFLAGS=-buildvcs=false task check passed; golangci-lint --new-from-rev=HEAD ./... reported 0 issues; focused race suite passed; fresh adversarial reviewer reported PASS with zero findings. Plain task check is blocked in linked worktrees by Go VCS stamping exit 128, hence buildvcs override.\n2026-08-24 reconciliation: the close reason's 'worktree left uncommitted' is stale. The work did land on main via ba33527 (Merge pull request #477 from samcharles93/fix/archie-core-tb3a); verified on main: gateway/stream.go sensitiveParameterKey+redactToolParameters, telegram/live.go per-reply showToolCalls snapshot, webui/api_chat.go gating. The /tmp/archie-core-tb3a worktree and its branch are gone, as expected.\n","status":"closed","priority":1,"issue_type":"bug","assignee":"Sam Catlow","owner":"sam@catlow.tech","created_at":"2026-08-13T18:05:35Z","created_by":"Sam Catlow","updated_at":"2026-08-24T07:29:09Z","started_at":"2026-08-13T18:05:39Z","closed_at":"2026-08-13T18:35:26Z","close_reason":"Completed and independently reviewed; worktree left uncommitted per conservative repository policy.","external_ref":"https://github.com/samcharles93/archie-core/issues/485","dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-dzx","title":"Remove duplicate archie-agent safe.directory setup","description":"## Problem\\ncmd/archie-agent/main.go configures git safe.directory inline and then calls markWorktreeSafe, so startup writes the same global git configuration twice.\\n\\n## Scope\\nKeep markWorktreeSafe as the single tested production path and remove the older inline exec.Command block/import. Add regression coverage proving startup wiring has exactly one authoritative safe-directory call.\\n\\n## Acceptance\\n- archie-agent startup invokes markWorktreeSafe exactly once\\n- no second inline safe.directory command remains in main.go\\n- cmd/archie-agent tests and repository quality gate pass","acceptance_criteria":"Single tested safe.directory setup path remains; duplicate inline command is removed; tests and task check pass","notes":"Red proof: TestMainConfiguresWorktreeSafetyOnce failed with 2 setup paths before implementation. Green proof: go test/vet/build ./cmd/archie-agent/... passed; golangci-lint --new-from-rev=HEAD reported 0 issues. Fresh adversarial review found no blockers. Full task check was not run because the working tree contains unrelated in-progress changes and task check rewrites files; scoped package gate used per repository protocol.","status":"closed","priority":1,"issue_type":"bug","assignee":"Sam Catlow","owner":"sam@catlow.tech","created_at":"2026-08-13T16:10:09Z","created_by":"Sam Catlow","updated_at":"2026-08-13T16:13:48Z","started_at":"2026-08-13T16:10:24Z","closed_at":"2026-08-13T16:13:48Z","close_reason":"Removed duplicate inline safe.directory setup; markWorktreeSafe is now the single tested production path","external_ref":"https://github.com/samcharles93/archie-core/issues/470","dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-t2db.20","title":"eda: LSP/serve mode for cmd/archie-playbooks","description":"Second entrypoint of the gopls-shaped standalone binary from t2db.12 (lint mode already shipped). Sam explicitly kept this in scope, not deferred, because it's the same schema source as the linter, just a different consumer -- the design doc's shared-package, thin-consumer principle.\n\nGrounded by a crew investigation pass (2026-09-03): the loader decodes with yaml.Unmarshal into a plain map, which discards line numbers -- today's lint findings are file-granular only. A useful LSP (hover/completion/inline errors) needs real positions, so the yaml.Node decoding upgrade is a practical prerequisite, not a nice-to-have. internal/domain/eda/expr's Compile/Eval already return structured errors that should map cleanly to diagnostics -- confirm this rather than re-deriving error shapes.","design":"Two-part scope, decide whether to split into two tickets or do both together once you've read the code:\n1. yaml.Node decoding upgrade: replace the plain-map yaml.Unmarshal decode path (internal/domain/workflow/routing.go and the t2db.11 directory-merge loader) with yaml.Node-based decoding that retains line/column info, without changing any existing collision-detection behavior -- this is a pure enhancement to error positions, not a behavior change. Verify byte-identical error MESSAGES where line info isn't yet used, add line numbers where the new capability lets you.\n2. serve/lsp command: add a new entry to cmd/archie-playbooks's existing command table (do not restructure -- t2db.12 built it explicitly to take this addition without restructuring). Scope: a minimal LSP surface (diagnostics at minimum; hover/completion if straightforward) over the same compile/validate path the lint command already uses. Weigh a tiny hand-rolled LSP protocol implementation (fits organisation.md's thin cmd/ rule and the narrow-capability-family principle) against pulling in an LSP library -- vet any new dependency via the vetting-dependencies skill before adding it.","acceptance_criteria":"cmd/archie-playbooks gains a serve (or lsp) subcommand alongside lint, using the same underlying compile/validate calls -- no second validation path. Diagnostics report file:line where the yaml.Node upgrade provides it. Existing lint-mode tests and behavior are unchanged (regression-tested). task check passes.","status":"open","priority":2,"issue_type":"task","owner":"sam@catlow.tech","created_at":"2026-09-02T18:12:41Z","created_by":"Sam Catlow","updated_at":"2026-09-02T18:12:41Z","dependencies":[{"issue_id":"archie-core-t2db.20","depends_on_id":"archie-core-t2db","type":"parent-child","created_at":"2026-09-02T18:12:41Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-t2db.19","title":"eda: scope Channel and Forge action positions (investigation, blocked on execution-time gaps)","description":"Investigation ticket -- decide the typed-contract shape for the two remaining named action positions (Channel, Forge) before implementing either. Blocked on archie-core-t2db.17 (idempotency) since both are naturally side-effecting positions; investigation/scoping can proceed now, implementation cannot land before .17 resolves.\n\nGrounded by a crew investigation pass (2026-09-03): Channel already exists as internal/channels.Channel (embeds gateway.Gateway + ConfigSchema/ValidateConfig, telegram/email/webhook implementations registered at daemon startup). Forge already exists as internal/forge.Forge = IssueForge + PullRequestForge + RepoForge, with New(...) switching on github/gitea/none; the daemon poller currently special-cases forge operations directly rather than through any addressable position.","design":"Decide, for each position:\n1. Typed contract shape: native-Go-by-name (Channel/Forge are already typed Go interfaces -- likely just need Args/Result structs and a name-\u003einstance registry lookup, NO Yaegi/go:generate) vs modeled as a Module-kind (Yaegi-interpreted, per module-position.md's pattern). Do not assume the Module pattern transfers verbatim -- these are existing native interfaces, Module's whole point was giving Yaegi-authored code a typed contract, which doesn't apply here. The likely right answer is native-Go, stated explicitly.\n2. Operation/Args/Result shape per position: for Channel, what an action takes (channel name, message, payload?) and returns (delivered bool / result map feeding actions.\u003cid\u003e.result.\u003cfield\u003e in CEL). For Forge, which operations from IssueForge/PullRequestForge/RepoForge become addressable (comment-on-issue is naturally idempotency-safe by event+issue identity; open-PR is a heavier, less-clean case -- explicitly decide whether open-PR is in the first Forge slice or deferred).\n3. Host access: how the coordinator resolves a named channel/forge to the daemon's already-wired instance -- this is the same 'narrow host access' concern module-position.md solved for ModuleDir, applied to instances that already exist at daemon startup rather than being loaded from a directory.\n\nRead internal/channels/channel.go, the telegram/email/webhook implementations, internal/forge/forge.go, and where internal/daemon's poll path currently special-cases forge operations (the code to lift into an addressable position) before writing anything.","acceptance_criteria":"A design-doc addition (new docs/prds/ file or a section in eda-playbook-engine.md, your call which fits better -- state why) resolving: typed-contract shape for each position, Args/Result shapes, and the host-access/resolution mechanism. No implementation in this ticket.","status":"open","priority":2,"issue_type":"task","owner":"sam@catlow.tech","created_at":"2026-09-02T18:12:40Z","created_by":"Sam Catlow","updated_at":"2026-09-02T18:12:40Z","dependencies":[{"issue_id":"archie-core-t2db.19","depends_on_id":"archie-core-t2db","type":"parent-child","created_at":"2026-09-02T18:12:40Z","created_by":"Sam Catlow","metadata":"{}"},{"issue_id":"archie-core-t2db.19","depends_on_id":"archie-core-t2db.17","type":"blocks","created_at":"2026-09-02T18:12:40Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":1,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-t2db.19","title":"eda: scope Channel and Forge action positions (investigation, blocked on execution-time gaps)","description":"Investigation ticket -- decide the typed-contract shape for the two remaining named action positions (Channel, Forge) before implementing either. Blocked on archie-core-t2db.17 (idempotency) since both are naturally side-effecting positions; investigation/scoping can proceed now, implementation cannot land before .17 resolves.\n\nGrounded by a crew investigation pass (2026-09-03): Channel already exists as internal/channels.Channel (embeds gateway.Gateway + ConfigSchema/ValidateConfig, telegram/email/webhook implementations registered at daemon startup). Forge already exists as internal/forge.Forge = IssueForge + PullRequestForge + RepoForge, with New(...) switching on github/gitea/none; the daemon poller currently special-cases forge operations directly rather than through any addressable position.","design":"See docs/prds/channel-forge-positions.md (committed 2026-09-03). Forge is fully scoped and ready to implement once t2db.17 lands: native-Go-by-name (not Module-kind) over the existing internal/forge.Forge interface, close-issue/link-branch as the safe first operations, create-pr deferred. Channel is NOT resolved -- the crew investigation's assumption that channels.Channel has an addressable send capability is FALSE (verified: only Name/Start/Stop + config validation exist, no Send method anywhere in internal/channels or internal/gateway). This is now an open product/architecture decision for Sam: whether 'Channel action' means (1) a new playbook-scoped notification capability distinct from the interactive chat channels, or (2) reusing the interactive channels with some new conversation-scoping mechanism for a non-chat trigger. Do not implement a Channel position until Sam decides which.","acceptance_criteria":"A design-doc addition (new docs/prds/ file or a section in eda-playbook-engine.md, your call which fits better -- state why) resolving: typed-contract shape for each position, Args/Result shapes, and the host-access/resolution mechanism. No implementation in this ticket.","status":"open","priority":2,"issue_type":"task","owner":"sam@catlow.tech","created_at":"2026-09-02T18:12:40Z","created_by":"Sam Catlow","updated_at":"2026-09-02T18:15:31Z","dependencies":[{"issue_id":"archie-core-t2db.19","depends_on_id":"archie-core-t2db","type":"parent-child","created_at":"2026-09-02T18:12:40Z","created_by":"Sam Catlow","metadata":"{}"},{"issue_id":"archie-core-t2db.19","depends_on_id":"archie-core-t2db.17","type":"blocks","created_at":"2026-09-02T18:12:40Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":1,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-t2db.16","title":"eda: reduce complexity in bootstrap.go loadWorkflows and routing.go LoadPlaybookDirs","description":"task check now runs golangci-lint (Sam's explicit requirement, 2026-09-03 -- catch lint regressions as part of the definitive gate, not just fmt/vet/build/test). First run surfaced two real findings, both accumulated debt from this session's own EDA slices, not pre-existing:\n\n1. internal/app/archied/bootstrap.go:647 loadWorkflows -- cyclomatic complexity 17, max 15 (cyclop). Grew incrementally across t2db.9 (kindWorkflows), t2db.10 (labelWorkflows), t2db.11 (PlaybookDirs merge), t2db.15 (EDAPlaybookDir) -- each addition was small, the function as a whole crossed the threshold.\n2. internal/domain/workflow/routing.go:103 LoadPlaybookDirs -- cognitive complexity 52, max 30 (gocognit), from t2db.11's directory-merge loader (kind-vs-label detection, per-file and cross-file collision checks all inline).\n\nRoot-cause fix required, not suppression: no //nolint. Extract cohesive sub-steps into named helper functions -- this is exactly the kind of case AGENTS.md's Architectural Simplicity rule describes (prefer a clean extraction over papering past a threshold).","design":"For loadWorkflows: extract the four independent load-and-set steps (kind-file load, label-file load, playbook-dirs load+merge, EDAPlaybookDir load) into named helpers the top-level function calls in sequence, each returning its own error for the existing log-and-abort pattern. Do not change the log-and-abort error-handling shape or field names.\n\nFor LoadPlaybookDirs: split the per-file parsing loop's kind-detection-vs-label-detection-vs-collision-check logic into a couple of named helpers (e.g. classifyBinding, checkCollision) called from the main loop, keeping the existing collision error messages and behavior byte-identical -- this is a pure refactor, not a behavior change.","acceptance_criteria":"golangci-lint run ./... reports zero cyclop/gocognit findings on these two functions. All existing tests for workflow.LoadPlaybookDirs, kindWorkflows, labelWorkflows, and bootstrap's loadWorkflows-adjacent behavior pass unchanged (byte-identical collision error messages -- diff the exact strings, do not just check err != nil). task check (now including lint) passes fully.","status":"open","priority":2,"issue_type":"task","owner":"sam@catlow.tech","created_at":"2026-09-02T18:10:21Z","created_by":"Sam Catlow","updated_at":"2026-09-02T18:10:21Z","dependencies":[{"issue_id":"archie-core-t2db.16","depends_on_id":"archie-core-t2db","type":"parent-child","created_at":"2026-09-02T18:10:21Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-t2db.15","title":"eda: playbook document + event coordinator, single-action workflow-kind dispatch","description":"Seventh slice of docs/prds/eda-playbook-engine.md. Builds the rich playbook document shape (trigger + ordered actions with CEL 'when') and an event coordinator that dispatches it -- the first real consumer of t2db.14's expr package. Scoped tightly to what's already safe per this doc's own gating:\n\n- Exactly ONE action per playbook in this slice, and it MUST be position: workflow. Reject (load failure) a playbook declaring more than one action, or an action whose position is module/channel/forge -- those remain blocked on the unresolved execution-time gaps (mid-run failure semantics, idempotency for non-workflow actions) per the 'Execution-time gaps' section. Do not relax this without Sam's sign-off -- this is the one hard boundary in this ticket, everything else is normal implementation judgment.\n- This is an ADDITIONAL loading path alongside the existing flat kind/label binding files (t2db.9/.10/.11). Do NOT modify workflow.Route(), workflow.workflowForLabels, or remove/change the existing single-file/multi-dir binding loaders. Migrating Route() onto the new mechanism is a separate, later, larger decision -- not in scope here.\n- Idempotency is free for this slice for the same reason it was free for t2db.13's first Module slice: a single workflow-kind action reaches the exact same workflow.Registry dispatch path that already carries TaskEnvelope's idempotency key. Nothing new to design here.","design":"Depends on archie-core-t2db.14 (expr package) -- do not start until it is closed and verified.\n\n1. Playbook document type (new package, likely internal/domain/eda/playbook -- confirm against organisation.md's layout rule, follow the log/logextract split precedent from t2db.13 if a generated component turns out to be needed, though this ticket is pure YAML+CEL, no Yaegi, so likely no extract package is needed here):\n - trigger: reuse existing workintake label/kind matching (do not invent a second label-matching mechanism -- workintake.SplitLabels/KindsForLabels already exist and are the one place this vocabulary lives).\n - actions: a list, validated at load to contain exactly one entry with position: workflow and a workflow registry name.\n - when: optional CEL expression string on the action, compiled via t2db.14's Compile() at load time -- a compile failure is a reported load failure (same collision-handling philosophy as t2db.9-.12), not a silently-skipped playbook.\n2. Event coordinator: loads playbook files from a configured directory (mirror the PlaybookDirs pattern from t2db.11 -- reuse its directory-scanning shape, do not reinvent), compiles every playbook's when expression at load (fail the whole load on any compile error, consistent with the existing reject-at-load rule), and at dispatch time: match trigger against an incoming task's labels/kind, evaluate when (if present) against a context of {event: \u003ctask's label/kind fields, whatever is cheaply available -- do not over-engineer the event shape beyond what a workflow-kind dispatch actually needs\u003e, actions: {} (empty -- no prior actions exist in a single-action playbook)}, and if the condition is true (or absent), dispatch to the named workflow via the existing workflow.Registry -- call the same registry lookup Route() already uses, do not duplicate dispatch logic.\n3. Config: a directory field for these playbook documents (distinct from t2db.11's PlaybookDirs, which holds flat binding files -- naming these two similar-but-different directories clearly is important; suggest something like EDAPlaybookDir or clarify in the field doc comment exactly how it differs from PlaybookDirs so a future reader isn't confused). If you judge the distinction is confusing enough that these should share one directory with two file shapes distinguished by content, flag that as a note in the PRD rather than silently deciding it -- but implement SOMETHING reasonable rather than blocking.\n4. Bootstrap wiring: load-and-abort on failure, matching every other slice's established pattern.\n5. Do NOT wire this into production task intake (daemon.go/pollNATS/publishTask) in this ticket -- prove the coordinator end-to-end with tests that construct a task-like input directly, the same way t2db.13 proved ModuleRegistry with direct Register/Invoke calls rather than full daemon wiring. Production wiring (making a real forge-triggered task actually flow through this coordinator instead of only workflow.Route()) is explicitly a follow-up ticket -- note it as such when you close this one.","acceptance_criteria":"A playbook YAML with trigger + one workflow-kind action + optional when loads successfully and dispatches to the correct registered workflow when trigger+when match. A playbook declaring 2+ actions is a reported load failure. A playbook with a non-workflow action position is a reported load failure. A whLine truncated
|
||||
{"_type":"issue","id":"archie-core-t2db.14","title":"eda: CEL expression environment (compile/validate at load, evaluate at dispatch)","description":"Sixth slice of docs/prds/eda-playbook-engine.md, implementing the 'Implementation placement' section of the resolved open question 1 (CEL). Builds internal/domain/eda/expr in isolation, no coordinator/dispatch yet -- mirrors how t2db.13 built ModuleRegistry as a standalone, fully-tested unit before anything consumed it.\n\nThis is pure infrastructure for the dispatch slice (t2db.15) that depends on it. No production wiring in this ticket.","design":"Package internal/domain/eda/expr (domain layer: no infrastructure imports).\n\nPer the resolved doc section, build:\n1. Environment construction: a CEL env declaring the two context roots -- 'event' as map(string, dyn), 'actions' as map(string, dyn). Cost limit (J5): pick a constant (start at 100,000, name it clearly as a tunable, e.g. DefaultCostLimit) -- exact value is a judgment call already flagged as tunable, don't block on picking the 'right' number.\n2. Compile/validate at load: a function taking a CEL expression string and returning (compiled program, error) -- a syntax error, a reference to an unknown root (anything other than event/actions), or exceeding the cost limit is a returned error, never a panic. This is what both the playbook loader (t2db.15) and the lint tool (t2db.12, follow-up integration is a SEPARATE ticket, do not touch cmd/archie-playbooks in this one) will eventually call.\n3. Evaluate at dispatch: a function taking a compiled program and a context (event map[string]any, actions map[string]map[string]any) and returning (value, error) -- CEL evaluation errors (missing field, wrong type against a dyn value) are returned as errors, never panics. Use CEL's own panic-free evaluation; do not add a recover() wrapper unless a test proves CEL itself can panic (verify this, don't assume).\n4. actions.\u003cid\u003e.result field-level typing (J1/context-conformance in the doc): NOT required in this ticket -- that needs the generated Module Result structs wired in as CEL type declarations, which only matters once a playbook can reference a prior action's result (t2db.15 is single-action, so there IS no prior action). Keep actions declared as dyn for now; note in a comment that per-kind typed declarations are follow-up work once multi-action playbooks exist.\n5. Dependency: add cel.dev/cel-go v0.32.0 (pinned) to go.mod -- this is the only new dependency, already vetted (see the resolved doc section's vetting record). Do not re-vet it.\n\nFollow docs/prds/eda-playbook-engine.md's reject-at-load philosophy throughout: anything not accepted by the schema is a reported error, never a silent default.","acceptance_criteria":"internal/domain/eda/expr exists with: environment construction, Compile(expr string) (returned type, error), Eval(program, ctx) (value, error). Table-driven tests cover: a valid boolean expression against event fields evaluates correctly; a syntax error is a Compile-time error; a reference to an unknown root (e.g. 'foo.bar') is a Compile-time error; evaluating against a missing event field does not panic (returns an error or CEL's documented behavior, whichever is correct -- verify against real CEL semantics, don't guess); an expression that would exceed the cost limit is rejected, not silently truncated. go.mod gains cel.dev/cel-go v0.32.0 only. task check passes.","status":"closed","priority":2,"issue_type":"task","owner":"sam@catlow.tech","created_at":"2026-09-02T17:57:19Z","created_by":"Sam Catlow","updated_at":"2026-09-02T18:01:29Z","closed_at":"2026-09-02T18:01:29Z","close_reason":"Implemented and gate-verified as 33cdece (pushed to main). internal/domain/eda/expr: NewEnv (event+actions roots, DefaultCostLimit 100k), Compile (reject-at-load: syntax/unknown-root/type errors returned), Eval (panic-free, errors returned, ref.Val unwrapped to native). cel.dev/cel-go v0.32.0 direct dep, vetted per resolved doc (no re-vet). 9 tests pass, all verified against real CEL semantics (cost limits accrue on macros; == on missing key is false; unknown root rejected at compile). task check clean (113/113 UI).","dependencies":[{"issue_id":"archie-core-t2db.14","depends_on_id":"archie-core-t2db","type":"parent-child","created_at":"2026-09-02T17:57:19Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":0,"dependent_count":1,"comment_count":0}
|
||||
|
||||
Reference in new issue
Block a user