fix(ui): drop history narration and em dashes from chat and dashboard comments
This commit is contained in:
1 parent
0cec2ec16d
commit
c0bd7bb6a3
13 files changed
+26
-31
No files matched your search
+1
-1
@@ -60,7 +60,7 @@ watch(() => accounts.status?.user, (user) => {
|
||||
change is an entry state, so the page keeps the operator's filters,
|
||||
while two different :id values get fresh instances -- without that
|
||||
the second id diffs the first one in place and the previous task's
|
||||
open tab stays open on the next (W11).
|
||||
open tab stays open on the next.
|
||||
-->
|
||||
<RouterView v-slot="{ Component, route }">
|
||||
<SettingsShell v-if="route.meta.settings" scope="instance">
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
<script setup lang="ts">
|
||||
/**
|
||||
* Inline JSON content with syntax highlighting, or the text verbatim when it
|
||||
* is not JSON. Every source character survives either way — highlighting adds
|
||||
* is not JSON. Every source character survives either way: highlighting adds
|
||||
* colour spans, never removes or rewrites text. Callers own the surrounding
|
||||
* <pre> and its classes (borders, max height, wrap behaviour differ per
|
||||
* surface); this renders only the content.
|
||||
|
||||
@@ -7,8 +7,8 @@ import type { ChatMedia } from "./state";
|
||||
/**
|
||||
* One attachment a message carried, as the transcript shows it.
|
||||
*
|
||||
* The bytes are gone by design — they are turn-scoped and are stripped before
|
||||
* the record is stored — so this is a labelled chip rather than a preview. It
|
||||
* The bytes are gone by design: they are turn-scoped and stripped before the
|
||||
* record is stored, so this is a labelled chip rather than a preview. It
|
||||
* links out only when the attachment itself carried a URL; a platform file id
|
||||
* is deliberately never rendered, because it is a handle rather than an
|
||||
* address and a chip that 404s is worse than no chip.
|
||||
|
||||
@@ -27,10 +27,9 @@ import {
|
||||
* panel says before either exists.
|
||||
*
|
||||
* The scroller follows the tail, and stops following the moment the reader
|
||||
* scrolls up rather than yanking them back on every streamed token. That is
|
||||
* what MessageScroller is for, so it is used rather than re-derived: an
|
||||
* earlier version set scrollTop from a watcher, which has neither the
|
||||
* "reader scrolled away" state nor a way back down.
|
||||
* scrolls up rather than yanking them back on every streamed token. A watcher
|
||||
* that set scrollTop by hand would have no "reader scrolled away" state and no
|
||||
* way back down, so MessageScroller owns this.
|
||||
*/
|
||||
const emit = defineEmits<{ prompt: [text: string] }>();
|
||||
|
||||
|
||||
@@ -5,7 +5,7 @@ import type { ChatMedia } from "./state";
|
||||
*
|
||||
* The bytes are turn-scoped and never reach a browser, so the label stands in
|
||||
* for the file. It reuses the placeholder vocabulary the channels already
|
||||
* write into a message's text (`[photo]`, `[document: report.pdf]` — see the
|
||||
* write into a message's text (`[photo]`, `[document: report.pdf]`, see the
|
||||
* notes in `internal/channels/telegram/inboundmedia.go`), so the same
|
||||
* attachment reads the same whether its metadata survived persistence or only
|
||||
* the note in its text did.
|
||||
@@ -32,7 +32,7 @@ export function mediaLabel(attachment: ChatMedia): string {
|
||||
* size, dimensions and duration, in the order a reader asks about them.
|
||||
*
|
||||
* It reports only what the record actually carried, so an unknown size reads
|
||||
* as absent rather than as zero, and it never names the platform file id — a
|
||||
* as absent rather than as zero, and it never names the platform file id: a
|
||||
* handle is not information about the file.
|
||||
*/
|
||||
export function mediaDetail(attachment: ChatMedia): string {
|
||||
|
||||
@@ -1,8 +1,8 @@
|
||||
// Keeping the arrow-key selection visible in the command palette.
|
||||
//
|
||||
// The palette caps its height and scrolls, so once the matches run past the
|
||||
// visible rows the selection walked off-screen and the highlight was invisible
|
||||
// (archie-core-ifay). Browsers have scrollIntoView, but the decision is pure
|
||||
// visible rows the selection must scroll with the highlight. Browsers have
|
||||
// scrollIntoView, but the decision is pure
|
||||
// arithmetic and worth testing on its own, so the effect only applies what
|
||||
// this returns.
|
||||
|
||||
|
||||
@@ -242,9 +242,8 @@ export async function refreshSessions(): Promise<void> {
|
||||
);
|
||||
|
||||
if (!currentSession.value && sessionList[0]) {
|
||||
// Vue's reactivity makes the assignment above readable here immediately, so
|
||||
// the read that selects the first conversation needs no data threaded into
|
||||
// it the way the Preact tree had to pass its own copy.
|
||||
// The assignment above is readable here immediately, so the first
|
||||
// conversation is selected from the shared state with no data passed in.
|
||||
await selectSession(sessionList[0].session_id);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -23,7 +23,7 @@ const tasks = useTasksStore();
|
||||
const taskID = computed(() => tasks.taskIDFor(props.event));
|
||||
// The detail is cut to one line by activityDetail and clamped again in the
|
||||
// cell so a long unbroken token (a path, a URL, a hash) cannot widen the column
|
||||
// past the table. Unclamped, this made the dashboard 7,481px tall.
|
||||
// past the table.
|
||||
const detail = computed(() => activityDetail(props.event, identities.identityName));
|
||||
|
||||
function open() {
|
||||
|
||||
@@ -119,11 +119,10 @@ function openTask(taskID: number) {
|
||||
<div role="region" aria-label="Activity" aria-live="polite">
|
||||
<!--
|
||||
The feed's height is bounded to the card, not the page: group rows
|
||||
multiply with the number of interleaved tasks, and an unbounded
|
||||
table made the dashboard ~4,700px tall on a live instance. The
|
||||
newest events stay visible at the top; the rest scroll inside the
|
||||
card. The header stays put via sticky so the columns keep their
|
||||
labels while scrolling.
|
||||
multiply with the number of interleaved tasks, so an unbounded table
|
||||
would push the rest of the dashboard off screen. The newest events
|
||||
stay visible at the top; the rest scroll inside the card. The header
|
||||
stays put via sticky so the columns keep their labels while scrolling.
|
||||
-->
|
||||
<div class="max-h-[28rem] overflow-y-auto">
|
||||
<Table>
|
||||
|
||||
@@ -18,9 +18,8 @@ const { setup } = storeToRefs(useTasksStore());
|
||||
/**
|
||||
* The setup checklist, rendered only while there is setup work left.
|
||||
*
|
||||
* A fully configured daemon renders nothing: the old completion card ("Setup
|
||||
* complete", with a check and a dismiss button) celebrated the absence of a
|
||||
* problem and occupied a grid cell until dismissed. Setup regressing to
|
||||
* A fully configured daemon renders nothing: a completion card would celebrate
|
||||
* the absence of a problem and hold a grid cell. Setup regressing to
|
||||
* incomplete brings the checklist back on its own.
|
||||
*/
|
||||
const panel = ref<SetupPanelState>(setupPanelState(setup.value));
|
||||
|
||||
@@ -2,8 +2,7 @@
|
||||
//
|
||||
// The daemon puts whatever a stage produced into an event's detail, so the
|
||||
// column holds anything from "session-memory" to a few thousand characters of
|
||||
// agent transcript. Printed raw, one agent_finish row was taller than six
|
||||
// viewports and the table stopped being scannable (archie-core-qo7f).
|
||||
// agent transcript. Printed raw, one row would dwarf the table.
|
||||
//
|
||||
// The rule is one line in the cell, the whole payload still available. The cut
|
||||
// happens here rather than in CSS because the row also needs to know whether
|
||||
|
||||
@@ -5,15 +5,15 @@ import { activityDetail } from "./activity-detail.ts";
|
||||
* The live activity feed's grouping projection.
|
||||
*
|
||||
* The daemon emits high-frequency background telemetry that arrives as dozens
|
||||
* of same-shape rows an hour — often as an interleave of kinds (a curator
|
||||
* of same-shape rows an hour, often as an interleave of kinds (a curator
|
||||
* cycle emits curator_run, session-memory and curator_action events that all
|
||||
* carry the same payload). Printed raw, the table stops being scannable and
|
||||
* real milestones drown.
|
||||
*
|
||||
* The rule: a *run of consecutive* events sharing one task and one rendered
|
||||
* detail collapses into a single group row. Kind is deliberately not part of
|
||||
* the key — an interleave of kinds over one payload is one cycle of noise,
|
||||
* not three events — so anything else stays on its own line, and a milestone
|
||||
* the key: an interleave of kinds over one payload is one cycle of noise,
|
||||
* not three events, so anything else stays on its own line, and a milestone
|
||||
* is never merged with an event carrying different information. The grouping
|
||||
* is consecutive, not global, so interleaved events keep their order and
|
||||
* nothing is reordered under the operator.
|
||||
|
||||
@@ -14,13 +14,13 @@ export interface Setup {
|
||||
}
|
||||
|
||||
export interface SetupPanelState {
|
||||
/** omit: nothing to show — no setup data, or setup fully done. */
|
||||
/** omit: nothing to show, either no setup data or setup fully done. */
|
||||
kind: "omit" | "incomplete";
|
||||
remaining: SetupStep[];
|
||||
}
|
||||
|
||||
// setupPanelState distinguishes the only two states worth rendering: there is
|
||||
// setup work left (the checklist), or there is not (nothing — a configured
|
||||
// setup work left (the checklist), or there is not (nothing: a configured
|
||||
// daemon is the absence of a problem, not a card announcing it).
|
||||
export function setupPanelState(
|
||||
setup: Setup | null | undefined,
|
||||
|
||||
Reference in new issue
Block a user