chore(beads): close skill curator reference implementation
This commit is contained in:
1 parent
c85bcff57d
commit
969aa761c3
2 files changed
+2
-1
No files matched your search
@@ -162,3 +162,4 @@
|
||||
{"id":"int-432ac25baf4f85d1a9f04ff494d0bc62","kind":"field_change","created_at":"2026-09-01T16:47:57.576063469Z","actor":"Sam Catlow","issue_id":"archie-core-1786637499636-376-2f94082e","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Complete, all three AC clauses:\n\n- A curator declares its memory engine via Manifest.MemoryEngine and\n receives it as a typed dependency: curator.Registrar.MemoryEngines\n (Get(name) (domainmemory.MemoryEngine, bool)), same trust model as\n ToolBuilder.Build(ctx, declared) -- the curator calls Get with its own\n declared name, not handed a pre-resolved instance. Registration\n enforces presence exactly like Tools/Skills: declared with no\n MemoryEngineSource on the host is rejected at Register\n (TestRegistryDeclaredCapabilitiesRequireHostServices' two new cases),\n and filter() clears the field from a curator's view when undeclared\n (TestRegistryBindFiltersToDeclaredCapabilities).\n- Swapping the configured engine changes where memories land with no\n curator code change: nothing about a curator names a concrete engine,\n only the string it declared, resolved fresh through whichever registry\n it was bound to.\n- A curator with no declared engine stays valid (pre-existing behavior,\n now covered by table cases) and can only ever be affected by a memory\n operation it structurally cannot attempt, since MemoryEngines is nil\n in its view.\n\nWired end to end: internal/app/archied/bootstrap.go:setupCurators passes\nb.memEngines (*domainmemory.Registry, set by setupMemoryAll which Run()\ncalls before setupCurators) straight in -- it already satisfies\nMemoryEngineSource with no adapter.\n\ngo test ./... is green; task lint is 0 issues."}}
|
||||
{"id":"int-8e36a6b86a595feaebaa50956eb01382","kind":"field_change","created_at":"2026-09-01T16:51:00.094507904Z","actor":"Sam Catlow","issue_id":"archie-core-1786637499161-356-e424e40d.1","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Fixed, but not as originally framed. Investigated wiring RegisterExternal\nfor real: there is no external MemoryProvider implementation anywhere in\nthe repo to construct and pass to it (only internal/memory/builtin.Provider\nexists) -- calling RegisterExternal would be dead plumbing to nothing, not\na fix.\n\nThe actual fix: configuration.validateMemory now rejects memory.provider\nbeing set at all, with a clear reason, instead of accepting it and doing\nnothing. Turns the silent no-op into a loud one. setupMemory's doc comment\nand config.example.toml updated to match; the now-pointless\nprovider_config example section removed.\n\ntoml struct tags (the other half of this bug) were already fixed in\narchie-core-1786637490043's commit.\n\nDrop the rejection once a real external provider (or the domain/memory\nengine family's Honcho proof, archie-core-1786637492031) gives the field\nan effect again.\n\nTestValidateMemoryRejectsProviderSetToAnything covers it. task check is\ngreen."}}
|
||||
{"id":"int-9633d649a25f789b25865683d74755f7","kind":"field_change","created_at":"2026-09-01T16:51:58.124722776Z","actor":"Sam Catlow","issue_id":"archie-core-1786637492031-86-0fcaccc0","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Deprioritized by Sam (2026-09-02): not a current priority. Re-open when there's actual appetite to build against a live Honcho instance -- the engine contract it would implement against (domain/memory.MemoryEngine) is done and stable, so this is unblocked whenever picked back up, not superseded by anything."}}
|
||||
{"id":"int-c7c4a97f5d0d3b21df35da16c9f6ac8e","kind":"field_change","created_at":"2026-09-01T16:58:46.750078973Z","actor":"Sam Catlow","issue_id":"archie-core-1786637499206-358-54f29252","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Complete, all three AC clauses. Design decided first in\ndocs/prds/skill-curator.md (no settled design existed for what \"review,\nprune, improve\" means as concrete behavior): v1 is mechanical validation\nplus safe whitespace normalization only -- no LLM-authored rewrites, no\ndeletion. See the doc for the full \"why this scope, not more\" reasoning.\n\n- Registers and runs through curator.Registry with no curator-specific\n special-casing: uses the existing Register/Runtime path unchanged\n (TestRegistersAndRunsThroughTheRegistry).\n- Its changes are observable and attributable: every write is preceded\n by an Action naming what changed and why (skill.normalized), surfaced\n through the existing curator activity tracker\n (archie-core-1786637489932, already shipped) -- no new observability\n surface needed.\n- Operates within its declared tool set: Manifest.Tools is empty, and\n nothing in the implementation ever touches Registrar.Tools\n (TestManifestDeclaresOnlySkills).\n\ninternal/infrastructure/skillcurator/{store,skillcurator}.go implement\ncurator.SkillStore and curator.CuratorEngine. The store deliberately does\nnot delegate to internal/skill.Discover, which aborts its whole call on\nany one skill's parse failure -- wrong for \"review each skill\nindependently\" (TestPassReviewsEverySkillIndependently covers the\nregression this would otherwise cause). Wired into\ninternal/app/archied/bootstrap.go:setupCurators, rooted the same way\nloadWorkflows resolves skillsBase.\n\ntask check is green (full Go suite + dashboard tests)."}}
|
||||
+1
-1
@@ -250,7 +250,7 @@
|
||||
{"_type":"issue","id":"archie-core-1786637499268-361-285a7a81","title":"feat(webui): logs section - filterable, live-tailing","description":"There is no way to see archied's logs outside journalctl. Every event already flows through events.Bus into the store and out over SSE, so this is mostly presentation over existing data. Filterable by level and component, live-tailing the SSE stream, with history from the store for anything before the dashboard connected.","status":"closed","priority":2,"issue_type":"task","created_at":"2026-08-08T14:55:09Z","updated_at":"2026-08-08T15:33:52Z","closed_at":"2026-08-08T15:33:53Z","external_ref":"https://github.com/samcharles93/archie-core/issues/382","source_system":"github:https://github.com/samcharles93/archie-core/issues/382:382","metadata":null,"labels":["task"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637499248-360-a6ac2616","title":"Regression tests: NATS RPC — request timeout, reply routing, error propagation","description":"internal/natsrpc/natsrpc.go has only 1 test (envelope round trip). Missing: request timeout handling, reply-to routing correctness, error propagation through the envelope, concurrent request isolation, reconnection behavior.","status":"closed","priority":2,"issue_type":"task","created_at":"2026-08-08T14:55:03Z","updated_at":"2026-08-08T14:55:06Z","closed_at":"2026-08-08T14:55:07Z","external_ref":"https://github.com/samcharles93/archie-core/issues/381","source_system":"github:https://github.com/samcharles93/archie-core/issues/381:381","metadata":null,"labels":["task"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637499227-359-c3682a55","title":"Audit the remaining golangci-lint autofix changes in 6d4e0be","description":"Commit 6d4e0be applied a golangci-lint --fix batch across 8 files. One of the eight was a behaviour regression: the errorlint fix in internal/tools/builtin/grep.go rewrote 'if exitErr, ok := err.(*exec.ExitError); ok \u0026\u0026 exitErr.ExitCode() == 1' into 'errors.As(err, \u0026exitErr)' and dropped the exit-code check, so any ripgrep failure (bad pattern, unreadable path) was reported to the model as 'no matches found' -- the agent would state a file contains nothing on the strength of a search that never ran. Fixed in 782510d. The other seven changes were eyeballed as benign (naked return expanded, err != ctx.Err() -\u003e errors.Is) but were never verified individually. A one-in-eight regression rate does not justify trusting the remainder on inspection alone.\n\n### Acceptance Criteria\n\nEach remaining changed hunk in 6d4e0be is reviewed against its pre-fix behaviour, specifically for predicates that were narrowed or widened. internal/channels/telegram/model.go, internal/infrastructure/configuration/discovery.go, internal/tools/builtin/find.go, internal/tools/builtin/shell.go and the touched test files are covered. Any behaviour change found gets a regression test in the style of TestGrepReportsSearchFailureRatherThanNoMatches.","status":"closed","priority":2,"issue_type":"bug","created_at":"2026-08-08T14:54:58Z","updated_at":"2026-08-08T15:34:09Z","closed_at":"2026-08-08T15:34:10Z","external_ref":"https://github.com/samcharles93/archie-core/issues/380","source_system":"github:https://github.com/samcharles93/archie-core/issues/380:380","metadata":null,"labels":["bug"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637499206-358-54f29252","title":"Skill curator (reference implementation)","description":"Ship a curator that maintains Archie's skills: reviewing, pruning, and improving skill definitions over time. One of the two consumers that validate the curator contract is general enough.\n\n### Acceptance Criteria\n\nRegisters and runs through the curator registry with no curator-specific special-casing in the runtime. Its changes to skills are observable and attributable to the curator. It operates within its declared tool set and cannot reach tools it did not declare.","status":"open","priority":2,"issue_type":"feature","created_at":"2026-08-08T14:54:55Z","updated_at":"2026-08-08T14:54:55Z","external_ref":"https://github.com/samcharles93/archie-core/issues/379","source_system":"github:https://github.com/samcharles93/archie-core/issues/379:379","metadata":null,"labels":["enhancement"],"dependencies":[{"issue_id":"archie-core-1786637499206-358-54f29252","depends_on_id":"archie-core-1786637500725-414-9d66a52b","type":"parent-child","created_at":"2026-09-01T15:50:28Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637499206-358-54f29252","title":"Skill curator (reference implementation)","description":"Ship a curator that maintains Archie's skills: reviewing, pruning, and improving skill definitions over time. One of the two consumers that validate the curator contract is general enough.\n\n### Acceptance Criteria\n\nRegisters and runs through the curator registry with no curator-specific special-casing in the runtime. Its changes to skills are observable and attributable to the curator. It operates within its declared tool set and cannot reach tools it did not declare.","status":"closed","priority":2,"issue_type":"feature","created_at":"2026-08-08T14:54:55Z","updated_at":"2026-09-01T16:58:47Z","closed_at":"2026-09-01T16:58:47Z","close_reason":"Complete, all three AC clauses. Design decided first in\ndocs/prds/skill-curator.md (no settled design existed for what \"review,\nprune, improve\" means as concrete behavior): v1 is mechanical validation\nplus safe whitespace normalization only -- no LLM-authored rewrites, no\ndeletion. See the doc for the full \"why this scope, not more\" reasoning.\n\n- Registers and runs through curator.Registry with no curator-specific\n special-casing: uses the existing Register/Runtime path unchanged\n (TestRegistersAndRunsThroughTheRegistry).\n- Its changes are observable and attributable: every write is preceded\n by an Action naming what changed and why (skill.normalized), surfaced\n through the existing curator activity tracker\n (archie-core-1786637489932, already shipped) -- no new observability\n surface needed.\n- Operates within its declared tool set: Manifest.Tools is empty, and\n nothing in the implementation ever touches Registrar.Tools\n (TestManifestDeclaresOnlySkills).\n\ninternal/infrastructure/skillcurator/{store,skillcurator}.go implement\ncurator.SkillStore and curator.CuratorEngine. The store deliberately does\nnot delegate to internal/skill.Discover, which aborts its whole call on\nany one skill's parse failure -- wrong for \"review each skill\nindependently\" (TestPassReviewsEverySkillIndependently covers the\nregression this would otherwise cause). Wired into\ninternal/app/archied/bootstrap.go:setupCurators, rooted the same way\nloadWorkflows resolves skillsBase.\n\ntask check is green (full Go suite + dashboard tests).","external_ref":"https://github.com/samcharles93/archie-core/issues/379","source_system":"github:https://github.com/samcharles93/archie-core/issues/379:379","metadata":null,"labels":["enhancement"],"dependencies":[{"issue_id":"archie-core-1786637499206-358-54f29252","depends_on_id":"archie-core-1786637500725-414-9d66a52b","type":"parent-child","created_at":"2026-09-01T15:50:28Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637499183-357-e3f7603f","title":"fix(gateway): redelivery dedups the stored turn but still re-runs the model","description":"archie-core-963 made SaveMessage idempotent, but nothing upstream consults the result. cmd/archied/telegram_setup.go:158 respond() calls SaveMessage (now a no-op on redelivery) then unconditionally loads history, calls the model, and saves the reply -- which carries no SourceID, so it always gets a fresh random ID and always appends.\n\nCONFIRMED at store level on both backends: redelivering tg-1 leaves [ping, pong, pong], plus a second billed model turn with any tool side effects executed twice.\n\nThe bead's stated problem ('a re-delivered Telegram update appends a duplicate turn') is half fixed. SaveMessage returns no already-seen signal for the caller to act on.","status":"closed","priority":2,"issue_type":"bug","created_at":"2026-08-08T14:54:50Z","updated_at":"2026-08-08T14:54:52Z","closed_at":"2026-08-08T14:54:53Z","external_ref":"https://github.com/samcharles93/archie-core/issues/378","source_system":"github:https://github.com/samcharles93/archie-core/issues/378:378","metadata":null,"labels":["bug"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637499161-356-e424e40d","title":"[EPIC] Pluggable memory engine: typed family + external providers","description":"Make the memory subsystem a pluggable engine family so an external memory backend (Honcho, or a future alternative) can be bolted on without touching the agent loop, while the file-writing store ships as the default. internal/memory already has a Manager and lifecycle hooks (TurnStartHook, SessionEndHook, SessionSwitchHook); this epic promotes that into a conforming engine family per the strict plugin engine rule in ARCHITECTURE.md rather than inventing a parallel abstraction.\n\n### Design\n\nConstraint from the plugin engine rule: 'engine' requires a typed domain contract, an owning Registry or Manager, explicit lifecycle/health, and narrow typed registrars -- providers never receive *daemon.Daemon or untyped hook maps. The contract must express real memory operations (write observation, query, list, forget), not just Name/Version.\n\n### Acceptance Criteria\n\nMemory is a typed engine family with an owning registry/manager, start/health/stop lifecycle, and narrow typed host access, satisfying every invariant in ARCHITECTURE.md 'Plugin engine rule (strict)' and passing internal/plugin/architecture_test.go. The builtin file-writing store is the shipped default engine and remains the behaviour when nothing is configured. At least one external engine is implementable against the contract without changes to the agent loop or gateway. Engine selection and per-engine settings are configurable, validated, and documented. Failure of a non-default engine degrades to a reported error rather than taking down a turn.","status":"open","priority":2,"issue_type":"epic","created_at":"2026-08-08T14:54:47Z","updated_at":"2026-08-08T14:54:47Z","external_ref":"https://github.com/samcharles93/archie-core/issues/377","source_system":"github:https://github.com/samcharles93/archie-core/issues/377:377","metadata":null,"labels":["epic"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
{"_type":"issue","id":"archie-core-1786637499136-355-c766a8ee","title":"Quiet autonomous execution and correct forge linkage","description":"Reduce Archie forge noise and make issue/branch/PR lifecycle authoritative. Automatic plan/progress/retry/state-label comments must be disabled; human decisions must remain available through messaging and the Web UI; pushed task branches must be linked to their source issues through the forge API before PR creation.\n\n### Acceptance Criteria\n\nNo automatic plan/progress/retry/state-label comments are emitted; configured human decisions remain actionable through messaging or Web UI; the source issue has a forge branch link after push; PR creation does not rely on a comment or closing directive for linkage; focused tests cover both in-process and RPC forge paths.","status":"closed","priority":2,"issue_type":"feature","created_at":"2026-08-08T14:54:42Z","updated_at":"2026-08-08T14:54:44Z","closed_at":"2026-08-08T14:54:45Z","external_ref":"https://github.com/samcharles93/archie-core/issues/376","source_system":"github:https://github.com/samcharles93/archie-core/issues/376:376","metadata":null,"labels":["enhancement"],"dependency_count":0,"dependent_count":0,"comment_count":0}
|
||||
|
||||
Reference in new issue
Block a user