docs(skills): record two gate traps and the service-target default
task check's proto:check and ui:check verify committed artifacts rather than
the build, so both fail on correct but unstaged work and both read as a broken
generator. Cost this session twice.
A registered service client always resolves to a non-empty target, so
Services.Get(name).Target != "" proves nothing: a guard meaning "only dial when
configured" dials always, and a test that sets no target reaches for a real
process on the developer's machine.
Also corrects the config skill's input-path table, which still described the
dashboard runtime overlay deleted in 2311529d. The rest of that stale surface
is archie-core-b7dn.
This commit is contained in:
1 parent
8cd3071641
commit
7729cefc31
2 files changed
+22
-1
No files matched your search
@@ -126,6 +126,18 @@ golangci-lint run ./...
|
||||
`task check` is the definitive gate but omits race tests, `task vuln`, and
|
||||
`task docker-build`. Its docs step, `docs:check`, verifies committed generated
|
||||
data and never renders anything: there is still no documentation build.
|
||||
|
||||
Two of its steps check committed artifacts rather than the build, so both fail
|
||||
on work that is correct but unstaged, and both read as a broken generator:
|
||||
|
||||
- `proto:check` regenerates, then runs `git diff --exit-code -- internal/contracts`
|
||||
and rejects untracked files there. After any `.proto` edit,
|
||||
`git add internal/contracts proto` before the gate. The failure prints the
|
||||
regenerated diff, which looks like generation produced something unexpected.
|
||||
- `ui:check` compares `ui/dist` against a fresh build of `ui/src` and fails when
|
||||
they differ. `task check` never rebuilds the bundle: run `task ui` after any
|
||||
`ui/src` change and commit the result with that change.
|
||||
|
||||
Run only in an authorized writable worktree. For a read-only ordinary-source
|
||||
preview, use `golangci-lint fmt --diff`.
|
||||
|
||||
|
||||
@@ -50,7 +50,7 @@ rg -n 'FIELD_NAME|external_key|ENV_NAME' \
|
||||
| Input path | Current behavior | Status |
|
||||
| --- | --- | --- |
|
||||
| `archied -config PATH` | Defaults to `$XDG_CONFIG_HOME/archie/config.toml`, or `$HOME/.config/archie/config.toml`; `internal/app/archied/bootstrap.go` builds `configuration.New(log)` and calls `Loader.Resolve`. | production-wired |
|
||||
| `archied -config-overlay PATH` | Resolves a file or directory overlay through the same loader (`Loader.Overlay`/`ApplyOverlay`); the dashboard runtime overlay is layered from its own SQLite store. Omitted overlay fields retain base values. | production-wired |
|
||||
| `archied -config-overlay PATH` | Resolves a file or directory overlay through the same loader. Omitted overlay fields retain base values. This is the only overlay: the dashboard runtime overlay and its SQLite store were deleted when the control plane took over settings writes. | production-wired |
|
||||
| `configuration.Loader.Dir(base, overlay)` | Supports main YAML/TOML plus feature YAML and `conf.d`; no current entrypoint calls it. | test/library-only |
|
||||
| `config.Load(path)`, `config.LoadDir(...)` | Removed. The old `internal/config` package-level helpers no longer exist; decoding is `Loader`-based. | not applicable |
|
||||
| `config.example.toml` | Load-tested example, not a deployed configuration. | test/library-only |
|
||||
@@ -61,6 +61,15 @@ Both TOML and YAML decoding are non-strict at the field level. Add explicit
|
||||
compatibility and typo tests; never use "the file loaded" as evidence that a
|
||||
key took effect.
|
||||
|
||||
A registered service client always resolves to a non-empty target, so
|
||||
`Services.Get(name).Target != ""` proves nothing. `RegisterService` in
|
||||
`internal/config/servicespec.go` supplies the fallback (`127.0.0.1:9090` for
|
||||
the State Store, `127.0.0.1:8585` for the Gateway), which means a guard written
|
||||
as "only dial when configured" dials always, and a test that sets no target
|
||||
reaches for a real process on the developer's machine. Gate on an explicit
|
||||
flag or on the dial succeeding, and give a binary its own
|
||||
`-<service>-target` flag so tests can point it at a fake.
|
||||
|
||||
## Inventory CLI flags
|
||||
|
||||
### Public binaries
|
||||
|
||||
Reference in new issue
Block a user