refactor(storecontract): assert every store interface at its implementation (#1781)
Complete the var _ storecontract.X = (*T)(nil) sweep so each of the 31 contract interfaces is compiler-checked against at least one adapter: postgres.Store (19), postgres.EDA (11, consolidated into edastore.go), staterpc.Client (29). Removes the scattered single-line assertions from harness_secrets.go, edastore_eventtypes.go, sources.go, run_credentials.go. task check green.
This commit is contained in:
7 files changed
+30
-10
No files matched your search
@@ -31,11 +31,16 @@ import (
|
||||
// the tool_calls transcript the composition projection writes through.
|
||||
var (
|
||||
_ storecontract.CaptureStore = (*EDA)(nil)
|
||||
_ storecontract.CaptureRefusalStore = (*EDA)(nil)
|
||||
_ storecontract.MappingStore = (*EDA)(nil)
|
||||
_ storecontract.BindingStore = (*EDA)(nil)
|
||||
_ storecontract.BindingDispatcher = (*EDA)(nil)
|
||||
_ storecontract.MappingMatchRecorder = (*EDA)(nil)
|
||||
_ storecontract.EventTypeStore = (*EDA)(nil)
|
||||
_ storecontract.BindingStore = (*EDA)(nil)
|
||||
_ storecontract.SourceStore = (*EDA)(nil)
|
||||
_ storecontract.DispatchLedger = (*EDA)(nil)
|
||||
_ storecontract.BindingDispatcher = (*EDA)(nil)
|
||||
_ storecontract.PlaybookDispatcher = (*EDA)(nil)
|
||||
_ storecontract.HarnessSecretStore = (*EDA)(nil)
|
||||
)
|
||||
|
||||
// EDA is the PostgreSQL-backed EDA persistence.
|
||||
|
||||
@@ -14,8 +14,6 @@ import (
|
||||
"github.com/samcharles93/archie-core/internal/infrastructure/postgres/postgresdb"
|
||||
)
|
||||
|
||||
var _ storecontract.EventTypeStore = (*EDA)(nil)
|
||||
|
||||
func eventTypeValue(r postgresdb.EventType) (eventtype.EventType, error) {
|
||||
t := eventtype.EventType{
|
||||
ID: r.ID, Source: r.Source, Name: r.Name, WorkspaceID: org.WorkspaceID(r.WorkspaceID),
|
||||
|
||||
@@ -15,8 +15,6 @@ import (
|
||||
"github.com/samcharles93/archie-core/internal/infrastructure/postgres/postgresdb"
|
||||
)
|
||||
|
||||
var _ storecontract.HarnessSecretStore = (*EDA)(nil)
|
||||
|
||||
// harnessSecretPayload is the JSON shape sealed into harness_secrets.secret_enc:
|
||||
// the whole token set behind one envelope, never separate plaintext columns.
|
||||
type harnessSecretPayload struct {
|
||||
|
||||
@@ -11,8 +11,6 @@ import (
|
||||
"github.com/samcharles93/archie-core/internal/infrastructure/postgres/postgresdb"
|
||||
)
|
||||
|
||||
var _ storecontract.RunCredentialStore = (*Store)(nil)
|
||||
|
||||
func (s *Store) PutRunCredential(ctx context.Context, digest [32]byte, taskID int64, expires time.Time) error {
|
||||
return s.queries().InsertRunCredential(ctx, postgresdb.InsertRunCredentialParams{Digest: digest[:], TaskID: taskID, ExpiresAt: expires})
|
||||
}
|
||||
|
||||
@@ -13,8 +13,6 @@ import (
|
||||
"github.com/samcharles93/archie-core/internal/infrastructure/postgres/postgresdb"
|
||||
)
|
||||
|
||||
var _ storecontract.SourceStore = (*EDA)(nil)
|
||||
|
||||
// InsertSource stores a new source in one of the acting org's workspaces,
|
||||
// its default one when src names none; a workspace the org does not have is
|
||||
// ErrInvalidWorkspace. The path is the primary key, so a taken path is
|
||||
|
||||
@@ -134,9 +134,20 @@ func taskFromRow(t postgresdb.Task) *workflow.Task {
|
||||
// Compile-time checks: *Store satisfies every surface the SQLite store did.
|
||||
var (
|
||||
_ storecontract.TaskStore = (*Store)(nil)
|
||||
_ storecontract.TaskLifecycle = (*Store)(nil)
|
||||
_ storecontract.TaskParker = (*Store)(nil)
|
||||
_ storecontract.TaskQueries = (*Store)(nil)
|
||||
_ storecontract.TaskEvents = (*Store)(nil)
|
||||
_ storecontract.TaskArchiver = (*Store)(nil)
|
||||
_ storecontract.TaskRetryer = (*Store)(nil)
|
||||
_ storecontract.ReviewGateResponder = (*Store)(nil)
|
||||
_ storecontract.RemediationStarter = (*Store)(nil)
|
||||
_ storecontract.OutcomePoster = (*Store)(nil)
|
||||
_ storecontract.StepRecorder = (*Store)(nil)
|
||||
_ storecontract.StepReader = (*Store)(nil)
|
||||
_ storecontract.ExecutionCanceller = (*Store)(nil)
|
||||
_ storecontract.BindingTaskCreator = (*Store)(nil)
|
||||
_ storecontract.RunCredentialStore = (*Store)(nil)
|
||||
_ storecontract.ConfigSnapshotStore = (*Store)(nil)
|
||||
_ storecontract.ChannelStatusStore = (*Store)(nil)
|
||||
_ storecontract.ApplyStatusStore = (*Store)(nil)
|
||||
|
||||
@@ -111,6 +111,18 @@ var (
|
||||
_ storecontract.PresenceStore = (*Client)(nil)
|
||||
_ storecontract.CaptureRefusalStore = (*Client)(nil)
|
||||
_ storecontract.ExecutionCanceller = (*Client)(nil)
|
||||
_ storecontract.TaskLifecycle = (*Client)(nil)
|
||||
_ storecontract.TaskParker = (*Client)(nil)
|
||||
_ storecontract.TaskQueries = (*Client)(nil)
|
||||
_ storecontract.TaskEvents = (*Client)(nil)
|
||||
_ storecontract.TaskArchiver = (*Client)(nil)
|
||||
_ storecontract.TaskRetryer = (*Client)(nil)
|
||||
_ storecontract.ReviewGateResponder = (*Client)(nil)
|
||||
_ storecontract.RemediationStarter = (*Client)(nil)
|
||||
_ storecontract.OutcomePoster = (*Client)(nil)
|
||||
_ storecontract.StepReader = (*Client)(nil)
|
||||
_ storecontract.DispatchLedger = (*Client)(nil)
|
||||
_ storecontract.EventTypeStore = (*Client)(nil)
|
||||
_ identity.Repository = (*Client)(nil)
|
||||
_ storepkg.Installations = (*Client)(nil)
|
||||
_ identity.PersonalTokens = (*Client)(nil)
|
||||
|
||||
Reference in new issue
Block a user