refactor(binding): delete dead Matcher.Overlaps method

DELETE: no document in docs/architecture/ or docs/prds/ specifies a
consumer for binding.Matcher.Overlaps, and it has no caller or test
caller. The store enforces the overlap invariant with its own SQL
(internal/store/bindings.go InsertBinding/UpdateBinding), which is out
of this lane's ownership and left untouched. The doc comment's
empty-Source rule is already covered by Binding.validateCommon's
"matcher.source is required" check, so nothing needs moving.
This commit is contained in:
sam committed 2026-09-15 13:12:22 +10:00
1 parent 27f7053351
commit 41ad0d48ec
1 file changed
-12
-12
View File
@@ -138,18 +138,6 @@ func (m Matcher) Matches(source string, authenticated bool) bool {
return m.Source == source
}
// Overlaps reports whether two matchers cover any plausible event
// together. With a single-string matcher this collapses to: both have
// a non-empty Source equal to each other. Two empty matchers would
// overlap trivially; Validate rejects empty Sources upstream so this
// case cannot arise in practice.
func (m Matcher) Overlaps(other Matcher) bool {
if m.Source == "" || other.Source == "" {
return false
}
return m.Source == other.Source
}
// Normalize clamps an arbitrary string into a recognised Status, falling
// back to StatusDraft for any unknown value. The DB CHECK constraint
// already rejects bad strings at write time; Normalize is the API-edge