refactor(plugin): delete the unused Registry type
Registry carried no plugin identity, discovery, compatibility or lifecycle, so it was never the seed for the approved internal/domain/plugin package. Host, Manifest and Module are, and they stay. Regenerating pluginextract strips the interface-wrapper nil guards, so those are restored by hand; the only intended change to the generated table is dropping the Registry symbol.
This commit is contained in:
4 files changed
+1
-26
No files matched your search
@@ -26,19 +26,6 @@ type Plugin interface {
|
||||
Version() string
|
||||
}
|
||||
|
||||
// Registry holds loaded plugins and dispatches extension point calls.
|
||||
type Registry struct {
|
||||
plugins []Plugin
|
||||
}
|
||||
|
||||
// Register adds a plugin to the registry.
|
||||
func (r *Registry) Register(p Plugin) {
|
||||
r.plugins = append(r.plugins, p)
|
||||
}
|
||||
|
||||
// Plugins returns all registered plugins.
|
||||
func (r *Registry) Plugins() []Plugin { return r.plugins }
|
||||
|
||||
// LoadDir discovers and evaluates .go files in the given directory.
|
||||
// Each file must export a variable named "Plugin" that implements the
|
||||
// Plugin interface. Failed plugins are logged and skipped -- the daemon
|
||||
|
||||
@@ -10,7 +10,7 @@ import (
|
||||
"github.com/samcharles93/archie-core/internal/plugin/pluginextract"
|
||||
)
|
||||
|
||||
// ── Plugin interface and registry ────────────────────────────────────
|
||||
// ── Plugin interface ─────────────────────────────────────────────────
|
||||
|
||||
func TestPluginInterfaceExists(t *testing.T) {
|
||||
var p plugin.Plugin
|
||||
@@ -22,10 +22,6 @@ func TestPluginInterfaceExists(t *testing.T) {
|
||||
var _ nameVersioner = p
|
||||
}
|
||||
|
||||
func TestRegistryExists(t *testing.T) {
|
||||
_ = &plugin.Registry{}
|
||||
}
|
||||
|
||||
// ── LoadDir behavioral tests ─────────────────────────────────────────
|
||||
|
||||
var symbols = pluginextract.Symbols
|
||||
|
||||
@@ -25,7 +25,6 @@ func init() {
|
||||
"Module": reflect.ValueOf((*plugin.Module)(nil)),
|
||||
"Permission": reflect.ValueOf((*plugin.Permission)(nil)),
|
||||
"Plugin": reflect.ValueOf((*plugin.Plugin)(nil)),
|
||||
"Registry": reflect.ValueOf((*plugin.Registry)(nil)),
|
||||
|
||||
// interface wrapper definitions
|
||||
"_Module": reflect.ValueOf((*_github_com_samcharles93_archie_core_internal_plugin_Module)(nil)),
|
||||
|
||||
@@ -19,13 +19,6 @@ func TestSymbolsContainsExpectedPluginEntries(t *testing.T) {
|
||||
t.Errorf("LoadDir kind = %v, want Func", v.Kind())
|
||||
}
|
||||
|
||||
// Registry must be a pointer type.
|
||||
if v, ok := pkg["Registry"]; !ok {
|
||||
t.Error("Registry missing from Symbols")
|
||||
} else if v.Kind() != reflect.Pointer {
|
||||
t.Errorf("Registry kind = %v, want Ptr", v.Kind())
|
||||
}
|
||||
|
||||
// Plugin must be a pointer type.
|
||||
if v, ok := pkg["Plugin"]; !ok {
|
||||
t.Error("Plugin missing from Symbols")
|
||||
|
||||
Reference in new issue
Block a user