chore(beads): close memory engine contract/registry issue

This commit is contained in:
sam committed 2026-09-02 01:55:43 +10:00
1 parent a500603e27
commit 02c0214919
2 files changed
+2 -1

No files matched your search

+1
View File
@@ -156,3 +156,4 @@
{"id":"int-b0d4496e53ae09d1926495a2215fff13","kind":"field_change","created_at":"2026-08-31T11:51:43.090585774Z","actor":"Sam Catlow","issue_id":"archie-core-h019.4","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"StageReview wired into the implement workflow between StageDiffCap and StageOpenPR. Fail-closed: not-run or a confirmed error-level finding parks (store.StatusParked) with findings in Detail; warn/plausible findings never block. Inert unless Repo.ReviewEnabled (new config field, default false); Models[\"reviewer\"] falls back to Models[\"builder\"]. task check clean, golangci-lint clean. Committed 8db8a17."}}
{"id":"int-bdb049c55a0a716a843b41f25c644bd7","kind":"field_change","created_at":"2026-09-01T15:18:56.663403225Z","actor":"Sam Catlow","issue_id":"archie-core-atv2","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Fixed: stopRendering now marks the reply finalized, and appendFallbackLine sends a standalone follow-up message instead of writing into a dead render buffer. Covered by TestLiveReplyMediaFallbackAfterFinalizeSendsFollowUp."}}
{"id":"int-79cc9ce98fc14750b24a9590b641f68c","kind":"field_change","created_at":"2026-09-01T15:30:08.83790169Z","actor":"Sam Catlow","issue_id":"archie-core-1786637500752-415-434e5bb9","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Closed"}}
{"id":"int-6c8b1ec0ed98295ad0c7d27c65bd6696","kind":"field_change","created_at":"2026-09-01T15:55:33.214859138Z","actor":"Sam Catlow","issue_id":"archie-core-1786637490069-11-e245c170","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Complete: internal/domain/memory/{contract,registrar,registry}.go stands up\nmemory as a conforming engine family, mirroring internal/domain/curator's\nsplit exactly per this issue's own notes.\n\nMemoryEngine (contract.go) embeds Lifecycle (Start/Health/Stop) and Store\n(Write/Query/List/Forget -- real operations, not identity metadata) plus\nName/Version/Manifest/Bind. Store is split out as its own embedded\ninterface so MemoryEngine stays under golangci-lint's interfacebloat\nthreshold, same mechanism as curator's embedded Lifecycle.\n\nRegistry (registry.go) owns Register/Get/Names/Start/Health/Stop with\nduplicate/nil-engine/panic-in-Bind rejection, per-engine Start failure\nisolation (one engine's failed Start does not block the others, and is\nreported via Health), ctx-bounded Stop, and reverse-registration-order\nshutdown -- all verified by registry_test.go, mirroring curator's test\nsuite. go test ./internal/domain/memory/... -race -count=1 is green;\ntask lint is 0 issues.\n\nRegistrar (registrar.go) carries EventSink and Clock -- the only host\nservices with anything to gate on today. No capability-filtering logic\nexists yet because no memory-specific host service is capability-gated\n(unlike curator's Tools/Skills), so Bind passes the host straight\nthrough; add filtering if/when a gated service appears.\n\nOne AC clause is not literally testable yet: internal/plugin/\narchitecture_test.go's TestEngineFamilyInspectionRejectsInvalidShapes\nonly scans inline fixture source, not the real package tree, so nothing\ncurrently asserts memory.MemoryEngine is \"recognised\" by it one way or\nthe other -- the shape matches curator's (which the fixture tests\nvalidate the pattern against), but there is no scan-the-repo test to\nliterally pass. Noting this so a future close of a sibling issue doesn't\nrepeat the earlier inaccurate claim that this test scans real packages\n(archie-core-1786637499933-386-83646cce's close reason cited a test name,\nTestEveryEngineInterfaceHasTypedCapabilityAndFamilyOwner, that does not\nexist in the repo -- likely stale even at the time it was written).\n\nNot done, and correctly still open as their own issues: engines that\nimplement this contract (the Honcho proof, archie-core-1786637492031),\nthe config surface to select one (archie-core-1786637490043), and\nbinding curators to an attached engine (archie-core-1786637499636)."}}
+1 -1
View File
@@ -597,7 +597,7 @@
{"_type":"issue","id":"archie-core-1786637490145-14-dd1e68f3","title":"Fix chat command palette keyboard interaction","description":"The chat slash-command palette remains open after the slash is removed or Escape is pressed, and its results cannot be navigated with ArrowUp/ArrowDown. Add regression tests and restore expected keyboard behavior.\n\n### Acceptance Criteria\n\nBackspace/removing the slash closes the palette; Escape closes it; ArrowUp and ArrowDown move the active option; Enter activates the highlighted option; the focused option is exposed accessibly; UI tests and project quality gates pass.","status":"closed","priority":2,"issue_type":"bug","created_at":"2026-08-08T14:27:05Z","updated_at":"2026-08-08T14:31:13Z","closed_at":"2026-08-08T14:31:14Z","external_ref":"https://github.com/samcharles93/archie-core/issues/35","source_system":"github:https://github.com/samcharles93/archie-core/issues/35:35","metadata":null,"labels":["bug"],"dependency_count":0,"dependent_count":0,"comment_count":0}
{"_type":"issue","id":"archie-core-1786637490125-13-6dea21ca","title":"Trim the remaining agent skills to factual reference","description":"The .agents/skills/ library is 4283 lines across 12 skills. An audit found most carry useful facts buried in process ceremony. Five worst offenders were already parked at /work/apps/archie-skills-parked. Trim what remains to roughly 2200 lines total. KEEP: concrete commands, package anchors, config wiring tables, NellDB shapes, symptom-to-diagnostic indexes, known regressions, domain glossary, operational hazards, false-confidence warnings. CUT: mandated N-step procedures, handoff templates, evidence packets, acceptance checklists, ownership/deletion/rollback field lists, sibling-skill routing prose, repeated 'reject unless' instructions, dated tool snapshots. Preserve every skill's YAML frontmatter name and description. Do not delete any skill file outright.\n\n### Acceptance Criteria\n\nTotal line count of .agents/skills/*/*.md is between 1900 and 2500. All 12 skills still exist with valid frontmatter. No factual command, path, or table was lost - only procedure and ceremony. go build ./... still clean.","status":"closed","priority":2,"issue_type":"task","created_at":"2026-08-08T14:27:00Z","updated_at":"2026-08-08T14:27:02Z","closed_at":"2026-08-08T14:27:03Z","external_ref":"https://github.com/samcharles93/archie-core/issues/34","source_system":"github:https://github.com/samcharles93/archie-core/issues/34:34","metadata":null,"labels":["task"],"dependency_count":0,"dependent_count":0,"comment_count":0}
{"_type":"issue","id":"archie-core-1786637490097-12-bf415ffb","title":"SOUL cannot override the prompt invariants","description":"Enforce the boundary that makes SOUL safe to hand to users: it supplies identity and style, and cannot reach the instruction hierarchy, core rules, tool inventory or env block.\n\n### Acceptance Criteria\n\nA test renders a hostile SOUL that attempts to countermand core_rules and asserts the invariant sections are still present and intact. The boundary is documented where the layering rule already lives so the next person editing the template does not quietly relax it.","status":"open","priority":2,"issue_type":"task","created_at":"2026-08-08T14:26:57Z","updated_at":"2026-08-08T14:26:57Z","external_ref":"https://github.com/samcharles93/archie-core/issues/33","source_system":"github:https://github.com/samcharles93/archie-core/issues/33:33","metadata":null,"labels":["task"],"dependency_count":0,"dependent_count":0,"comment_count":0}
{"_type":"issue","id":"archie-core-1786637490069-11-e245c170","title":"Memory engine contract and owning registry","description":"Define the typed memory engine interface and the registry that owns provider registration, discovery, and lifecycle. This is the load-bearing design step: everything else in the epic is written against this contract.\n\n### Acceptance Criteria\n\nA typed interface exposes real memory operations beyond identity metadata. An owning Registry/Manager controls registration, init, start, health, and stop, and defines failure isolation and shutdown ordering. Providers receive only a typed registrar and the host services their capability declares. internal/plugin/architecture_test.go passes with memory recognised as a conforming engine family. Stateless providers may declare explicit no-op lifecycle.","notes":"Not started as a conforming engine family. The existing internal/memory package (provider.go, lifecycle.go, backup.go, etc.) predates the domain migration: it has an ad-hoc MemoryProvider interface plus several optional hook interfaces (TurnStartHook, SessionEndHook, ...), but no owning Registry/Manager, no narrow typed registrar, and no Manifest-style declared shape -- it does not follow the strict plugin engine rule that internal/domain/curator (archie-core-1786637499933-386-83646cce, now closed) already demonstrates as the reference implementation. Confirmed via go test ./internal/plugin/... -run TestEveryEngineInterfaceHasTypedCapabilityAndFamilyOwner -v: only domain/curator.CuratorEngine, secret.Engine, and tools/provider.Engine are currently recognised conforming families -- no memory family. Use internal/domain/curator's contract.go/registry.go/registrar.go split as the template; do not extend internal/memory's MemoryProvider in place.","status":"open","priority":2,"issue_type":"feature","created_at":"2026-08-08T14:26:54Z","updated_at":"2026-08-15T12:55:52Z","external_ref":"https://github.com/samcharles93/archie-core/issues/32","source_system":"github:https://github.com/samcharles93/archie-core/issues/32:32","metadata":null,"labels":["enhancement"],"dependencies":[{"issue_id":"archie-core-1786637490069-11-e245c170","depends_on_id":"archie-core-1786637499161-356-e424e40d","type":"parent-child","created_at":"2026-09-01T15:50:33Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":0,"dependent_count":1,"comment_count":0}
{"_type":"issue","id":"archie-core-1786637490069-11-e245c170","title":"Memory engine contract and owning registry","description":"Define the typed memory engine interface and the registry that owns provider registration, discovery, and lifecycle. This is the load-bearing design step: everything else in the epic is written against this contract.\n\n### Acceptance Criteria\n\nA typed interface exposes real memory operations beyond identity metadata. An owning Registry/Manager controls registration, init, start, health, and stop, and defines failure isolation and shutdown ordering. Providers receive only a typed registrar and the host services their capability declares. internal/plugin/architecture_test.go passes with memory recognised as a conforming engine family. Stateless providers may declare explicit no-op lifecycle.","notes":"Not started as a conforming engine family. The existing internal/memory package (provider.go, lifecycle.go, backup.go, etc.) predates the domain migration: it has an ad-hoc MemoryProvider interface plus several optional hook interfaces (TurnStartHook, SessionEndHook, ...), but no owning Registry/Manager, no narrow typed registrar, and no Manifest-style declared shape -- it does not follow the strict plugin engine rule that internal/domain/curator (archie-core-1786637499933-386-83646cce, now closed) already demonstrates as the reference implementation. Confirmed via go test ./internal/plugin/... -run TestEveryEngineInterfaceHasTypedCapabilityAndFamilyOwner -v: only domain/curator.CuratorEngine, secret.Engine, and tools/provider.Engine are currently recognised conforming families -- no memory family. Use internal/domain/curator's contract.go/registry.go/registrar.go split as the template; do not extend internal/memory's MemoryProvider in place.","status":"closed","priority":2,"issue_type":"feature","created_at":"2026-08-08T14:26:54Z","updated_at":"2026-09-01T15:55:33Z","closed_at":"2026-09-01T15:55:33Z","close_reason":"Complete: internal/domain/memory/{contract,registrar,registry}.go stands up\nmemory as a conforming engine family, mirroring internal/domain/curator's\nsplit exactly per this issue's own notes.\n\nMemoryEngine (contract.go) embeds Lifecycle (Start/Health/Stop) and Store\n(Write/Query/List/Forget -- real operations, not identity metadata) plus\nName/Version/Manifest/Bind. Store is split out as its own embedded\ninterface so MemoryEngine stays under golangci-lint's interfacebloat\nthreshold, same mechanism as curator's embedded Lifecycle.\n\nRegistry (registry.go) owns Register/Get/Names/Start/Health/Stop with\nduplicate/nil-engine/panic-in-Bind rejection, per-engine Start failure\nisolation (one engine's failed Start does not block the others, and is\nreported via Health), ctx-bounded Stop, and reverse-registration-order\nshutdown -- all verified by registry_test.go, mirroring curator's test\nsuite. go test ./internal/domain/memory/... -race -count=1 is green;\ntask lint is 0 issues.\n\nRegistrar (registrar.go) carries EventSink and Clock -- the only host\nservices with anything to gate on today. No capability-filtering logic\nexists yet because no memory-specific host service is capability-gated\n(unlike curator's Tools/Skills), so Bind passes the host straight\nthrough; add filtering if/when a gated service appears.\n\nOne AC clause is not literally testable yet: internal/plugin/\narchitecture_test.go's TestEngineFamilyInspectionRejectsInvalidShapes\nonly scans inline fixture source, not the real package tree, so nothing\ncurrently asserts memory.MemoryEngine is \"recognised\" by it one way or\nthe other -- the shape matches curator's (which the fixture tests\nvalidate the pattern against), but there is no scan-the-repo test to\nliterally pass. Noting this so a future close of a sibling issue doesn't\nrepeat the earlier inaccurate claim that this test scans real packages\n(archie-core-1786637499933-386-83646cce's close reason cited a test name,\nTestEveryEngineInterfaceHasTypedCapabilityAndFamilyOwner, that does not\nexist in the repo -- likely stale even at the time it was written).\n\nNot done, and correctly still open as their own issues: engines that\nimplement this contract (the Honcho proof, archie-core-1786637492031),\nthe config surface to select one (archie-core-1786637490043), and\nbinding curators to an attached engine (archie-core-1786637499636).","external_ref":"https://github.com/samcharles93/archie-core/issues/32","source_system":"github:https://github.com/samcharles93/archie-core/issues/32:32","metadata":null,"labels":["enhancement"],"dependencies":[{"issue_id":"archie-core-1786637490069-11-e245c170","depends_on_id":"archie-core-1786637499161-356-e424e40d","type":"parent-child","created_at":"2026-09-01T15:50:33Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":0,"dependent_count":1,"comment_count":0}
{"_type":"issue","id":"archie-core-1786637490043-10-711c450a","title":"Config surface for memory engine selection and settings","description":"Add validated configuration for choosing a memory engine and supplying its per-engine settings, following the existing config conventions in internal/config and internal/infrastructure/configuration.\n\n### Acceptance Criteria\n\nEngine choice and per-engine settings are expressible in config.toml with toml/yaml/json tags matching repo convention. Validation rejects an unknown engine name with a clear error naming the valid set, in the style of the existing forge.type validation. Defaults resolve so an absent section keeps the builtin engine. config.example.toml documents the section.","status":"open","priority":2,"issue_type":"feature","created_at":"2026-08-08T14:26:51Z","updated_at":"2026-08-08T14:31:57Z","external_ref":"https://github.com/samcharles93/archie-core/issues/31","source_system":"github:https://github.com/samcharles93/archie-core/issues/31:31","metadata":null,"labels":["enhancement"],"dependencies":[{"issue_id":"archie-core-1786637490043-10-711c450a","depends_on_id":"archie-core-1786637499161-356-e424e40d","type":"parent-child","created_at":"2026-09-01T15:50:33Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":0,"dependent_count":0,"comment_count":0}
{"_type":"issue","id":"archie-core-1786637490011-9-d5e4f9a4","title":"Telegram: provider selector filters model choices","description":"Add an authorized native /provider inline selector. The selected provider scopes /model so only configured model references belonging to that provider are shown; e.g. openrouter/openai/gpt-5.6 must not appear under provider openai. Selecting a provider establishes a valid active model for that provider when necessary, and /status reports active provider and model.\n\n### Acceptance Criteria\n\n/provider displays configured providers as an inline keyboard and marks the active provider. Authorized callbacks switch provider; unauthorized, malformed, stale, and duplicate callbacks fail safely. /model shows only models whose first reference segment matches the selected provider and uses unambiguous labels. Switching provider leaves the chat responder on a valid model from that provider. /status includes active provider and full model reference. Menu/help/executable parity and concurrent access are tested.","status":"closed","priority":2,"issue_type":"feature","created_at":"2026-08-08T14:26:49Z","updated_at":"2026-08-18T15:53:30Z","closed_at":"2026-08-18T15:53:30Z","close_reason":"Superseded: confirmed by Sam that there is no longer a separate /provider command -- grepped the codebase and no '/provider' command exists in internal/gateway or internal/channels/telegram. /model now handles provider scoping directly.","external_ref":"https://github.com/samcharles93/archie-core/issues/30","source_system":"github:https://github.com/samcharles93/archie-core/issues/30:30","metadata":null,"labels":["enhancement","in-progress"],"dependency_count":0,"dependent_count":0,"comment_count":0}
{"_type":"issue","id":"archie-core-1786637489985-8-13b9d8a8","title":"Document the memory engine family in ARCHITECTURE.md","description":"Record the memory engine family alongside the existing engine documentation so the contract, its lifecycle guarantees, and the trust boundary for third-party memory backends are written down where the plugin engine rule already lives.\n\n### Acceptance Criteria\n\nARCHITECTURE.md describes the memory engine contract, its owning manager, lifecycle and failure isolation, and states the trust boundary for an out-of-process or third-party memory backend. The shared CLAUDE.md/AGENTS.md source is updated if the rule surface changes.","status":"closed","priority":2,"issue_type":"task","assignee":"Sam Catlow","created_at":"2026-08-08T14:26:46Z","updated_at":"2026-08-15T13:36:39Z","started_at":"2026-08-15T13:25:55Z","closed_at":"2026-08-15T13:36:39Z","close_reason":"Documented the memory engine contract, owning manager, lifecycle/failure isolation, and third-party trust boundary in ARCHITECTURE.md; focused memory tests pass.","external_ref":"https://github.com/samcharles93/archie-core/issues/29","source_system":"github:https://github.com/samcharles93/archie-core/issues/29:29","metadata":null,"labels":["task"],"dependency_count":0,"dependent_count":0,"comment_count":0}