Applies the four-reviewer pass over the forge/dashboard-actions work. The through-line is that several capabilities were wired but inert, and one of them could cost real work. DUPLICATE WORK. "Closes #N" was dropped from PR bodies in favour of LinkBranch, which is sidebar linkage on Gitea and a no-op stub on GitHub -- neither closes anything, and nothing else did either. So a merged task left its issue open, labelled and assigned; the next poll re-enqueued it, and once the dashboard's Clear removed the task row that became a second implementation and a second PR for work already merged. reconcilePRs now closes the issue on merge, and a rejected task closes its issue too. A PR closed without merging deliberately leaves the issue open: that usually means "try again". MAX RETRIES. Configured, defaulted and reported by /api/config, and enforced nowhere -- markDead was unreachable and EffectiveMaxRetries had no callers, so the dashboard's retry incremented retry_count forever. The retry action now retires a task to dead at the cap. DEAD ON ARRIVAL. Tasks() never selected plan or source, so the "Decision required" panel could not render and chat tasks -- whose issue number is synthetic -- linked to forge issues that do not exist. COSMETIC FAILURE, FATAL RESULT. OpenPR failed the whole stage when LinkBranch errored, so the pull request was never opened and the task parked; a retry re-links the same branch, which Gitea answers with a conflict, so every retry parked again. It is best-effort now. INVISIBLE ACTIONS. Approve/retry/reject wrote store rows and nothing else, so the timeline and activity stream never showed that a human had intervened. They emit events now. Also: store write failures answer 500 rather than 409; the dashboard surfaces the server's actual reason instead of "409 Conflict"; action buttons stop propagation (acting on a task no longer also expands it), disable in flight, keep per-task errors instead of one shared string, and confirm before rejecting. Removed: the maybeRetryParked shim and markDead with their now-vacuous tests, WaitingTasks (no consumers; its tests were rewritten to assert the same routing through TaskByID), write-only Daemon.Runtime, and dir/dirs response bloat from /api/skills. skillSource checked workDir before sharedDir, mislabelling every shared skill when the two are equal. DefaultRoots now dedupes roots differing only by a trailing separator. The air build rule claiming to keep ui/dist current never ran -- it required one file to satisfy include_dir and include_file together, and ui/ is excluded from the walk. Deleted with the comment that promised it. task test:ui joins task check and CI; it ran nowhere before, so the dashboard suite could rot silently. Docs corrected where they described behaviour that no longer exists: parks no longer comment on the issue, state labels no longer drive retries, and forgerpc's doc claimed four proxied methods while listing three of five.
66 lines
2.7 KiB
JavaScript
66 lines
2.7 KiB
JavaScript
// Regression coverage for the DOM-building primitives.
|
|
//
|
|
// The KPI regression this pins: `el("div.stat-value", 0, ...)` used to treat a
|
|
// falsy first child (0, "", false) as "no attributes" and drop it, so stat
|
|
// tiles rendered an empty headline whenever the value was zero. The dashboards
|
|
// of fresh installs show exactly that -- labels and comparison text, no number.
|
|
|
|
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import "./shim.js";
|
|
import { el, mount } from "../src/base/dom.js";
|
|
import { statTile } from "../src/base/statTile.js";
|
|
|
|
test("el renders a falsy numeric value instead of dropping it", () => {
|
|
const node = el("div.stat-value", 0);
|
|
assert.equal(node.textContent, "0");
|
|
});
|
|
|
|
test("el renders an empty string first child without dropping later children", () => {
|
|
const node = el("div", "", "tail");
|
|
assert.equal(node.textContent, "tail");
|
|
});
|
|
|
|
test("el keeps falsy non-child values out of the output but keeps real children", () => {
|
|
const node = el("div", false, "x");
|
|
assert.equal(node.textContent, "x");
|
|
});
|
|
|
|
test("el still treats an attrs object as attributes", () => {
|
|
const node = el("a.btn", { href: "#/tasks", "aria-label": "Tasks" }, "Tasks");
|
|
assert.equal(node.getAttribute("href"), "#/tasks");
|
|
assert.equal(node.getAttribute("aria-label"), "Tasks");
|
|
assert.equal(node.textContent, "Tasks");
|
|
});
|
|
|
|
test("el still treats a Node first argument as a child", () => {
|
|
const child = el("span", "inner");
|
|
const node = el("div", child);
|
|
assert.equal(node.textContent, "inner");
|
|
});
|
|
|
|
test("mount replaces prior children", () => {
|
|
const root = el("div", "old");
|
|
mount(root, el("p", "new"));
|
|
assert.equal(root.textContent, "new");
|
|
});
|
|
|
|
test("statTile renders a zero headline value", () => {
|
|
const tile = statTile({ label: "Working now", value: 0, compare: "Nothing running" });
|
|
assert.equal(tile.querySelector(".stat-label").textContent, "Working now");
|
|
assert.equal(tile.querySelector(".stat-value").textContent, "0");
|
|
assert.equal(tile.querySelector(".stat-compare").textContent, "Nothing running");
|
|
});
|
|
|
|
test("statTile renders a string headline value", () => {
|
|
const tile = statTile({ label: "Tokens used", value: "2.4M", compare: "Across 14 days" });
|
|
assert.equal(tile.querySelector(".stat-value").textContent, "2.4M");
|
|
});
|
|
|
|
test("statTile shows a trend direction only when a trend is supplied", () => {
|
|
const plain = statTile({ label: "Delivered", value: 3, compare: "3% of all tasks" });
|
|
assert.equal(plain.querySelector(".stat-trend"), null);
|
|
const trended = statTile({ label: "Tokens used", value: 5, trend: 12.5, compare: "x", goodDirection: "down" });
|
|
assert.match(trended.querySelector(".stat-trend").textContent, /12\.5/);
|
|
});
|