EventsSince no longer depends on events.id being monotonic. The feed now pages a total order over (at, id): at is a fixed-width, lexicographically sortable UTC timestamp (storecontract.EventCursorLayout) and id is only a deterministic tie-break for rows sharing one timestamp. The cursor is an opaque string on the wire (EventsSinceRequest.cursor), carried verbatim as the SSE id: field and echoed back via Last-Event-ID, so EventSource resume needs no client change. A new idempotent migration normalises pre-existing RFC3339Nano at values to the fixed-width layout before finishTaskMigration, and idx_events_at backs the new query. Legacy integer and garbage cursors degrade to "from the beginning", preserving the old failed-ParseInt-yields-0 behaviour. Amends the "Dashboard live event delivery" decision's cursor-cannot-skip justification, which previously rested on commit-order id assignment.
55 lines
2.1 KiB
Go
55 lines
2.1 KiB
Go
package storecontract
|
|
|
|
import (
|
|
"fmt"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
)
|
|
|
|
// EventCursorLayout is the fixed-width UTC layout every persisted event's at
|
|
// column and every EventsSince cursor is built with. Fixed width is the whole
|
|
// point: time.RFC3339Nano trims trailing zeros, so a whole-second row
|
|
// ("...05Z") and a full-precision row ("...05.123456789Z") would compare out
|
|
// of chronological order as strings. With nine fractional digits always
|
|
// present, lexicographic order is chronological order. It mirrors edastore's
|
|
// capturedAtLayout, which exists for the same reason; the two stores now share
|
|
// this rule.
|
|
const EventCursorLayout = "2006-01-02T15:04:05.000000000Z"
|
|
|
|
// cursorSeparator joins the sort key and the row id inside a cursor. The sort
|
|
// key never contains it, so splitting on the last occurrence is unambiguous.
|
|
const cursorSeparator = "|"
|
|
|
|
// cursorIDWidth zero-pads the row id so the whole cursor is lexicographically
|
|
// sortable: the fixed-width sort key is followed by a fixed-width tie-break,
|
|
// and string comparison of two cursors is the total order (key, id).
|
|
const cursorIDWidth = 20
|
|
|
|
// EventCursor returns the opaque resume cursor for an event that happened at
|
|
// at with row id id. The cursor is a string so EventSource can carry it
|
|
// verbatim in its id: field and echo it back as the Last-Event-ID header; it
|
|
// is opaque to every consumer except EventsSince.
|
|
func EventCursor(at time.Time, id int64) string {
|
|
return at.UTC().Format(EventCursorLayout) + cursorSeparator + fmt.Sprintf("%0*d", cursorIDWidth, id)
|
|
}
|
|
|
|
// ParseEventCursor splits a cursor back into its sort key (the fixed-width at
|
|
// string) and row id. ok is false for an empty or malformed cursor, which
|
|
// means "from the beginning" -- the store must not treat a bad resume point as
|
|
// an error worth failing a feed over.
|
|
func ParseEventCursor(cursor string) (at string, id int64, ok bool) {
|
|
if cursor == "" {
|
|
return "", 0, false
|
|
}
|
|
i := strings.LastIndex(cursor, cursorSeparator)
|
|
if i < 0 {
|
|
return "", 0, false
|
|
}
|
|
id, err := strconv.ParseInt(cursor[i+1:], 10, 64)
|
|
if err != nil {
|
|
return "", 0, false
|
|
}
|
|
return cursor[:i], id, true
|
|
}
|