docs/prds/pr-review-agent.md's own header already declared this superseded (docs/architecture/adversarial-review.md, docs/prds/ operator-pr-review.md, docs/prds/review-calibration.md); this executes that removal per the maintainer's explicit decision, so no reference to the old path remains: - internal/domain/workflow/review.go, review_findings.go, review_report_md.go and their tests: Reviewer, ReviewRequest, StageReview, StagePostReviewComments, ReviewReport/ReviewFinding and friends. ReviewComment relocated into workflow.go (still used by Forger.CreateReviewComments and the new pr-review pipeline). - internal/app/agentworker/review.go: the ai-sdk-backed subagentReviewer. - internal/app/archied/pr_review.go: the synchronous operator-review path (prReviewer, gateway.ChatPRReviewer wiring). The review_pr chat tool now self-omits (nil reviewer) until the operator trigger is rebuilt to enqueue an async pr-review task instead of reviewing synchronously in the chat turn. - config.Repo.ReviewEnabled and its dashboard exposure. - Two composition-order tests and one dashboard test that existed only to pin the deleted path. Also splits PRReview()'s Stage list into prReviewDecisionStages() (phases 1-8) and stagePROutput() (phase 9), so a future caller can splice the decision phases before a PR exists and defer posting until after -- needed for the "archie's own PRs" trigger, not wired here: it needs the same stage-loop-around-StageOpenPR semantics this pass couldn't fully verify in the time available (does an Outcome-setting stage like StageOpenPR end the compiled-workflow-definition engine the same way it ends workflow.Run's literal loop?). Carries ScoredFinding. Adversary through synthesis so that trigger's blocking-finding check doesn't need to cross-reference back into the pre-synthesis slice. Not built in this pass, left as a precise continuation (see the bead comment): the watched-repositories and operator triggers, both blocked on the same real question -- how a forge-reading credential reaches PRSource's real implementation when the pr-review pipeline's Stage.Run bodies execute inside the sandboxed archie-agent process, which holds none today.
22 KiB
AGENTS.md
Guidance for any coding agent working in this repository.
Keep every rule here harness-agnostic: name the required behaviour, not the tool that provides it (e.g. "spawn a fresh reviewer that did not write the code", not a specific sub-command).
Code Quality & Refactoring Standards
- Zero Patch Stacking: Never apply more than two sequential fixes to the same logic block. If a solution fails twice, scrap the block and rewrite it cleanly.
- Root-Cause Fixes: Fix invalid state at the producer, not via defensive checks at the consumer.
- Architectural Simplicity: Prefer a complete 20-line rewrite over a 5-line band-aid that adds conditional complexity or obscures intent.
- Revert on Flail: If an implementation becomes convoluted to satisfy edge cases, discard the approach and select a simpler design.
What this is
archied is a resident daemon that polls a forge (GitHub, Gitea) for issues assigned/labelled to it, works each one in an isolated git worktree through a routed workflow (bootstrap / implement / TDD / feasibility), and opens pull requests for human review.
Architecture of record lives in docs/architecture/ -- organisation.md for
the package map, agent-system.md for the workflow-execution lifecycle and its
invariants, plugins-and-extensions.md for engine families. Read it before
making non-trivial changes. Key invariants: env-enforced gates, model never runs
git, and agent execution functions as a strict data boundary. Before adding a new
plugin engine, satisfy
docs/architecture/plugins-and-extensions.md#plugin-engine-rule-strict.
Before changing an area (frontend UI, agent, workflows, daemon, State Store,
control plane), read its page in docs/development/: it names every layer the
change must reach. This is not optional colour reading -- archie-core is built
as an extensible, customisable surface, not a fixed product, so a change that
looks complete inside one package routinely is not: a new setting that never
reaches the control-plane schema descriptor and dashboard parses but never
renders, is never editable, and never live-applies, exactly like a config
field with no consumer. The dev-docs page for the area is where that
cross-layer reach is written down; read it before starting, not after
something downstream turns out silently unwired. This applies whether the
work is yours directly or handed to a subagent or crew worker -- carry the
relevant docs/development page into their prompt, the same way a bead ID is
carried; "figure out what else needs updating" left implicit is exactly the
gap this note exists to close.
Scope Discipline
docs/architecture/ is authoritative for settled design.
docs/architecture/migration-decisions.md is the open decision register for the
domain migration.
- Settled design exists → Implement it immediately with a diff. Do not produce design prose. If a small detail is missing, ask the maintainer directly.
- No settled design exists (or open in
migration-decisions.md) → Write a decisive, 1-page design doc before coding. Land new capabilities indocs/prds/and migration questions indocs/architecture/migration-decisions.md. Promote todocs/architecture/only after implementation lands. - Strictly Prohibited: Ownership ledgers, field-level inventories, current-state traces, parity matrices for their own sake, and planning/refactor tracking issues.
- Solo Project Context: Prefer the smallest workable change over extensive defensive scaffolding.
- Verify handed-over input before acting on it. An export, transcript, or artifact that is empty, missing, or truncated is a blocking fact: report it before starting work that assumes its contents. Never reconstruct the intent from the working tree instead.
- PRD writing: Read and follow
docs/prds/RULES.mdbefore creating or editing a PRD.
Deployment Model
- Systemd is optional:
deployments/holds supported profiles (single-forge-github.toml,multi-forge-github-gitea.toml,local-ollama-standalone.toml,docker-nats-stack.toml,systemd-user-service.md). Never assume a systemd unit exists. - Chat filesystem confinement: Builtin tools default to workspace jail via
SetPathConfinement(!unrestricted). Unrestricted access requires[chat] unrestricted_filesystem = true. - NATS endpoint immutability: The daemon passes agent containers its startup
connection URL (
d.ConnectedNATS.URL). Containers and daemon must resolve this address. Embedded mode binds to the Docker bridge gateway. A SIGHUP reload ofnats.urllogs an error requiring restart to prevent split-brain delivery. - Container pull policy:
containers.pull_policymust be"missing"(default) or"always". Private registries return 401 on"always"because no auth is sent. Refresh explicitly viadocker compose pull agent. - Docker Compose:
docker-compose.ymlcarries optional external NATS and theagentbuild stanza. The agent uses abuildprofile soup -d natsnever starts it as a persistent service. - Config path: Runtime configuration lives at
${XDG_CONFIG_HOME:-~/.config}/archie/config.toml. Nothing in the working tree is load-bearing at runtime.
Release Process
See RELEASING.md. Most sessions touch only archied, making releases
gateway-only (RUNTIME=skip) by default. Skip untouched components
automatically and note it in the handoff.
Build & Test
Commands are defined in Taskfile.yml (requires Go 1.27.0,
Task, gofumpt, golangci-lint, Node/npm, and a
running Docker daemon: Postgres tests start postgres:18 through
testcontainers via internal/infrastructure/postgres/pgtest).
golangci-lint is the single writer for ordinary Go formatting; standalone
gofumpt formats generated protobuf contracts only.
task build # build archied and archie-agent binaries into bin/
task test # go test -short ./... (cached; task test:full runs everything uncached)
task test:ui # dashboard node tests (DOM-building primitives)
task ui # build dashboard into ui/dist (LAW asset)
task fmt # go fix ./... && golangci-lint fmt
task vet # go vet ./...
task lint # golangci-lint run ./...
task check # fmt + proto:lint + proto:check + docs:check + vet + lint + build + test + test:tools + test:ui (The Definitive Gate)
task dev # archied live-reload + Vite HMR together on :5173
Single package/test runs:
go test ./internal/domain/workflow/... -run TestName -v -count=1
Repository Hygiene
- Generated assets are LAW: Never modify, revert, or ignore generated files
in
ui/dist/or schema outputs. Incorporate them into relevant commits. - Ignored paths: Never commit build artifacts, binaries (
/bin/,/archied), DB files, working screenshots,.references/, ornode_modules/. - Scratch files: Place scratch files strictly in
/tmpor the harness scratch space. Never put scratch files in the working tree (worktree.CommitAllwill stage them). - Conventional Commits: Scope by package:
feat(webui): ...,fix(build): ...,chore(release): .... - Commit policy: Commit finished, gate-clean changes (
task checkpassing) without asking. Push only when instructed.
Organisation (Strict Domain-Driven Architecture)
docs/architecture/organisation.md is authoritative. Do not follow flat
structures found in legacy packages.
Layers and Ownership
internal/domain/<area>/: Domain logic, entities, state machines, commands, events, and required contracts (interfaces). Never imports infrastructure or app.internal/infrastructure/<service>/: Implementations of domain contracts (persistence, forge clients, external transports, config loading).internal/app/<application>/: Dependency injection, wiring domain to infrastructure, lifecycle management, and shutdown ordering.cmd/<binary>/: CLI flag parsing, OS signal traps, and entry point routing only. No domain wiring.
Invariants
- Dependency Flow:
cmd → app → {domain, infrastructure}, withinfrastructure → domainimplementing contracts. Downward/inward dependencies only. - Cross-Cutting Packages:
logging,events,eventbus,policy,taskstatesit directly underinternal/. They may be imported by any layer, but must import zero internal packages. Noshared/,utils/, orcommon/catch-alls. - File Layout: One file per API concern (
api_tasks.go,api_logs.go). A package owns its on-disk format end-to-end (e.g.internal/loggingdefines and reads its format; transport layers do not parse). - Frontend: Features live in
ui/src/<feature>/with colocated.jsand.css. Extract toui/src/base/only on the second distinct consumer.
Per-Package Invariants & Traps
-
Config fields (cross-cutting): a field that parses is not a field that works. A knob added to a struct the extensible surface reuses parses everywhere without taking effect anywhere, and a knob read from the wrong layer is just as invisible: a file key is only a seed once a stored resource outranks it. Before adding or reusing a config field, name its consumer, and reject the configuration when there is none - which is what this repo now does for per-identity
forge.intake. Two documents carry the detail:.agents/skills/archie-config-and-flagsholds the wiring matrix, the decoded-but-unwired ledger and the three shapes an unwired field can take;docs/architecture/configuration.mdis the authority on the config model and its reloadability criterion. -
internal/channels/telegram/: -
The long-polling worker must call
dropPendingUpdates(ctx, b)beforeb.Start(ctx)and on/restart. -
Always publish command menus to
default,all_private_chats, andall_group_chatssimultaneously viacommands.goto avoid scope shadowing from legacy registrations. -
ai-sdkStreaming:FullStreamwrites synchronously and MUST be drained completely to prevent producer deadlocks. Do not rely onTextStream(drops deltas). -
NATS Invariants:
-
ARCHIE_TASKSusesjetstream.WorkQueuePolicy. Do not bind overlapping consumer filters; useFetchon existing durables instead of newSubscribecalls. -
RPC and task responses must use core NATS
msg.Respondto write to ephemeral_INBOX.*subjects, noteventbus.Publisher. -
Always flush connections (
nc.Flush()) immediately after registering responders to avoid race conditions on initial requests. -
internal/gateway/Chat Prompt: System prompt<tools>blocks are rendered strictly from the activecore.ToolSet. Never decouple prompt tool definitions from passed runtime tools. -
internal/container/pool.go(WriteTaskJSON): Write task briefs to<worktree>/.git/task.json. Never place them in the worktree root (go-gitAdd{All:true}ignores.gitignoreand leaks root files into branch commits). -
MCP Providers: Daemon registers providers as optional via
providerRegistry.RegisterOptional. Missing or failed providers log warnings and degrade health without terminating the process. -
internal/infrastructure/staterpc/(State Store gRPC contract): Authority isdocs/prds/state-store-contract.md(rev. 2e) -- read it before changing this package or its callers. -
The proto (
proto/state/v1/state.proto, serviceStateStoreService, packagestatev1ininternal/contracts/state/v1/) is one gRPC service fronting every ratified store contract, including grant management; the Go consumer facades stay narrow (workflow.Store,store.TaskStore, etc., all ≤8 methods except theTaskStorecomposite) viastaterpc.Client's multiplevar _assertions -- never add a Go interface method without a matching RPC. -
Error sentinels (
store.ErrStaleTransition,ErrBindingNotFound, ...) cross the wire viamapError/unmapErrorinvalues.go, matched on(code, exact canonical message). Changing a canonical message string breakserrors.Ison the client without changing behaviour visibly -- treat those message constants as part of the wire contract. -
The State Store is a standalone process (
cmd/archie-state-store, run viaarchied.RunStateStore) -- the daemon and Gateway never own the task tables or serve this service in-process;boot.openStateStoreininternal/app/archied/state_store.gois the only place the task store is built. Never add a second listener for the same service, and never reintroduce an in-process serving path in the daemon/Gateway (TestOpenStoresNeverOwnsTaskDBguards this). -
Per-task credentials are scoped, not just authenticated:
daemon. StateStoreGrantIssuer(staterpc.GrantIssuer) registers a fresh task-scoped grant at the remote State Store viaRegisterTaskGrantbeforeContainerPool.Acquireand revokes it viaRevokeTaskGrantonRelease(acquireTaskContainer/processininternal/daemon/daemon.go). Fails closed (parks the task) if a State Store is configured but no issuer is wired -- it must never fall back to forwarding the daemon's own administrative token. Server-side,staterpc.TaskGrants.UnaryInterceptorauthorises a task-scoped token for onlyUpdate/Transition/InsertEventon its own task ID; every other RPC (includingRegisterTaskGrant/RevokeTaskGrantthemselves and the streaming capture RPCs) requires the administrative token. -
archie-agenthas exactly oneworkflow.Storepath: gRPC viastaterpc.Client(agenttransport/nats.Transport.Store), using theSTATE_STORE_URL/STATE_STORE_TOKENenv the daemon injects. The legacy NATSstorerpctransport is deleted (internal/storerpcno longer exists); do not reintroduce a dual-path selection. -
store.BindingDispatcher.RecordDispatchtakes no*sql.Tx(dropped in.4.2-- it cannot cross a gRPC boundary; production always passednil). Do not reintroduce a transaction parameter on a producer-owned store interface that a remote adapter must also implement. -
internal/forge/webhook/(forge webhook receiver): -
Verify HMAC (
webhookguard.VerifyHMACagainstX-Hub-Signature-256) before parsing the payload, never after -- an unverified body must not reachgithub.ParseWebHook. -
Do not give the webhook-built
workintake.TaskEnvelopea delivery-source- specific idempotency key.IdempotencyKey()is keyed onowner/repo/numberonly so a webhook-delivered issue and a later poll of the same issue dedup against each other viaPublishUnique; adding an event ID or timestamp to the key defeats that and reintroduces poll/webhook double-dispatch. -
Webhook intake refuses to start when
[[identities]]is configured (one receiver, one dispatch config). Do not silently enable it for multi-identity deployments without first building per-identity routing -- seedocs/architecture/messaging-and-work-intake.md's "Intake provenance" section. -
internal/domain/embedding/+internal/infrastructure/embedding/: Embedding client contract + implementation. Config-driven exactly like chat model roles:models.embedding = "provider/model"plus a[providers.*]entry.infrastructure/embedding.Newdegrades to(nil, false)-- never an error -- for a missing role, unknown provider, unsupported class, or unresolved credential; wired as an optional capability inbootstrap.go'ssetupEmbeddings. Only provider classes matchingconfig.Provider's shape are supported (openai, gemini, ollama, cohere, mistral) -- azure needs aDeploymentfield this config type doesn't have. -
internal/domain/sampling/: The curatorSamplerinterface (seedocs/prds/curator-sampler-wave1.md) plus four pure, deterministic strategies (recency, staleness, random, all). No curator consumes aSampleryet --curator.Registraris untouched by this package.
Development Protocol
- Red (Failing Test): For behaviour with real logic, branching, or a
contract, write failing table-driven tests first against target behaviour.
Verify the failure originates from test assertions, not compilation errors.
Do not write tests that restate an assignment or a constant: a test that
cannot fail for an interesting reason is noise in the gate.
- A test is a maintenance liability, not free insurance. Every test added is code the project now carries forever: it must compile, it must keep passing as the code around it changes, and someone reads it during every future change to that area. Write one because a real regression would slip through without it, not because the function was touched.
- Never pin a literal end-user config value, database row, or settings
document as the thing under test. Test the validation rule, the
migration's shape, or the round-trip contract -- not one operator's
specific
config.tomlvalue, a hand-picked DB fixture that mirrors real data, or a setting's current default. Those change for reasons that have nothing to do with a regression, and a test pinned to one breaks on every such change, which is cost with no signal. - Test-only helpers, fakes and fixtures live in
_test.gofiles (or a package no production.gofile imports), never in a file the binary ships.go builddoes not compile_test.gofiles into the binary, but an exported "test helper" living in a regular source file compiles into every binary that imports the package, whether or not a test ever runs. If a helper must be shared across packages, put it behind a build-tagged or_test.go-suffixed file in anxtest-style package, not behind a normal export. - Coverage is not the goal. A codebase that grows mostly because tests multiplied faster than the feature they cover is a symptom, not progress -- prefer fewer, sharper tests over one per line changed.
- Green (Implementation): Implement minimal code to satisfy the failing tests.
- Quality Gate: Run
task check.- The gate gates the commit. Let the gate's exit status decide whether
the commit runs, as one conditional chain (
check && commit && push). Writing them as separate statements on one command line makes the gate decorative: nothing reads its status but the operator, and a failure is discovered after it has already been pushed. - Never assert a gate result you have not just produced on that exact tree. A commit message outlives the tree it describes, and "verified" is read by people who were not there. If the tree moved, describe the change and let the run speak.
- The gate gates the commit. Let the gate's exit status decide whether
the commit runs, as one conditional chain (
- Formatting is LAW: Adopt all formatting and simplification changes from
task fmt(go fix+ the configured golangci-lint formatters) verbatim. Never revert or fight canonical linter/formatter diffs. - No standing adversarial-review pass (for contributors): Do not spawn a
separate fresh-context reviewer pass on every change as a matter of course.
Red-green TDD plus
task checkis the gate; a manual adversarial pass is opt-in per request — ask before running one. This is the rule for a human or agent contributor. Separately, archied runs its own PR review pipeline (docs/prds/pr-review-agent.md) before it opens a PR of its own — see that PRD's Triggers section ("archie's own PRs"). It supersedes the older single-reviewer stagedocs/architecture/adversarial-review.mddescribed (repo.review_enabledno longer exists). The two paths are distinct: you run a manual pass when asked; archied runs its own before it opens a PR. - Linter Guard:
- When using
errorlintfixes, ensure boolean predicates (e.g.exitErr.ExitCode() == 1) are retained alongsideerrors.As. - When extracting loops/conditionals, verify slice mutations and pointer semantics do not duplicate elements.
Issue Tracking (Beads)
All task management is tracked via bd (beads). Do not write local Markdown TODO lists or use non-Beads trackers.
Commands
bd ready # List unclaimed work
bd show <id> # View issue details
bd update <id> --claim # Claim an issue
bd close <id> # Mark issue complete
bd remember # Persist cross-session architectural facts
- Run
bd primeto inspect full engine context. - Use
bd rememberfor knowledge retention. Do not write to rootMEMORY.mdfiles. - Issues live in a local Dolt DB, synced to its own
git+remote viabd dolt push/bd dolt pull..beads/issues.jsonland.beads/interactions.jsonlare local-only export/audit files (.gitignored,export.auto: false) -- nevergit addthem and never create a commit whose only content is beads bookkeeping. Bead state moves through Dolt, not through git commits on this repo. - A bead never carries production instance detail. No operator host name,
hostname, IP or port, filesystem path, PID, or credential -- in the body
or the title, since both sync to the Dolt remote and are therefore
published. Write the mechanism and the evidence shape instead ("a production
host", "the State Store target", "the host's
config.toml"), and put the host-specific facts in the operator's memos instance, which the bead may point at. This is the same class of rule as never committing a credential: the tracker is not a private store.
Session Completion Protocol
-
Log remaining work: File new items via
bdfor identified debt or follow-up tasks. -
Run gate: Verify
task checkpasses completely clean. -
Update tracker: Close finished issues via
bd close <id>. This alone is not commit-worthy -- do not stage or commit.beads/for it. -
Commit: Only for actual code/doc changes, scoped to the files that changed.
git add <scoped-files> git commit -m "feat(scope): description" -
Sync & Push Policy: Do not push to git remotes or run
bd dolt pushunless explicitly instructed. -
Handoff: Report changed files, gate verification results, and active issue states.
Maintaining this file
Keep this file for knowledge useful to almost every future agent session in this project. Do not repeat what the codebase already shows; point to the authoritative file or command instead. Prefer rewriting or pruning existing entries over appending new ones. When updating this file, preserve this bar for all agents and keep entries concise.