Files
archie/internal/infrastructure/harnesssession/harnesssession_test.go
T
sam 71fa670512 fix(harness): keep the setup container alive with archie's own binary
A setup session started its container with "sleep infinity" and opened the
PTY with "sh -l". Neither binary is guaranteed: the spec capability whose
floor is a shell and bash is com.docker.sandbox/sbx@1, and archie's
supported map does not list it, so a Kit image need not provide either. A
missing sleep killed the container at start and a missing sh failed the
exec, both as an opaque error.

The container now runs archie-agent hold as its entrypoint. The agent
binary is archie's own and already mounted into every Kit, so the
keepalive needs nothing the image may lack and the container env stays
empty. Before opening the PTY, harnesssession probes for bash then sh and
returns ErrNoShell naming the Kit reference when neither is present.

Test: TestPickShell covers bash-preferred, sh-only, neither, and a probe
that cannot run.
2026-10-09 13:05:05 +11:00

55 lines
1.3 KiB
Go

package harnesssession
import (
"errors"
"slices"
"testing"
)
// A setup terminal must run a shell the image provides, not one archie assumes.
// bash is preferred when both exist; neither is the image's honest failure.
func TestPickShell(t *testing.T) {
t.Parallel()
cases := []struct {
name string
have map[string]bool
failing bool
want []string
wantErr bool
}{
{name: "bash wins when both exist", have: map[string]bool{"bash": true, "sh": true}, want: []string{"bash", "-l"}},
{name: "sh when bash is absent", have: map[string]bool{"sh": true}, want: []string{"sh", "-l"}},
{name: "neither shell is an error", have: map[string]bool{}, wantErr: true},
{name: "a probe that cannot run is not a shell", failing: true, wantErr: true},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
probe := func(argv []string) (int, error) {
if tc.failing {
return 0, errors.New("exec failed")
}
if tc.have[argv[0]] {
return 0, nil
}
return 127, nil
}
got, err := pickShell(probe)
if tc.wantErr {
if !errors.Is(err, ErrNoShell) {
t.Fatalf("pickShell() = %v, want ErrNoShell", err)
}
return
}
if err != nil {
t.Fatalf("pickShell() = %v", err)
}
if !slices.Equal(got, tc.want) {
t.Errorf("pickShell() = %v, want %v", got, tc.want)
}
})
}
}