Reachability (tools/reachaudit, epic archie-core-06ag) answers "is this code in a shipped binary?". It cannot answer the complementary question: "does every declared contract surface have a consumer, or a declaration that it has none?". ratelimit was in the binary closure and called by nothing, which reachability could not see. tools/contractaudit classifies each subject of each declared surface as CONSUMED, DECLARED-UNCONSUMED, UNDECLARED-UNCONSUMED, or STALE-DECLARATION, and only the last two are findings. The declaration allowlist must match reality exactly: a missing entry fails and so does an entry that outlived its subject, because a stale allowlist is how a gate quietly stops checking anything. Surfaces: the two gRPC services, whose consumption is derived by scanning adapter bodies for calls through the generated client, and the dashboard HTTP API, matched between the registerXRoutes call sites and the path literals the bundled client calls. Findings on the current tree, all deliberate and now declared: ListCaptures and ListUndispatchedCaptures are superseded by their streaming variants -- staterpc's client calls StreamCaptures -- so no production client reaches the unary RPCs. Three bugs this tool found in itself, each recorded because each is the class of error that makes a conformance check worse than none: - Joining RPCs to adapter methods by name silently reported live RPCs as unconsumed, because adapters do not map one-to-one: StoreClient.Get calls GetSession, List calls ListSessions. - Reflecting over the client value rather than the pointer reported zero methods, hence the whole surface unconsumed. - Treating the asset mount and the health probes as dashboard API routes reported four healthy routes as undeclared; they have different consumers and are out of scope for this surface. The consumer extractor fails loudly on a call shape it cannot parse rather than under-reporting, and every check is negative-tested: a route, an RPC, and a removed consumer are each injected, confirmed to fail for the right reason, and reverted. The declaration staleness rule is tested too. Advisory when run directly; task check runs it -strict. See docs/prds/contract-conformance-audit.md.
39 lines
2.4 KiB
JSON
39 lines
2.4 KiB
JSON
{
|
|
"$comment": [
|
|
"Contract-conformance declarations. Every entry here is a declared-unconsumed",
|
|
"surface: a capability that exists, that no client reaches, and that is",
|
|
"deliberately left that way. It must match reality exactly -- a missing entry",
|
|
"is an undeclared finding and an entry that is no longer true is a stale one,",
|
|
"and both fail a -strict run. See docs/prds/contract-conformance-audit.md.",
|
|
"",
|
|
"Managed by tools/contractaudit. Reasons state the consequence, not 'TODO':",
|
|
"this file is the only place the debt is legible."
|
|
],
|
|
"surfaces": {
|
|
"proto/state/v1/state.proto": {
|
|
"StateStoreService/ListCaptures": {
|
|
"reason": "Superseded by StreamCaptures. The remote adapter's ListCaptures method (staterpc/client.go) calls StreamCaptures, not this unary RPC, so no production client reaches it. The server keeps it implemented as a compatibility surface for callers of the raw proto.",
|
|
"tracker": "archie-core-8cda.4"
|
|
},
|
|
"StateStoreService/ListUndispatchedCaptures": {
|
|
"reason": "Superseded by StreamUndispatchedCaptures, on the same terms as ListCaptures: the remote adapter's ListUndispatchedCaptures calls the streaming variant, leaving this unary RPC reachable only through the raw proto.",
|
|
"tracker": "archie-core-8cda.4"
|
|
}
|
|
}
|
|
},
|
|
"blindSpots": [
|
|
{
|
|
"surface": "internal/webui",
|
|
"reason": "Consumer extraction is textual over ui/src. A path assembled by string concatenation rather than written as a literal is invisible; scanFile fails loudly when a call shape it cannot parse appears, but it cannot see a path that is never a literal. Routes whose consumer is outside the dashboard (the asset mount, the health probes, the capture-intake webhook) are excluded from this surface by design: they have different consumers and are not part of the dashboard API contract."
|
|
},
|
|
{
|
|
"surface": "proto/state/v1/state.proto",
|
|
"reason": "Consumption is derived by scanning adapter bodies for calls through the generated client. An RPC reached only through runtime-loaded code (Yaegi) or reflection would read as unconsumed. No such path exists today."
|
|
},
|
|
{
|
|
"surface": "proto/gateway/v1/chat.proto",
|
|
"reason": "As above. Note that gatewayrpc is served by archie-gateway and consumed by archied and archie-ui; a consumer living outside this repository would be invisible here."
|
|
}
|
|
]
|
|
}
|