* refactor(state-store): delete NATS storerpc; agent store is gRPC-only (archie-core-8cda.4.6) The agent is fully on the gRPC State Store contract, so the legacy NATS storerpc path is dead (docs/prds/state-store-contract.md §12 step 4): - delete internal/storerpc (Server, Client, subjects) and its tests - drop the storerpc registration from registerTaskRPCServers and the now-unused store param - make the agent transport's State Store URL required and Store() return only the gRPC staterpc.Client (no NATS fallback) - rework agentworker/agent transport tests to back the store with a real gRPC State Store server instead of the deleted NATS storerpc server The agent binary now fails fast when STATE_STORE_URL is absent. Agent store calls (workflow.Store) go over gRPC to the archie-state-store service. * refactor(state-store): delete daemon/gateway in-process store ownership (archie-core-8cda.4.6) The daemon and gateway no longer open archie.db in-process: the single SQLite file is owned by the standalone archie-state-store process, and both consumers dial its gRPC State StateStore contract (docs/prds/state-store-contract.md §12 step 7, no dual-store ownership). - openStores no longer opens the production task store or seeds b.st; it only wires secrets/forge and the gateway conversation store - openStateStoreAdapter now requires [services.state].target (the old local default is deleted) and resolves b.stateStore as the remote *staterpc.Client - delete the in-process startStateStoreServer (the multiplexed gRPC server and its per-task bearer-token registry) from the daemon composition - RunGateway now resolves the same remote State Store adapter; its session SQLite stays Gateway-owned and untouched - daemon.ConnectedStateStore carries the configured target plus the resolved bearer token, which containerEnv injects as STATE_STORE_URL / STATE_STORE_TOKEN so archie-agent authenticates to the same remote service - readiness store probe reads b.stateStore PRD-consistent choice (noted): with the in-process server gone, per-task token generation is removed; the daemon/gateway/agent all present the single [services.state].target_token (or STATE_STORE_TOKEN secret) that the standalone store validates. * docs(webui): require [services.state].target in config and deployment templates (archie-core-8cda.4.6) After the in-process store path is deleted, archied and archie-gateway dial the standalone archie-state-store gRPC service via [services.state].target and never open archie.db themselves (docs/prds/state-store-contract.md §12 step 7). - config.example.toml documents [services.state].target as required, with the loopback vs Docker-bridge gateway + target_token rule - deployment templates set [services.state] per topology: bridge gateway + token for container-mode agents, loopback for host-only - deployments/README.md and systemd-user-service.md describe start commands for both topologies and drop the stale "not yet consumed by the daemon" note * style: gofumpt alignment for State Store daemon literal; appease noctx/staticcheck (archie-core-8cda.4.6) * docs(state-store): refresh stale in-process references post-cutover (archie-core-8cda.4.6)
135 lines
3.9 KiB
Go
135 lines
3.9 KiB
Go
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"errors"
|
|
"log/slog"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/samcharles93/archie-core/internal/app/agentworker"
|
|
)
|
|
|
|
func TestRunCommandPreservesCLIExitSemantics(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
args []string
|
|
getenv func(string) string
|
|
worker workerRunner
|
|
wantCode int
|
|
}{
|
|
{name: "help", args: []string{"-h"}},
|
|
{name: "flag parse error", args: []string{"-unknown"}, wantCode: 2},
|
|
{name: "removed consumer flag", args: []string{"-consumer", "legacy"}, wantCode: 2},
|
|
{name: "missing NATS URL", wantCode: 1},
|
|
{name: "missing state store URL", args: []string{"-nats-url", "nats://test"}, wantCode: 1},
|
|
{
|
|
name: "worker failure",
|
|
args: []string{"-nats-url", "nats://test", "-state-store-url", "127.0.0.1:9090"},
|
|
worker: func(context.Context, agentworker.Settings, *slog.Logger) error {
|
|
return errors.New("worker failed")
|
|
},
|
|
wantCode: 1,
|
|
},
|
|
{
|
|
name: "success",
|
|
args: []string{"-nats-url", "nats://test", "-state-store-url", "127.0.0.1:9090"},
|
|
worker: func(context.Context, agentworker.Settings, *slog.Logger) error {
|
|
return nil
|
|
},
|
|
},
|
|
}
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
getenv := test.getenv
|
|
if getenv == nil {
|
|
getenv = func(string) string { return "" }
|
|
}
|
|
worker := test.worker
|
|
if worker == nil {
|
|
worker = func(context.Context, agentworker.Settings, *slog.Logger) error {
|
|
t.Fatal("worker called")
|
|
return nil
|
|
}
|
|
}
|
|
if got := runCommand(test.args, getenv, &bytes.Buffer{}, worker); got != test.wantCode {
|
|
t.Fatalf("runCommand() = %d, want %d", got, test.wantCode)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestRunCommandRequiresNATSURL(t *testing.T) {
|
|
var stderr bytes.Buffer
|
|
called := false
|
|
code := runCommand(nil, func(string) string { return "" }, &stderr, func(context.Context, agentworker.Settings, *slog.Logger) error {
|
|
called = true
|
|
return nil
|
|
})
|
|
if code != 1 || called {
|
|
t.Fatalf("(code, worker called) = (%d, %v), want (1, false)", code, called)
|
|
}
|
|
for _, want := range []string{"error: -nats-url or NATS_URL is required", "Usage of archie-agent:"} {
|
|
if !strings.Contains(stderr.String(), want) {
|
|
t.Fatalf("stderr %q does not contain %q", stderr.String(), want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestRunCommandMapsWorkerOutcomeToExitStatus(t *testing.T) {
|
|
workerErr := errors.New("startup failed")
|
|
tests := []struct {
|
|
name string
|
|
workerErr error
|
|
wantCode int
|
|
}{
|
|
{name: "success"},
|
|
{name: "worker failure", workerErr: workerErr, wantCode: 1},
|
|
}
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
var stderr bytes.Buffer
|
|
code := runCommand([]string{"-nats-url", "nats://flag"}, func(string) string { return "token" }, &stderr, func(_ context.Context, settings agentworker.Settings, _ *slog.Logger) error {
|
|
if settings.NATSURL != "nats://flag" || settings.NATSToken != "token" {
|
|
t.Fatalf("settings = %#v", settings)
|
|
}
|
|
return test.workerErr
|
|
})
|
|
if code != test.wantCode {
|
|
t.Fatalf("code = %d, want %d", code, test.wantCode)
|
|
}
|
|
if test.workerErr != nil && stderr.Len() != 0 {
|
|
t.Fatalf("stderr = %q, want command not to duplicate application logging", stderr.String())
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNATSConnectionSettings(t *testing.T) {
|
|
getenv := func(name string) string {
|
|
switch name {
|
|
case "NATS_URL":
|
|
return "nats://nats.example:4222"
|
|
case "NATS_TOKEN":
|
|
return "test-nats-token"
|
|
default:
|
|
return ""
|
|
}
|
|
}
|
|
|
|
t.Run("container environment", func(t *testing.T) {
|
|
url, token := natsConnectionSettings("", getenv)
|
|
if url != "nats://nats.example:4222" || token != "test-nats-token" {
|
|
t.Fatalf("natsConnectionSettings() = (%q, %q)", url, token)
|
|
}
|
|
})
|
|
|
|
t.Run("flag URL takes precedence", func(t *testing.T) {
|
|
url, token := natsConnectionSettings("nats://flag.example:4222", getenv)
|
|
if url != "nats://flag.example:4222" || token != "test-nats-token" {
|
|
t.Fatalf("natsConnectionSettings() = (%q, %q)", url, token)
|
|
}
|
|
})
|
|
}
|