* feat(gateway): give /status a real daemon-health surface Phase 2 of archie-core-wp9s. Phase 1 split the commands apart (health vs work) but left /status with one aggregate queue line and a static runtime block; it could not answer the questions an operator actually asks when something feels wrong. /status now reports, between the queue line and the runtime block: - Broker: the live state of this process's own NATS connection (eventbus/nats.Client.Connected), not a fresh dial -- a probe would report the probe's reachability, not the daemon's. - Containers: the pool's own active counter against the configured cap (Pool.Active/Cap), not a Docker listing, which would include containers this pool does not own. A zero cap means unlimited, so it is not shown as a ratio. - Channels: the channel manager's real lifecycle state, including a failed adapter's reason (the documented decision: read the existing manager rather than re-deriving health per adapter). - Chat model: last-known outcome of every chat-model call this process made, recorded once in sendChatTurn (the single choke point) and read back by /status. The second documented decision: never a live probe, so /status stays instant and reports what happened -- or says plainly that nothing has been attempted yet. - Last poll: when the most recent poll pass began, stamped on both poll paths (Run's single-identity loop and runIdentities' per-identity goroutines). A pass that hangs leaves the stamp stale, which is the signal; stamping completion would leave a wedged poller looking healthy. Truthful or absent: a section this process has no source for is omitted rather than rendered as a zero. The standalone Gateway owns no poll loop, pool or channel manager, so its /status reports broker and chat-model health only; aggregating across processes would need a new daemon RPC and is deliberately not built. Version stays out (/version owns it). /status and /tasks descriptions now describe what each command actually does on both published surfaces (Telegram menu/help and the shared specs), pinned by a test that also fails if the two surfaces drift. Sources are read through functions, not captured values: occupancy and channel state move, and the daemon is built after the gateways, so a source captured at construction would freeze /status on boot state. Left in place deliberately: the Runtime (provider/model) block, which Phase 1 flagged and which duplicates /model and /whoami. Removing it is a product call on a command Sam uses daily, not a mechanical follow-up. * docs(prds): record the two open /status health decisions as settled Both were flagged in PR #892 as needing the maintainer's call; both are now answered, and the PRD is the place a follow-up would look: - The Runtime (provider/model) block stays. It is the one line in /status the ticket's own rule says should not be there, but /status is read daily to see the active model at a glance, so the duplication is deliberate. Recorded as a settled product decision so it is not removed later as an oversight. - Health stays per-process. Pooling the daemon's and the Gateway's chat-model outcomes would need a new daemon<->gateway health RPC for one status line, and a per-process line is true where an aggregate would be a claim about a process the answering one cannot see. /agents' published description is still left to archie-core-mxls, unchanged.
77 lines
2.0 KiB
Go
77 lines
2.0 KiB
Go
package daemon
|
|
|
|
import (
|
|
"context"
|
|
"log/slog"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/samcharles93/archie-core/internal/config"
|
|
)
|
|
|
|
// TestPollPassStampsLastPollAt pins the "is the poller still running" fact
|
|
// /status reports: the daemon stamps the moment a poll pass begins, so a
|
|
// missing or stale timestamp is what tells an operator the poll loop has
|
|
// stopped or is stuck inside a pass.
|
|
//
|
|
// Both poll paths are covered because they are separate goroutines with
|
|
// separate entry points: Run's single-identity loop drives poll, while
|
|
// runIdentities drives one pollForIdentity per identity. A stamp on only one
|
|
// of them leaves /status permanently reporting "never" for the other
|
|
// deployment shape.
|
|
func TestPollPassStampsLastPollAt(t *testing.T) {
|
|
ctx := context.Background()
|
|
repo := config.Repo{Owner: "acme", Name: "widget"}
|
|
|
|
pollPaths := []struct {
|
|
name string
|
|
poll func(context.Context, *Daemon)
|
|
}{
|
|
{
|
|
name: "single-identity poll",
|
|
poll: func(ctx context.Context, d *Daemon) { d.poll(ctx) },
|
|
},
|
|
{
|
|
name: "per-identity poll",
|
|
poll: func(ctx context.Context, d *Daemon) {
|
|
d.pollForIdentity(ctx, &IdentityRunner{
|
|
Name: "main",
|
|
Forge: d.Forge,
|
|
Repos: d.Cfg.Get().Repos,
|
|
Log: d.Log,
|
|
})
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, path := range pollPaths {
|
|
t.Run(path.name, func(t *testing.T) {
|
|
d := &Daemon{
|
|
Cfg: config.NewHolder(config.Config{
|
|
BotUser: "archie",
|
|
Repos: []config.Repo{repo},
|
|
Dispatch: config.Dispatch{Trigger: "assignee"},
|
|
}),
|
|
Forge: &pollingForge{},
|
|
Log: slog.New(slog.DiscardHandler),
|
|
}
|
|
|
|
if got := d.LastPollAt(); !got.IsZero() {
|
|
t.Fatalf("LastPollAt() before any poll pass = %v, want the zero time", got)
|
|
}
|
|
|
|
before := time.Now()
|
|
path.poll(ctx, d)
|
|
after := time.Now()
|
|
|
|
got := d.LastPollAt()
|
|
if got.IsZero() {
|
|
t.Fatal("LastPollAt() after a poll pass = zero, want the pass's start time")
|
|
}
|
|
if got.Before(before) || got.After(after) {
|
|
t.Errorf("LastPollAt() = %v, want a time within [%v, %v]", got, before, after)
|
|
}
|
|
})
|
|
}
|
|
}
|