Files
archie/internal/domain/sampling/staleness_test.go
T
sam 268283eb16 chore(curator): add embedding client and sampler interface prerequisites (#752)
* feat(curator): add embedding client and sampler wave-1 prerequisites

Bead archie-core-1786637500752-415-434e5bb9 (GitHub #436) was closed with
no linked PR/commits, and the surprisal-sampling bead
archie-core-1786637500776-416-600a66e5 (GitHub #437) found none of its
stated prerequisites -- an embedding client, a Sampler interface, or the
four wave-1 cheap sampling strategies -- actually exist. This builds them:

- internal/domain/embedding + internal/infrastructure/embedding: a narrow
  typed embedding client, config-driven via a providers table + a role in
  [models], mirroring the existing chat model role convention. Degrades to
  capability-unavailable (never fails startup or a call) for a missing
  role, unknown provider, unsupported class, or unresolved credential.
  Wired as an optional capability in bootstrap.go's setupEmbeddings.
- internal/domain/sampling: the Sampler interface plus recency, random,
  all, and staleness-proxy strategies, per docs/prds/curator-sampler-wave1.md.
  Deterministic given fixed inputs, matching GitHub #437's stated
  acceptance criterion for the embedding-backed strategy it will add
  behind this same interface (not part of this change).

Table-driven tests throughout; httptest for the embedding client, no live
service. No curator wiring yet -- nothing consumes either capability in
this change.

* no-mistakes(document): docs(architecture): mark curator sampling prereqs as landed
2026-09-05 22:53:08 +10:00

65 lines
1.6 KiB
Go

package sampling
import (
"context"
"testing"
"time"
)
func TestStalenessSampler(t *testing.T) {
t.Parallel()
base := time.Date(2026, 1, 1, 0, 0, 0, 0, time.UTC)
candidates := []Candidate{
{ID: "newest", At: base.Add(2 * time.Hour)},
{ID: "middle", At: base.Add(time.Hour)},
{ID: "oldest", At: base},
}
tests := []struct {
name string
cap int
wantIDs []string
}{
{name: "no cap orders oldest first", cap: 0, wantIDs: []string{"oldest", "middle", "newest"}},
{name: "cap keeps only the stalest", cap: 2, wantIDs: []string{"oldest", "middle"}},
{name: "cap larger than count returns everything", cap: 100, wantIDs: []string{"oldest", "middle", "newest"}},
}
s := NewStaleness()
if s.Name() != "staleness" {
t.Fatalf("Name() = %q, want %q", s.Name(), "staleness")
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
got, err := s.Sample(context.Background(), candidates, Request{Cap: tt.cap})
if err != nil {
t.Fatalf("Sample() error = %v", err)
}
assertIDs(t, got, tt.wantIDs)
})
}
}
func TestStalenessSamplerTiesKeepInputOrder(t *testing.T) {
t.Parallel()
at := time.Date(2026, 1, 1, 0, 0, 0, 0, time.UTC)
candidates := []Candidate{
{ID: "first", At: at},
{ID: "second", At: at},
{ID: "third", At: at},
}
got, err := NewStaleness().Sample(context.Background(), candidates, Request{})
if err != nil {
t.Fatalf("Sample() error = %v", err)
}
assertIDs(t, got, []string{"first", "second", "third"})
}
func TestStalenessSamplerDoesNotMutateInput(t *testing.T) {
t.Parallel()
assertInputNotMutated(t, NewStaleness())
}