Files
archie/internal/channels/telegram/ratelimit_test.go
T
sam a84085c89e fix(telegram): drop retry_after bandaid, bump go-telegram/bot to v1.24.0
go-telegram/bot v1.24.0 fixes getUpdates to honour Telegram's retry_after
on a 429 instead of its own 100ms-doubling-to-5s backoff (release notes:
https://github.com/go-telegram/bot/releases/tag/v1.24.0). pipelineErrorHandler
was our workaround for that upstream gap -- it now just logs.
2026-08-28 22:28:43 +10:00

53 lines
1.3 KiB
Go

package telegram
import (
"context"
"errors"
"fmt"
"log/slog"
"testing"
"time"
"github.com/go-telegram/bot"
)
// TestPipelineErrorHandlerDoesNotBlock pins that the handler is a pure logger
// post go-telegram/bot v1.24.0: the library now honours retry_after itself
// (https://github.com/go-telegram/bot/releases/tag/v1.24.0), so the handler
// that used to block for the stated interval on our side would double-wait.
func TestPipelineErrorHandlerDoesNotBlock(t *testing.T) {
tests := []struct {
name string
err error
}{
{
name: "bare rate limit error",
err: &bot.TooManyRequestsError{RetryAfter: 30},
},
{
// The library wraps it: fmt.Errorf("error get updates, %w").
name: "wrapped rate limit error is still recognised",
err: fmt.Errorf("error get updates, %w", &bot.TooManyRequestsError{RetryAfter: 30}),
},
{
name: "unrelated errors are logged without pausing",
err: errors.New("502 Bad Gateway"),
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
g := &Gateway{log: slog.New(slog.DiscardHandler)}
handle := g.pipelineErrorHandler(context.Background())
start := time.Now()
handle(tc.err)
elapsed := time.Since(start)
if elapsed > 250*time.Millisecond {
t.Errorf("returned after %s, want immediate return (no local backoff)", elapsed)
}
})
}
}