57 lines
2.1 KiB
Go
57 lines
2.1 KiB
Go
package gatewayrpc
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
"testing"
|
|
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/status"
|
|
"google.golang.org/protobuf/encoding/protojson"
|
|
|
|
pb "github.com/samcharles93/archie-core/internal/contracts/gateway/v1"
|
|
"github.com/samcharles93/archie-core/internal/domain/access"
|
|
"github.com/samcharles93/archie-core/internal/domain/org"
|
|
"github.com/samcharles93/archie-core/internal/secret"
|
|
)
|
|
|
|
func TestSecretCheckBoundary(t *testing.T) {
|
|
t.Setenv("ARCHIE_SECRET_CHECK_TEST", "never-return-this-value")
|
|
registry := secret.NewRegistry()
|
|
s := server{catalog: Catalog{CheckSecret: func(ref secret.SecretRef) bool { _, err := registry.Resolve(ref); return err == nil }}}
|
|
owner := access.Principal{Org: org.DefaultOrgID, Memberships: []org.Membership{{OrgID: org.DefaultOrgID, Role: org.RoleOwner}}}
|
|
for _, tc := range []struct {
|
|
name string
|
|
principal access.Principal
|
|
engine, key string
|
|
code codes.Code
|
|
resolved bool
|
|
}{
|
|
{"resolved", owner, "env", "ARCHIE_SECRET_CHECK_TEST", codes.OK, true},
|
|
{"missing", owner, "env", "ARCHIE_SECRET_CHECK_MISSING", codes.OK, false},
|
|
{"unknown engine", owner, "uninstalled", "key", codes.OK, false},
|
|
{"empty reference", owner, "", "", codes.InvalidArgument, false},
|
|
{"member cannot probe", access.Principal{Org: org.DefaultOrgID}, "env", "ARCHIE_SECRET_CHECK_TEST", codes.PermissionDenied, false},
|
|
{"other org cannot probe", access.Principal{Org: "other"}, "env", "ARCHIE_SECRET_CHECK_TEST", codes.PermissionDenied, false},
|
|
} {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
response, err := s.CheckSecret(access.WithPrincipal(context.Background(), tc.principal), &pb.CheckSecretRequest{Engine: tc.engine, Key: tc.key})
|
|
if status.Code(err) != tc.code {
|
|
t.Fatalf("code = %s, want %s", status.Code(err), tc.code)
|
|
}
|
|
if err == nil {
|
|
if response.Resolved != tc.resolved {
|
|
t.Fatalf("resolved = %v, want %v", response.Resolved, tc.resolved)
|
|
}
|
|
body, err := protojson.Marshal(response)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if strings.Contains(string(body), "never-return-this-value") {
|
|
t.Fatal("secret value leaked")
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|