The event-capture tables (captures, mappings, bindings, binding_dispatches,
playbook_dispatches) now live in PocketBase-owned collections and their ids
are opaque record ids rather than autoincrement integers. The task lifecycle
stays on SQLite: tasks/transitions/events carry FIFO claim ordering, id-cursor
pagination and the task-grant map, none of which gain anything from being
hand-editable. binding_dispatches.task_id is the single seam and stays an
integer addressing that store.
BREAKING: CapturedEvent.Id, Mapping.Id, Binding.Id and Binding.MappingId are
strings on the wire, as are the ids in the capture/mapping/binding requests.
RecordDispatchRequest.task_id is deliberately unchanged.
What the collections buy, beyond storage: a payload nobody has modelled yet is
inspectable, a mapping is editable at runtime, and a binding's relation to its
mapping is enforced. The old schema declared no FOREIGN KEY on that link, so a
dangling mapping_id was previously possible and is now refused.
Behaviour preserved deliberately, each recovered from the SQLite version
rather than reimplemented from memory:
- draft -> pending_approval -> armed, with approval only from
pending_approval and an edit always returning a binding for re-approval
- one binding per source, guarded on insert, update and approve
- an empty secret on update keeps the stored one, so an edit form that does
not echo it back cannot silently disarm a binding
- ErrMappingNotFound / ErrBindingNotFound on a missing delete target
- sentinels are re-exported from storecontract, never redefined: staterpc
matches on exact canonical message to rehydrate them, so a second
definition would break errors.Is across the wire invisibly
Two implementation notes worth keeping:
- at-most-once dispatch is now a unique index rather than INSERT OR IGNORE.
Only the unique-violation maps to ErrAlreadyDispatched; any other save
error is returned, because treating them all as "already recorded" would
turn the ledger into a silent at-least-once dispatcher.
- captures store received_at themselves at nanosecond precision in a
fixed-width layout. PocketBase autodates are millisecond and record ids
are random, so same-millisecond captures would otherwise order
arbitrarily; the old store got insertion order free from autoincrement.
- ListUndispatchedCaptures is raw SQL: the anti-join is a subquery and
PocketBase's filter DSL is not SQL. A read fires no hooks either way.
Adds tool_calls, which had no persistence at all: tool calls only ever reached
the on-disk task log, readable as text but never queryable or watchable.
Nothing writes it yet.
The binding secret cipher moves with the bindings it protects.
139 lines
6.4 KiB
Go
139 lines
6.4 KiB
Go
// Package task is the task-execution vocabulary of the workflow domain:
|
|
// the Task record, its lifecycle statuses, and the narrow Store contract
|
|
// workflow stages call mid-run. It split out of package workflow
|
|
// (archie-core-8cda.5.6) so the UI process can hold the vocabulary without
|
|
// linking the pipeline engine there -- which drags in agentexec, skill and
|
|
// tools. package workflow keeps aliases, so daemon-side callers are
|
|
// unaffected.
|
|
package task
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
"github.com/samcharles93/archie-core/internal/events"
|
|
"github.com/samcharles93/archie-core/internal/taskstate"
|
|
)
|
|
|
|
// Task lifecycle statuses. Workflows move tasks between them; the
|
|
// daemon owns queued→running claims and crash recovery.
|
|
const (
|
|
// Defined in internal/taskstate so the dashboard, chat and the store
|
|
// share one vocabulary. These names are kept as the workflow domain's
|
|
// public spelling; the values live in one place.
|
|
StatusQueued = taskstate.Queued
|
|
StatusRunning = taskstate.Running
|
|
StatusWaitingHuman = taskstate.WaitingHuman
|
|
StatusPROpen = taskstate.PROpen
|
|
StatusMerged = taskstate.Merged
|
|
StatusParked = taskstate.Parked
|
|
StatusDead = taskstate.Dead
|
|
StatusRejected = taskstate.Rejected
|
|
StatusClosedWontDo = taskstate.Declined
|
|
)
|
|
|
|
// Task is the task-execution record the workflow domain operates on.
|
|
// internal/store persists this type (persistence -> domain).
|
|
type Task struct {
|
|
ID int64 `json:"id"`
|
|
Owner string `json:"owner"`
|
|
Repo string `json:"repo"`
|
|
IssueNumber int `json:"issue_number"`
|
|
Title string `json:"title"`
|
|
Body string `json:"body"`
|
|
Labels string `json:"labels"` // comma-separated, as seen at enqueue time
|
|
Status string `json:"status"`
|
|
Workflow string `json:"workflow"`
|
|
// WorkflowDefinitionVersion and WorkflowDefinitionDigest pin the exact
|
|
// database definition selected for this execution. WorkflowDefinitionYAML
|
|
// is the immutable worker handoff; retries reuse it instead of re-reading
|
|
// the active control-plane resource.
|
|
WorkflowDefinitionVersion int64 `json:"workflow_definition_version"`
|
|
WorkflowDefinitionDigest string `json:"workflow_definition_digest"`
|
|
WorkflowDefinitionYAML string `json:"workflow_definition_yaml"`
|
|
Stage string `json:"stage"`
|
|
Branch string `json:"branch"`
|
|
Plan string `json:"plan"`
|
|
Notes string `json:"notes"`
|
|
PRNumber int `json:"pr_number"`
|
|
TokensUsed int `json:"tokens_used"`
|
|
Iterations int `json:"iterations"`
|
|
Attempt int `json:"attempt"`
|
|
ParkReason string `json:"park_reason"`
|
|
// RetryCount tracks how many times a parked task has been retried
|
|
// (parking-to-queued transitions). When it reaches the configured
|
|
// max_retries the daemon moves the task to StatusDead.
|
|
RetryCount int `json:"retry_count"`
|
|
// WatchCommentID: replies to the issue after this comment are the
|
|
// human input a waiting_human task is blocked on.
|
|
WatchCommentID int64 `json:"watch_comment_id"`
|
|
// Source is "forge" (default; a real forge issue backs this task) or
|
|
// "chat" (created via /spawn with no forge issue). Workflow stages
|
|
// and daemon reconciliation must skip forge-only operations (issue
|
|
// labels, comments, replies) for chat-sourced tasks; IssueNumber on
|
|
// a chat task is a synthetic value, not a real forge issue.
|
|
Source string `json:"source"`
|
|
// Identity is the archie identity that owns this task (chat-spawned
|
|
// tasks only; empty for forge-sourced tasks and single-identity
|
|
// deployments). Used to scope /approve and /cancel authorization so
|
|
// one identity cannot control another's chat-spawned tasks.
|
|
Identity string `json:"identity"`
|
|
// BindingID and BindingVersion are stamped when a task was created
|
|
// from a playbook binding dispatch (t2db.4 Phase B). They record
|
|
// provenance: which binding fired this task and at what version, so
|
|
// later edits to the binding cannot silently rewrite history.
|
|
BindingID string `json:"binding_id"`
|
|
BindingVersion int `json:"binding_version"`
|
|
// ReviewPayload is the JSON-encoded review unit (the forge review's
|
|
// actionable comments) the remediate workflow's current run must
|
|
// address. The daemon's reaction consumer injects it before queuing a
|
|
// remediation run, so the run is recoverable from the task record
|
|
// itself rather than only from a prompt (docs/prds/pr-review-remediation.md
|
|
// decision 4). Empty outside a remediation run. RetryCount doubles as
|
|
// the remediation round counter for this same task, bounded by the
|
|
// repo's existing max_retries (decision 5's round cap).
|
|
ReviewPayload string `json:"review_payload"`
|
|
// CreatedAt and UpdatedAt are the SQLite row timestamps, exposed so
|
|
// callers can show a task's age and last activity. They are written by
|
|
// column defaults and the UPDATE statements, never by the caller.
|
|
CreatedAt time.Time `json:"created_at"`
|
|
UpdatedAt time.Time `json:"updated_at"`
|
|
}
|
|
|
|
// SourceForge and SourceChat are the valid values for Task.Source.
|
|
// Legacy rows and forge-polled tasks have Source == SourceForge (the
|
|
// zero value defaults there via the SQLite column default).
|
|
const (
|
|
SourceForge = "forge"
|
|
SourceChat = "chat"
|
|
)
|
|
|
|
// IsForgeBacked reports whether t corresponds to a real forge issue.
|
|
// Chat-spawned tasks (Source == SourceChat) have a synthetic
|
|
// IssueNumber and must not be used in forge label/comment/reply calls.
|
|
func (t Task) IsForgeBacked() bool {
|
|
return t.Source != SourceChat
|
|
}
|
|
|
|
// Store is the narrow, consumer-owned subset of the State Store contract
|
|
// that workflow stages call mid-run. *store.Store and staterpc.Client
|
|
// satisfy it; this is the interface archie-agent uses over the gRPC State
|
|
// Store contract. It supersedes store.WorkflowStore.
|
|
type Store interface {
|
|
Update(ctx context.Context, t *Task) error
|
|
Transition(ctx context.Context, taskID int64, from, to, detail string) error
|
|
InsertEvent(ctx context.Context, e events.Event) (int64, error)
|
|
}
|
|
|
|
// Definition is the operator-safe snapshot of an executable workflow. It
|
|
// contains only identity and stage order, never executable function values.
|
|
// It lives with the task vocabulary (not with the engine in package
|
|
// workflow) for the same reason this package exists: dashboards render
|
|
// Definitions without linking the engine.
|
|
type Definition struct {
|
|
ID string `json:"id"`
|
|
Name string `json:"name"`
|
|
Origin string `json:"origin"`
|
|
Enabled bool `json:"enabled"`
|
|
}
|