binding.Binding.Secret was persisted as plaintext in the bindings.secret column, so anyone with the SQLite file saw sender-side HMAC secrets. Seal it with AES-256-GCM transparently inside the store: encrypt-on-write, decrypt-on-read. - cipher: AES-256-GCM, 12-byte random nonce, SHA-256-normalised 32-byte key resolved through the secret registry ([bindings].encryption_key). - envelope 'arcie-binding:v1:<fingerprint>:<b64(nonce||ct||tag)>' so a future cipher/KDF change is a version bump and old rows stay readable. - rotation via previous_encryption_keys; key identity is the material's SHA-256 fingerprint embedded in each row. - legacy plaintext rows written before a key was configured stay readable; encryption is not retroactive. - nil cipher (no key configured) preserves the pre-t2db.7 plaintext path. Deferred: captured_events.body redaction upgrade (separate concern, see docs/prds/binding-secret-encryption.md). Refs archie-core-t2db.7
89 lines
3.2 KiB
Go
89 lines
3.2 KiB
Go
package config
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/samcharles93/archie-core/internal/secret"
|
|
)
|
|
|
|
// TestConfigCloneDeepCopiesReferenceFields pins that Clone returns a
|
|
// value sharing no memory with the original: mutating the clone's maps
|
|
// and slices must not touch the original. A shallow copy here would
|
|
// silently let a failed overlay decode mutate the published snapshot.
|
|
func TestConfigCloneDeepCopiesReferenceFields(t *testing.T) {
|
|
enabled := true
|
|
orig := Config{
|
|
Models: map[string]string{"builder": "m"},
|
|
ModelLimits: map[string]ModelLimits{"m": {ContextWindow: 128_000}},
|
|
Repos: []Repo{{Gate: [][]string{{"task", "check"}}, Protect: []string{"p"}}},
|
|
Identities: []IdentityConfig{{
|
|
Models: map[string]string{"planner": "m2"},
|
|
Repos: []Repo{{Gate: [][]string{{"go", "vet"}}}},
|
|
}},
|
|
Dispatch: Dispatch{Labels: map[string]string{"q": "archie:q"}},
|
|
Tools: ToolsConfig{
|
|
MCPServers: []MCPServer{{Headers: map[string]string{"A": "b"}, Args: []string{"x"}}},
|
|
WebFetch: WebFetchConfig{Enabled: &enabled},
|
|
},
|
|
Memory: MemoryConfig{ProviderConfig: map[string]string{"k": "v"}},
|
|
Chat: ChatConfig{Telegram: TelegramConfig{AllowedUserIDs: []int64{1}}},
|
|
LegacyAgent: LegacyAgent{Env: []string{"HOME"}},
|
|
Extra: map[string]any{"custom": 1},
|
|
Bindings: BindingsConfig{PreviousEncryptionKeys: []secret.SecretRef{{Engine: "env", Key: "K0"}}},
|
|
}
|
|
|
|
got := orig.Clone()
|
|
got.Models["builder"] = "changed"
|
|
got.ModelLimits["m"] = ModelLimits{ContextWindow: 1}
|
|
got.Repos[0].Gate[0][0] = "changed"
|
|
got.Repos[0].Protect[0] = "changed"
|
|
got.Identities[0].Models["planner"] = "changed"
|
|
got.Identities[0].Repos[0].Gate[0][0] = "changed"
|
|
got.Dispatch.Labels["q"] = "changed"
|
|
got.Tools.MCPServers[0].Headers["A"] = "changed"
|
|
got.Tools.MCPServers[0].Args[0] = "changed"
|
|
got.Memory.ProviderConfig["k"] = "changed"
|
|
got.Chat.Telegram.AllowedUserIDs[0] = 99
|
|
got.LegacyAgent.Env[0] = "changed"
|
|
got.Extra["custom"] = 2
|
|
got.Bindings.PreviousEncryptionKeys[0] = secret.SecretRef{Engine: "env", Key: "changed"}
|
|
*got.Tools.WebFetch.Enabled = false
|
|
|
|
if orig.Models["builder"] != "m" {
|
|
t.Error("Models map is shared")
|
|
}
|
|
if orig.ModelLimits["m"].ContextWindow != 128_000 {
|
|
t.Error("ModelLimits map is shared")
|
|
}
|
|
if orig.Repos[0].Gate[0][0] != "task" || orig.Repos[0].Protect[0] != "p" {
|
|
t.Error("Repo nested slices are shared")
|
|
}
|
|
if orig.Identities[0].Models["planner"] != "m2" || orig.Identities[0].Repos[0].Gate[0][0] != "go" {
|
|
t.Error("Identity nested fields are shared")
|
|
}
|
|
if orig.Dispatch.Labels["q"] != "archie:q" {
|
|
t.Error("Dispatch.Labels map is shared")
|
|
}
|
|
if orig.Tools.MCPServers[0].Headers["A"] != "b" || orig.Tools.MCPServers[0].Args[0] != "x" {
|
|
t.Error("MCP server fields are shared")
|
|
}
|
|
if orig.Memory.ProviderConfig["k"] != "v" {
|
|
t.Error("Memory.ProviderConfig is shared")
|
|
}
|
|
if orig.Chat.Telegram.AllowedUserIDs[0] != 1 {
|
|
t.Error("Telegram.AllowedUserIDs is shared")
|
|
}
|
|
if orig.LegacyAgent.Env[0] != "HOME" {
|
|
t.Error("Agent.Env is shared")
|
|
}
|
|
if orig.Extra["custom"] != 1 {
|
|
t.Error("Extra map is shared")
|
|
}
|
|
if orig.Bindings.PreviousEncryptionKeys[0].Key != "K0" {
|
|
t.Error("Bindings.PreviousEncryptionKeys is shared")
|
|
}
|
|
if !*orig.Tools.WebFetch.Enabled {
|
|
t.Error("WebFetch.Enabled pointer is shared")
|
|
}
|
|
}
|