dependencies-and-contracts.md rule 1 says domains must not import
internal/infrastructure. internal/daemon and internal/agentexec both did,
and for exactly the thing the doc carves out: "internal/eventbus is an
approved shared application contract ... it MUST remain broker-neutral."
The Publisher/Consumer/Requester interfaces existed but lived inside the
NATS package, so a caller could depend on the behaviour yet still had to
import the implementation to name it. They now live in internal/eventbus,
and nats.Client asserts against eventbus.Bus.
The larger violation was ownership of meaning. The doc says "message schemas
stay with their owning domains; the event bus transports messages, it does
not own their meaning." The bus exported TaskEnvelope and a PublishTask
method, so the transport knew what a unit of work was, and it exported the
archie.agent.* subject helpers, so it also owned the agent protocol.
- TaskEnvelope, its routing Kind, the label vocabulary and the task
subjects move to internal/domain/workintake, which encodes and decodes
its own bytes. This starts internal/domain/ per organisation.md.
- The agent request/response/system subjects move to internal/agentexec,
which defines what those messages mean.
- internal/workflow keeps only the kind-to-registry mapping; the label
table stays single and lives with the domain that reads forge issues.
- The bus now carries opaque payloads on plain-string subjects.
Consumers declare the smallest interface they need rather than taking the
whole Bus: daemon.TaskBus is publish-unique/fetch/request, agentexec.
RequestBus is publish-request/reply-inbox, and archie-agent's stageBus is
fetch/respond. None can reach what it does not use.
Two defects this surfaced:
- archie-agent declared its own JetStream stream with a second copy of the
name, subjects, retention, dedup window, MaxDeliver and TTLs that
nats.Connect already sets -- two definitions of one stream, free to
diverge. Config now takes Subjects and FilterSubject from composition,
which is what let the agent use the shared client and delete its
hand-rolled setup.
- Replying to a request needs core NATS, not the JetStream publish path:
a reply inbox is ephemeral and belongs to no stream, so a durable
publish to it fails. The old code hid this by using the raw connection.
The contract now distinguishes Respond from Publish. The agentexec
round-trip test caught it after I had made the same mistake in
archie-agent.
Also translated the SDK's ErrNoResponders into eventbus.ErrNoResponders, so
the daemon's taskrun retry no longer imports the NATS SDK to name a
transient condition. The SDK is now confined to the nats package, the *rpc
packages (themselves NATS infrastructure), and cmd/*.
The agentexec test fake previously hand-rolled a JetStream consumer; it now
drains the client's own consumer, which is both closer to production and
avoids conflicting consumers on a work-queue stream.
Verified: go build, go vet, gofmt clean; full test suite passes.
34 lines
1.2 KiB
Go
34 lines
1.2 KiB
Go
package workflow
|
|
|
|
import "github.com/samcharles93/archie-core/internal/domain/workintake"
|
|
|
|
// kindWorkflows names the registry entry each intake kind prefers. Bootstrap
|
|
// exercises the full pipeline deterministically (no LLM spend) -- invites,
|
|
// clone, push, PR, labels.
|
|
//
|
|
// The label vocabulary itself belongs to workintake, which is what reads
|
|
// forge issues. This package owns only the choice of workflow for a kind:
|
|
// keeping both here meant the transport and the registry each had their own
|
|
// copy of the label table.
|
|
var kindWorkflows = map[workintake.Kind]string{
|
|
workintake.KindBug: "tdd",
|
|
workintake.KindFeature: "feasibility",
|
|
workintake.KindBootstrap: "bootstrap",
|
|
}
|
|
|
|
// workflowForLabels returns the registered workflow name for a task's
|
|
// labels, trying each recognised kind in label order so a "bug,feature" task
|
|
// still reaches feasibility when no tdd workflow is registered.
|
|
func workflowForLabels(reg Registry, labels string) (Workflow, bool) {
|
|
for _, kind := range workintake.KindsForLabels(workintake.SplitLabels(labels)) {
|
|
name, ok := kindWorkflows[kind]
|
|
if !ok {
|
|
continue
|
|
}
|
|
if wf, ok := reg[name]; ok {
|
|
return wf, true
|
|
}
|
|
}
|
|
return Workflow{}, false
|
|
}
|