128 lines
4.4 KiB
Go
128 lines
4.4 KiB
Go
package postgres
|
|
|
|
import (
|
|
"encoding/json"
|
|
"testing"
|
|
|
|
"github.com/samcharles93/archie-core/internal/infrastructure/postgres/postgresdb"
|
|
)
|
|
|
|
const testJWT = "eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJzYW0ifQ.c2lnbmF0dXJl"
|
|
|
|
// TestRedactedFields pins the read-time redaction policy: a value under a
|
|
// sensitive field name, or one shaped like an unambiguous secret, never
|
|
// leaves the adapter; null and absent sides survive; and undecodable JSON
|
|
// drops the list instead of passing it through.
|
|
func TestRedactedFields(t *testing.T) {
|
|
t.Parallel()
|
|
tests := []struct {
|
|
name string
|
|
encoded string
|
|
want map[string][2]string
|
|
}{
|
|
{
|
|
name: "secret-reference field is redacted on both sides",
|
|
encoded: `{"webhook_secret":{"old":"vault://old","new":"vault://new"}}`,
|
|
want: map[string][2]string{"webhook_secret": {`"[redacted]"`, `"[redacted]"`}},
|
|
},
|
|
{
|
|
name: "nested token under a benign field name is redacted",
|
|
encoded: `{"settings":{"old":{"bot_token":"abc"},"new":{"bot_token":"def"}}}`,
|
|
want: map[string][2]string{"settings": {`{"bot_token":"[redacted]"}`, `{"bot_token":"[redacted]"}`}},
|
|
},
|
|
{
|
|
name: "jwt under a benign field name is redacted by shape",
|
|
encoded: `{"webhook":{"old":"` + testJWT + `","new":"` + testJWT + `"}}`,
|
|
want: map[string][2]string{"webhook": {`"[redacted]"`, `"[redacted]"`}},
|
|
},
|
|
{
|
|
name: "jwt embedded in a JSON string value is redacted",
|
|
encoded: `{"error":{"old":"auth failed for ` + testJWT + `","new":"ok"}}`,
|
|
want: map[string][2]string{"error": {`"[redacted]"`, `"ok"`}},
|
|
},
|
|
{
|
|
name: "pem private key is redacted by shape",
|
|
encoded: `{"certificate":{"old":"-----BEGIN PRIVATE KEY-----\nsecret\n-----END PRIVATE KEY-----","new":"kept"}}`,
|
|
want: map[string][2]string{"certificate": {`"[redacted]"`, `"kept"`}},
|
|
},
|
|
{
|
|
name: "whole-document array row is redacted recursively",
|
|
encoded: `{"":{"old":[{"name":"visible","password":"hidden"}],"new":null}}`,
|
|
want: map[string][2]string{"": {`[{"name":"visible","password":"[redacted]"}]`, `null`}},
|
|
},
|
|
{
|
|
name: "null and absent sides survive",
|
|
encoded: `{"new_field":{"old":null,"new":"on"}}`,
|
|
want: map[string][2]string{"new_field": {`null`, `"on"`}},
|
|
},
|
|
{
|
|
name: "non-secret values are unchanged",
|
|
encoded: `{"enabled":{"old":false,"new":true}}`,
|
|
want: map[string][2]string{"enabled": {`false`, `true`}},
|
|
},
|
|
{
|
|
name: "malformed json drops the list",
|
|
encoded: `{"enabled":`,
|
|
want: nil,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
fields := redactedFields([]byte(tt.encoded))
|
|
if tt.want == nil {
|
|
if fields != nil {
|
|
t.Fatalf("redactedFields() = %+v, want nil", fields)
|
|
}
|
|
return
|
|
}
|
|
if len(fields) != len(tt.want) {
|
|
t.Fatalf("redactedFields() = %+v, want %d fields", fields, len(tt.want))
|
|
}
|
|
for _, field := range fields {
|
|
want, ok := tt.want[field.Name]
|
|
if !ok {
|
|
t.Fatalf("unexpected field %q", field.Name)
|
|
}
|
|
if string(field.Old) != want[0] || string(field.New) != want[1] {
|
|
t.Fatalf("field %q = %s/%s, want %s/%s", field.Name, field.Old, field.New, want[0], want[1])
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestRedactedData(t *testing.T) {
|
|
t.Parallel()
|
|
redacted := redactedData(`{"token":"abc","visible":true}`)
|
|
var value map[string]any
|
|
if err := json.Unmarshal(redacted, &value); err != nil {
|
|
t.Fatalf("redactedData() = %q, not JSON: %v", redacted, err)
|
|
}
|
|
if value["token"] != "[redacted]" || value["visible"] != true {
|
|
t.Fatalf("redactedData() = %v, want the token redacted and visible kept", value)
|
|
}
|
|
embedded := redactedData(`{"error":"auth failed for ` + testJWT + `"}`)
|
|
var nested map[string]any
|
|
if err := json.Unmarshal(embedded, &nested); err != nil {
|
|
t.Fatalf("redactedData(embedded jwt) = %q, not JSON: %v", embedded, err)
|
|
}
|
|
if nested["error"] != "[redacted]" {
|
|
t.Fatalf("redactedData(embedded jwt) = %v, want the whole value redacted", nested)
|
|
}
|
|
if got := redactedData(`{"broken":`); got != nil {
|
|
t.Fatalf("redactedData(malformed) = %q, want nil", got)
|
|
}
|
|
if got := redactedData("{}"); got != nil {
|
|
t.Fatalf("redactedData(empty object) = %q, want nil", got)
|
|
}
|
|
}
|
|
|
|
func TestAuditEntryRedactsDetail(t *testing.T) {
|
|
t.Parallel()
|
|
entry := auditEntry(postgresdb.ListAuditRow{Detail: "issued " + testJWT})
|
|
if entry.Detail != "[redacted]" {
|
|
t.Fatalf("entry detail = %q, want the whole value redacted", entry.Detail)
|
|
}
|
|
}
|