Files
archie/proto
sam 33e915c5be feat(daemon): wire the review-reaction consumer to remediate runs
The remediate workflow was registered but had no trigger: the reaction
stream was provisioned, the envelope, resolver and owned-PR lookup all
landed, yet nothing consumed the stream (pr-review-remediation.md's
sequencing left the consumer for this step). The daemon now drains the
reaction stream each cycle, before the task drain, so a reaction can be
claimed in the same pass that carried it.

Per decision 3, the store's owned-PR lookup is the authorization
boundary: an unmatched, merged or closed PR drops with a counter, and a
public reaction can never start an agent against a foreign repository.
Per decision 5, a review is the unit of remediation -- its comment
events are appended to the unit while it is queued and dropped once the
run is claimed (the round cap bounds the exchange); a standalone comment
is its own unit of one; approved reviews never remediate; and archie's
own comments, matched on the owning identity's bot user, are excluded so
its replies cannot retrigger it.

The guarded BeginRemediation/UpdateReviewPayload store methods are the
dedup: the pr_open -> queued transition carries the review unit in the
same write, so re-delivered reactions fail the status guard instead of
starting a second round. Both are new StateStoreService RPCs following
the Requeue shape, covered by the local/grpc conformance battery.
2026-09-23 12:08:44 +10:00
..

Service wire contracts

Each canonical service owns proto/<service>/v1/*.proto in this single Buf module. The service directory matches its registry, DNS and chart name. Breaking changes require a new v2, v3, etc. directory; retain published versions for existing consumers. Buf's FILE rules compare against local main. The first introduction skips that comparison only when main has no Buf config.

Run task proto:install once to install the pinned Buf and Go plugins, with $(go env GOPATH)/bin on PATH. Run task proto:generate after editing a schema. Managed mode sets Go package paths; do not set go_package in the source. Generated grpc-go and protobuf files belong in internal/contracts/<service>/v1/ and must be committed, including formatter output. This directory is generated in full; handwritten adapters belong outside it.

task proto:lint checks lint and compatibility; task proto:check regenerates and rejects differences or untracked generated files. Both run in task check and the deployment quality gate. Normal build and test commands use committed Go files and do not require Buf.

Compatibility smoke verification (2026-09-05): copied the gateway schema and gate script into a temporary Git repository, committed it on main, and ran the lint gate from a linked worktree. The unchanged schema passed. Deleting ChatService.Cancel then failed with Previously present RPC "Cancel" on service "ChatService" was deleted. This exercises the same Git-baseline comparison as the gate without modifying the working schema or real main.