archied's own build has carried a compiled-in gatewayVersion and an internal/installtype stamp since archie-core-522/2873cbb, but archie-agent's build had neither -- its Taskfile.yml and Dockerfile build steps passed no -ldflags at all, so even a daemon that wanted to verify what agent build is actually in service had nothing to check against. daemonRunningVersions said as much explicitly: the agent was left out of every verification on purpose, because nothing self-reported a real value. Every archie-agent process is task-scoped and ephemeral (spawned per task, dies after), not a long-lived process the daemon can poll on demand the way it polls Telegram's gateway. So there's no "ask the agent its version" request -- the only channel back is whatever a worker includes in the taskrun.Response it already sends on every completed task. Stamp archie-agent's build the same way archied's is (installtype, plus a new agentworker.Version()), have executeTaskRequest report both in its Response, and have the daemon record the latest observation in a new mutex-guarded AgentStatus, fed from runViaAgent on every successful response only -- never off a request that never reached an agent, or one describing a failed/parked task. daemonRunningVersions now includes the agent component once (and only once) something has actually been observed, so Report.Verify gets a real value to check future update claims against instead of omitting the component entirely. Part 1/3 of archie-core-1786751948782-3-837a8fd0 point 4. Closes archie-core-1786751948782-3-837a8fd0.1.
29 lines
846 B
Go
29 lines
846 B
Go
package agentworker
|
|
|
|
import "testing"
|
|
|
|
// TestVersionReportsDevWhenUnstamped guards the unstamped-build fallback:
|
|
// an empty ldflags value (e.g. a local `go build`, or a release pipeline
|
|
// that forgot -X for this package) must read as "dev", the same
|
|
// placeholder cmd/archied's own version vars use, not as an empty string
|
|
// that would silently sail through daemon.AgentStatus as a real version.
|
|
func TestVersionReportsDevWhenUnstamped(t *testing.T) {
|
|
orig := version
|
|
t.Cleanup(func() { version = orig })
|
|
version = ""
|
|
|
|
if got := Version(); got != "dev" {
|
|
t.Errorf("Version() = %q, want %q", got, "dev")
|
|
}
|
|
}
|
|
|
|
func TestVersionReportsStampedValue(t *testing.T) {
|
|
orig := version
|
|
t.Cleanup(func() { version = orig })
|
|
version = "1.9.11"
|
|
|
|
if got := Version(); got != "1.9.11" {
|
|
t.Errorf("Version() = %q, want %q", got, "1.9.11")
|
|
}
|
|
}
|