Files
archie/internal/domain/sampling/sampling_test.go
T
sam 268283eb16 chore(curator): add embedding client and sampler interface prerequisites (#752)
* feat(curator): add embedding client and sampler wave-1 prerequisites

Bead archie-core-1786637500752-415-434e5bb9 (GitHub #436) was closed with
no linked PR/commits, and the surprisal-sampling bead
archie-core-1786637500776-416-600a66e5 (GitHub #437) found none of its
stated prerequisites -- an embedding client, a Sampler interface, or the
four wave-1 cheap sampling strategies -- actually exist. This builds them:

- internal/domain/embedding + internal/infrastructure/embedding: a narrow
  typed embedding client, config-driven via a providers table + a role in
  [models], mirroring the existing chat model role convention. Degrades to
  capability-unavailable (never fails startup or a call) for a missing
  role, unknown provider, unsupported class, or unresolved credential.
  Wired as an optional capability in bootstrap.go's setupEmbeddings.
- internal/domain/sampling: the Sampler interface plus recency, random,
  all, and staleness-proxy strategies, per docs/prds/curator-sampler-wave1.md.
  Deterministic given fixed inputs, matching GitHub #437's stated
  acceptance criterion for the embedding-backed strategy it will add
  behind this same interface (not part of this change).

Table-driven tests throughout; httptest for the embedding client, no live
service. No curator wiring yet -- nothing consumes either capability in
this change.

* no-mistakes(document): docs(architecture): mark curator sampling prereqs as landed
2026-09-05 22:53:08 +10:00

49 lines
1.4 KiB
Go

package sampling
import (
"context"
"testing"
"time"
)
// assertIDs checks got's IDs match want, in order.
func assertIDs(t *testing.T, got []Candidate, want []string) {
t.Helper()
if len(got) != len(want) {
t.Fatalf("got %d candidates, want %d (%v)", len(got), len(want), want)
}
for i, c := range got {
if c.ID != want[i] {
t.Fatalf("candidate[%d].ID = %q, want %q", i, c.ID, want[i])
}
}
}
// assertInputNotMutated builds a candidate slice, samples it through s,
// then verifies the original slice's order and values are untouched --
// the non-mutation guarantee every Sampler implementation must uphold.
func assertInputNotMutated(t *testing.T, s Sampler) {
t.Helper()
base := time.Date(2026, 1, 1, 0, 0, 0, 0, time.UTC)
candidates := []Candidate{
{ID: "a", At: base.Add(3 * time.Hour)},
{ID: "b", At: base.Add(time.Hour)},
{ID: "c", At: base.Add(2 * time.Hour)},
{ID: "d", At: base},
}
original := append([]Candidate(nil), candidates...)
if _, err := s.Sample(context.Background(), candidates, Request{Cap: 2, Seed: 7}); err != nil {
t.Fatalf("Sample() error = %v", err)
}
if len(candidates) != len(original) {
t.Fatalf("input slice length changed: got %d, want %d", len(candidates), len(original))
}
for i := range candidates {
if candidates[i].ID != original[i].ID || !candidates[i].At.Equal(original[i].At) {
t.Fatalf("input slice mutated at index %d: got %+v, want %+v", i, candidates[i], original[i])
}
}
}