archied's own build has carried a compiled-in gatewayVersion and an internal/installtype stamp since archie-core-522/2873cbb, but archie-agent's build had neither -- its Taskfile.yml and Dockerfile build steps passed no -ldflags at all, so even a daemon that wanted to verify what agent build is actually in service had nothing to check against. daemonRunningVersions said as much explicitly: the agent was left out of every verification on purpose, because nothing self-reported a real value. Every archie-agent process is task-scoped and ephemeral (spawned per task, dies after), not a long-lived process the daemon can poll on demand the way it polls Telegram's gateway. So there's no "ask the agent its version" request -- the only channel back is whatever a worker includes in the taskrun.Response it already sends on every completed task. Stamp archie-agent's build the same way archied's is (installtype, plus a new agentworker.Version()), have executeTaskRequest report both in its Response, and have the daemon record the latest observation in a new mutex-guarded AgentStatus, fed from runViaAgent on every successful response only -- never off a request that never reached an agent, or one describing a failed/parked task. daemonRunningVersions now includes the agent component once (and only once) something has actually been observed, so Report.Verify gets a real value to check future update claims against instead of omitting the component entirely. Part 1/3 of archie-core-1786751948782-3-837a8fd0 point 4. Closes archie-core-1786751948782-3-837a8fd0.1.
71 lines
3.1 KiB
Go
71 lines
3.1 KiB
Go
// Package taskrun defines the wire format for handing an entire task off
|
|
// from archied to archie-agent in one NATS round trip, replacing the
|
|
// per-stage AgentRequestMessage protocol for the sandboxed container path.
|
|
// archie-agent runs workflow.Route and workflow.Run itself; archied's role
|
|
// shrinks to worktree prepare, container acquire/release, and answering
|
|
// the storerpc/forgerpc/worktreerpc calls archie-agent proxies back.
|
|
package taskrun
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/samcharles93/archie-core/internal/agentexec"
|
|
"github.com/samcharles93/archie-core/internal/config"
|
|
"github.com/samcharles93/archie-core/internal/store"
|
|
)
|
|
|
|
// Request carries everything archie-agent needs to run a task's entire
|
|
// workflow itself: the task row (already claimed by archied), the repo's
|
|
// gate/ecosystem config, a non-secret config snapshot, and LLM provider
|
|
// config (API keys are injected into the container's environment
|
|
// separately -- Providers only carries class/env-var-name/base-URL).
|
|
type Request struct {
|
|
Task *store.Task `json:"task"`
|
|
Repo config.Repo `json:"repo"`
|
|
Cfg config.TaskConfig `json:"cfg"`
|
|
Providers map[string]agentexec.Provider `json:"providers"`
|
|
// MCPServers carries MCP server definitions so the agent can construct
|
|
// transports, discover tools, and register them locally. Absent/empty
|
|
// means no MCP servers (backward compatible).
|
|
MCPServers []config.MCPServer `json:"mcp_servers,omitempty"`
|
|
// WorktreeGrant is an opaque, per-dispatch capability authorizing the
|
|
// daemon to publish this task's already-prepared branch. Repository
|
|
// coordinates never cross back from the sandbox as authority.
|
|
WorktreeGrant string `json:"worktree_grant,omitempty"`
|
|
}
|
|
|
|
// Validate rejects a full-task request that cannot be correlated to a real
|
|
// task. Transport-specific subject correlation is enforced by the adapter.
|
|
func (r Request) Validate() error {
|
|
if r.Task == nil {
|
|
return errors.New("task is required")
|
|
}
|
|
if r.Task.ID <= 0 {
|
|
return fmt.Errorf("task ID must be positive, got %d", r.Task.ID)
|
|
}
|
|
if r.WorktreeGrant == "" {
|
|
return errors.New("worktree grant is required")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Response reports the task's final state after archie-agent runs its
|
|
// workflow. Task carries the last-known field values for logging; the
|
|
// authoritative state already landed in archied's store via storerpc
|
|
// calls made during the run.
|
|
type Response struct {
|
|
Task *store.Task `json:"task"`
|
|
Status string `json:"status"`
|
|
Error string `json:"error,omitempty"`
|
|
// AgentVersion and AgentInstallType report the build of archie-agent
|
|
// that actually ran this task -- self-reported by the worker, not the
|
|
// version archied's release pipeline expected to be running. Every
|
|
// archie-agent process is task-scoped and ephemeral, so this response
|
|
// is the only channel the daemon has to observe what is really in
|
|
// service; see daemon.AgentStatus. Empty AgentVersion means an
|
|
// unstamped build ("dev") or a worker older than this field.
|
|
AgentVersion string `json:"agent_version,omitempty"`
|
|
AgentInstallType string `json:"agent_install_type,omitempty"`
|
|
}
|