Files
archie/internal/taskrun/taskrun.go
T
sam 1e5c742cca fix(daemon): carry kind/label routing bindings to the process that routes
An operator's kind/label -> workflow overrides were decoded, validated and
installed into the DAEMON's package-level state via
workflow.SetKindWorkflows/SetLabelWorkflows -- but workflow.Route's only
production caller is app/agentworker/task_execution.go, in the separate
archie-agent process. The bindings never crossed the boundary, so every
configured override was silently ignored and routing always fell back to the
built-in defaults (bug -> tdd, feature -> feasibility, bootstrap -> bootstrap).

Carry the resolved bindings on taskrun.Request, mirroring how MCPServers already
crosses this boundary, and apply them in the worker before Route is called.
Resolved values are carried rather than file paths, so the worker does not need
the routing files to be readable in its sandbox. nil still means "use the
built-in defaults", so this is backward compatible for any request built by an
older daemon.

routeTask is a named seam for that install-then-route step. It mutates
package-level routing state, which is sound here because each archie-agent
process is task-scoped and ephemeral; if the worker ever served more than one
task that assumption would need revisiting.

Tests are mutation-verified: removing either the two Set calls in routeTask or
the two request fields in runViaAgent reproduces the exact assertion failures
the lane observed red-first, so neither test is vacuous.

Found by an adversarial package sweep (temp tracker: workflow-engine-1,
.local/issue-tracker/).
2026-09-15 02:13:33 +10:00

79 lines
3.7 KiB
Go

// Package taskrun defines the wire format for handing an entire task off
// from archied to archie-agent in one NATS round trip.
// archie-agent runs workflow.Route and workflow.Run itself; archied's role
// shrinks to worktree prepare, container acquire/release, and answering
// the forgerpc/worktreerpc calls archie-agent proxies back. Agent store
// calls go over gRPC to the State Store, not through this NATS handoff.
package taskrun
import (
"errors"
"fmt"
"github.com/samcharles93/archie-core/internal/agentexec"
"github.com/samcharles93/archie-core/internal/config"
"github.com/samcharles93/archie-core/internal/domain/workflow"
)
// Request carries everything archie-agent needs to run a task's entire
// workflow itself: the task row (already claimed by archied), the repo's
// gate/ecosystem config, a non-secret config snapshot, and LLM provider
// config (API keys are injected into the container's environment
// separately -- Providers only carries class/env-var-name/base-URL).
type Request struct {
Task *workflow.Task `json:"task"`
Repo config.Repo `json:"repo"`
Cfg config.TaskConfig `json:"cfg"`
Providers map[string]agentexec.Provider `json:"providers"`
// MCPServers carries MCP server definitions so the agent can construct
// transports, discover tools, and register them locally. Absent/empty
// means no MCP servers (backward compatible).
MCPServers []config.MCPServer `json:"mcp_servers,omitempty"`
// KindWorkflows and LabelWorkflows carry the resolved kind/label ->
// workflow-name bindings the daemon loaded from WorkflowRoutingFile,
// WorkflowLabelsFile and PlaybookDirs. workflow.Route runs in the
// archie-agent process, not the daemon, so these resolved values must
// cross the process boundary here; nil means use the built-in defaults
// (backward compatible).
KindWorkflows workflow.KindWorkflows `json:"kind_workflows,omitempty"`
LabelWorkflows workflow.LabelWorkflows `json:"label_workflows,omitempty"`
// WorktreeGrant is an opaque, per-dispatch capability authorizing the
// daemon to publish this task's already-prepared branch. Repository
// coordinates never cross back from the sandbox as authority.
WorktreeGrant string `json:"worktree_grant,omitempty"`
}
// Validate rejects a full-task request that cannot be correlated to a real
// task. Transport-specific subject correlation is enforced by the adapter.
func (r Request) Validate() error {
if r.Task == nil {
return errors.New("task is required")
}
if r.Task.ID <= 0 {
return fmt.Errorf("task ID must be positive, got %d", r.Task.ID)
}
if r.WorktreeGrant == "" {
return errors.New("worktree grant is required")
}
return nil
}
// Response reports the task's final state after archie-agent runs its
// workflow. Task carries the last-known field values for logging; the
// authoritative state already landed in the State Store via the agent's
// gRPC store calls made during the run.
type Response struct {
Task *workflow.Task `json:"task"`
Status string `json:"status"`
Error string `json:"error,omitempty"`
// AgentVersion and AgentInstallType report the build of archie-agent
// that actually ran this task -- self-reported by the worker, not the
// version archied's release pipeline expected to be running. Every
// archie-agent process is task-scoped and ephemeral, so this response
// is the only channel the daemon has to observe what is really in
// service; see daemon.AgentStatus. Empty AgentVersion means an
// unstamped build ("dev") or a worker older than this field.
AgentVersion string `json:"agent_version,omitempty"`
AgentInstallType string `json:"agent_install_type,omitempty"`
}