Files
archie/proto
sam 0b8014516a feat(workflow): agent-call children, call steps, and the waited-on callee sweep
Plan item 4 of docs/prds/execution-tree-state-machine.md (archie-core-1216),
plus the callee half of CancelExecution that plan item 5 deferred until the
tree could decide it.

Every agent call a stage makes records itself: AgentStage's bridge, the
baseline-fix auto-fix run, the adversarial reviewer and a workflow.call each
start a child StepExecution of kind agent or call under the stage's own step
-- TaskContext.StepID, which the engine sets before the stage body starts and
clears when it returns -- and finish it with the call's own outcome and the
tokens it accounted. A child's recording write failure parks the execution
the same way a stage's does: an agent call that ran unrecorded is the
invisibility the step table exists to end. A stage invoked outside the
engine's recorded run -- the stage unit tests -- records no child and runs
unchanged.

The call step is what makes the callee half of the PRD's Cancellation section
decidable, and this lands it: a call step closes when its callee ends, so an
open call step is a callee the caller waits on (wait:true) and a closed one
is a wait:false callee that runs on. CancelExecution reads the open call
steps before its sweep closes them and cancels each named callee through its
own CancelExecution in the caller's write's aftermath -- the callee's own
steps, its own events, its own move to the same destination, and the callee's
own wait:true callees beyond it, the depth the enqueue enforces bounding the
recursion. A callee that cannot be cancelled is reported and the caller's own
record stands.

StartStep refuses a call step whose callee is not this run's own (the
callee's call_parent_task_id must name the recording execution): a
compromised container could otherwise record a step naming a foreign
execution and cancel it. StartStepRequest gains called_execution_id (field 6;
non-breaking, the column and its named consumer already exist) and
StepStart carries it.

PRD decisions recorded here:
- The reviewer records as one agent child named "review": the Reviewer
  contract runs one subagent per review, the PRD model's review:1/review:2
  are illustrative of depth-1 children. A completed report closes it
  succeeded, a not-run review failed with the skip reason; the contract
  carries no usage, so tokens are 0.
- A failed-callee call step closes as failed with the callee's detail when
  the wait ends otherwise; the single open case is the caller itself being
  cancelled, whose CancelExecution already swept this step -- a late write
  must not pretend the wait is still the caller's business.
- A call step's callee is cancelled to the same destination the caller's
  action named (parked stays parked, closed_wont_do ends the whole chain),
  and a callee that cannot be cancelled is reported while the caller's own
  record stands either way.
- The agent child's detail is the result summary on success and the error's
  text on failure, with the call's own TokensUsed -- the PRD's only usage
  field, untracked per call for the reviewer contract.
2026-09-27 07:14:15 +10:00
..

Service wire contracts

Each canonical service owns proto/<service>/v1/*.proto in this single Buf module. The service directory matches its registry, DNS and chart name. Breaking changes require a new v2, v3, etc. directory; retain published versions for existing consumers. Buf's FILE rules compare against local main. The first introduction skips that comparison only when main has no Buf config.

Run task proto:install once to install the pinned Buf and Go plugins, with $(go env GOPATH)/bin on PATH. Run task proto:generate after editing a schema. Managed mode sets Go package paths; do not set go_package in the source. Generated grpc-go and protobuf files belong in internal/contracts/<service>/v1/ and must be committed, including formatter output. This directory is generated in full; handwritten adapters belong outside it.

task proto:lint checks lint and compatibility; task proto:check regenerates and rejects differences or untracked generated files. Both run in task check and the deployment quality gate. Normal build and test commands use committed Go files and do not require Buf.

Compatibility smoke verification (2026-09-05): copied the gateway schema and gate script into a temporary Git repository, committed it on main, and ran the lint gate from a linked worktree. The unchanged schema passed. Deleting ChatService.Cancel then failed with Previously present RPC "Cancel" on service "ChatService" was deleted. This exercises the same Git-baseline comparison as the gate without modifying the working schema or real main.