Completes the objective deletion gate for the UI Service (archie-core-8cda.5.6): go list -deps ./cmd/archie-ui now links zero banned packages -- no modernc.org/sqlite, no internal/store, gateway, channels, memory, secret, agentexec, tools, skill, yaegiutil, curator, or the workflow engine. The closure shrinks from 68 to 26 archie-core packages. Each cut is a producer-side move; no consumer-side defensive shims. - Store contracts (TaskStore family, value types, sentinels) moved from internal/store to internal/domain/storecontract -- the approved contract location per state-store-contract rev. 2d, and NOT internal/contracts: that tree is buf generate output and tools/proto.sh check deletes hand-written files there. internal/store keeps aliases; sentinel message strings are byte-identical and remain the wire contract. - Chat contracts (ChatContract, sessions, turns, streaming, commands) moved from internal/gateway to internal/domain/messaging; gateway keeps aliases. ToolCallEvent rendering helpers become gateway functions (methods cannot live on alias types). - Task vocabulary (Task, statuses, mid-run Store, Definition) split into internal/domain/workflow/task; the pipeline engine stays in package workflow with aliases, so daemon-side callers are unchanged. - overlay.DeniedKeys moved to internal/infrastructure/configuration: webui referenced the constant and that dragged the overlay SQLite store in. - webui.Server's concrete runtime handles become webui-owned view interfaces with daemon-side bootstrap adapters: channel lifecycle (internal/channels/status), MemoryStatus, CuratorStatus, and a SkillCatalog seam replacing the direct skill.DefaultRoots/CatalogRoots calls. Each degrades to an empty page when unwired. - config.SecretRef moved into internal/config (config vocabulary); internal/secret keeps an alias and Registry.Resolve absorbs the zero-value short-circuit. Docs: state-store-contract rev. 2d relocation record; ui-service-boundary deletion gate marked satisfied; ARCHITECTURE.md package map rows.
62 lines
2.9 KiB
Go
62 lines
2.9 KiB
Go
package gateway
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestToolCallEventRenderToolCallUsesCompactSafeOutput(t *testing.T) {
|
|
got := RenderToolCall(ToolCallEvent{Name: "shell", Parameters: `{"command":"{schema placeholder}"}`, Output: "line one\nline two"})
|
|
if strings.Contains(got, "schema placeholder") || strings.Contains(got, "Parameters") {
|
|
t.Fatalf("render leaked input/schema noise: %q", got)
|
|
}
|
|
if !strings.Contains(got, "line one") || strings.Contains(got, "hidden") {
|
|
t.Fatalf("short shell output should be previewed, got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestToolCallEventRenderToolCallShowsUsefulPreviewWithoutDumpingSource(t *testing.T) {
|
|
source := "package agentexec\n\nimport (\n \"context\"\n)\n\ntype AgentRequestMessage struct {\n Workflow string\n}\n"
|
|
got := RenderToolCall(ToolCallEvent{Name: "read", Output: source})
|
|
if strings.Contains(got, "type AgentRequestMessage") || strings.Contains(got, "content hidden") {
|
|
t.Fatalf("read preview should show a short lead-in, not dump or hide everything: %q", got)
|
|
}
|
|
if !strings.Contains(got, "package agentexec") {
|
|
t.Fatalf("read preview missing first useful line: %q", got)
|
|
}
|
|
|
|
listing := "/home/sam/projects/archie-core\n/home/sam/projects/archie-core/internal/gateway\n/home/sam/go/pkg/mod/github.com/samcharles93/ai-sdk@v0.1.21/prompt/prompt.go\n"
|
|
got = RenderToolCall(ToolCallEvent{Name: "find", Output: listing})
|
|
if strings.Contains(got, "listing hidden") || strings.Contains(got, "/pkg/mod/") {
|
|
t.Fatalf("find preview should show a short local path, not hide or dump module cache: %q", got)
|
|
}
|
|
if !strings.Contains(got, "/home/sam/projects/archie-core") {
|
|
t.Fatalf("find preview missing first path: %q", got)
|
|
}
|
|
}
|
|
|
|
func TestToolCallEventRenderToolCallBoundsOutputAndPreservesFailure(t *testing.T) {
|
|
got := RenderToolCall(ToolCallEvent{Name: "read", Output: strings.Repeat("x", 2000)})
|
|
if len([]rune(got)) > 520 {
|
|
t.Fatalf("render has %d runes, want bounded output", len([]rune(got)))
|
|
}
|
|
if strings.Contains(got, strings.Repeat("x", 200)) {
|
|
t.Fatalf("oversized contents were not bounded: %q", got)
|
|
}
|
|
failed := RenderToolCall(ToolCallEvent{Name: "shell", Output: "ignored", Err: "command_exit: exit status 2"})
|
|
if failed != "🔧 shell — failed\n```text\ncommand_exit: exit status 2\n```" {
|
|
t.Fatalf("failure render = %q", failed)
|
|
}
|
|
}
|
|
|
|
func TestToolCallEventFailureKeyCollapsesLegacyTurnBudget(t *testing.T) {
|
|
first := ToolCallEvent{Name: "read", Err: "tool read: turn budget exceeded (200000 chars)"}
|
|
second := ToolCallEvent{Name: "shell", Err: "tool shell: turn budget exceeded (200000 chars)"}
|
|
if FailureKey(first) == "" || FailureKey(first) != FailureKey(second) {
|
|
t.Fatalf("legacy output-limit failures should share one key: %q vs %q", FailureKey(first), FailureKey(second))
|
|
}
|
|
if RenderToolCall(first) != "🔧 tools — stopped\n```text\ntool-output limit reached (200000 chars); further results suppressed\n```" {
|
|
t.Fatalf("legacy output-limit render = %q", RenderToolCall(first))
|
|
}
|
|
}
|