Files
archie/internal/config/clone_test.go
T
sam 888c612844 fix(config): deep-copy Image.Hosted/Image.Local in Config.Clone
Clone's own doc comment promises mutating the clone cannot touch memory
shared with the original, but Image.Hosted/Image.Local were left as a
shallow map copy -- a runtime overlay or dashboard PATCH decoding into the
clone could mutate the published config's image provider maps.
2026-09-15 04:38:54 +10:00

99 lines
3.6 KiB
Go

package config
import (
"testing"
)
// TestConfigCloneDeepCopiesReferenceFields pins that Clone returns a
// value sharing no memory with the original: mutating the clone's maps
// and slices must not touch the original. A shallow copy here would
// silently let a failed overlay decode mutate the published snapshot.
func TestConfigCloneDeepCopiesReferenceFields(t *testing.T) {
enabled := true
orig := Config{
Models: map[string]string{"builder": "m"},
ModelLimits: map[string]ModelLimits{"m": {ContextWindow: 128_000}},
Repos: []Repo{{Gate: [][]string{{"task", "check"}}, Protect: []string{"p"}}},
Identities: []IdentityConfig{{
Models: map[string]string{"planner": "m2"},
Repos: []Repo{{Gate: [][]string{{"go", "vet"}}}},
}},
Dispatch: Dispatch{Labels: map[string]string{"q": "archie:q"}},
Tools: ToolsConfig{
MCPServers: []MCPServer{{Headers: map[string]string{"A": "b"}, Args: []string{"x"}}},
WebFetch: WebFetchConfig{Enabled: &enabled},
},
Memory: MemoryConfig{ProviderConfig: map[string]string{"k": "v"}},
Chat: ChatConfig{Telegram: TelegramConfig{AllowedUserIDs: []int64{1}}},
LegacyAgent: LegacyAgent{Env: []string{"HOME"}},
Extra: map[string]any{"custom": 1},
Bindings: BindingsConfig{PreviousEncryptionKeys: []SecretRef{{Engine: "env", Key: "K0"}}},
Image: ImageConfig{
Hosted: map[string]ImageHostedProvider{"openai": {Enabled: true}},
Local: map[string]ImageLocalProvider{"sdxl": {Enabled: true}},
},
}
got := orig.Clone()
got.Models["builder"] = "changed"
got.ModelLimits["m"] = ModelLimits{ContextWindow: 1}
got.Repos[0].Gate[0][0] = "changed"
got.Repos[0].Protect[0] = "changed"
got.Identities[0].Models["planner"] = "changed"
got.Identities[0].Repos[0].Gate[0][0] = "changed"
got.Dispatch.Labels["q"] = "changed"
got.Tools.MCPServers[0].Headers["A"] = "changed"
got.Tools.MCPServers[0].Args[0] = "changed"
got.Memory.ProviderConfig["k"] = "changed"
got.Chat.Telegram.AllowedUserIDs[0] = 99
got.LegacyAgent.Env[0] = "changed"
got.Extra["custom"] = 2
got.Bindings.PreviousEncryptionKeys[0] = SecretRef{Engine: "env", Key: "changed"}
*got.Tools.WebFetch.Enabled = false
got.Image.Hosted["openai"] = ImageHostedProvider{Enabled: false}
got.Image.Local["sdxl"] = ImageLocalProvider{Enabled: false}
if orig.Models["builder"] != "m" {
t.Error("Models map is shared")
}
if orig.ModelLimits["m"].ContextWindow != 128_000 {
t.Error("ModelLimits map is shared")
}
if orig.Repos[0].Gate[0][0] != "task" || orig.Repos[0].Protect[0] != "p" {
t.Error("Repo nested slices are shared")
}
if orig.Identities[0].Models["planner"] != "m2" || orig.Identities[0].Repos[0].Gate[0][0] != "go" {
t.Error("Identity nested fields are shared")
}
if orig.Dispatch.Labels["q"] != "archie:q" {
t.Error("Dispatch.Labels map is shared")
}
if orig.Tools.MCPServers[0].Headers["A"] != "b" || orig.Tools.MCPServers[0].Args[0] != "x" {
t.Error("MCP server fields are shared")
}
if orig.Memory.ProviderConfig["k"] != "v" {
t.Error("Memory.ProviderConfig is shared")
}
if orig.Chat.Telegram.AllowedUserIDs[0] != 1 {
t.Error("Telegram.AllowedUserIDs is shared")
}
if orig.LegacyAgent.Env[0] != "HOME" {
t.Error("Agent.Env is shared")
}
if orig.Extra["custom"] != 1 {
t.Error("Extra map is shared")
}
if orig.Bindings.PreviousEncryptionKeys[0].Key != "K0" {
t.Error("Bindings.PreviousEncryptionKeys is shared")
}
if !*orig.Tools.WebFetch.Enabled {
t.Error("WebFetch.Enabled pointer is shared")
}
if !orig.Image.Hosted["openai"].Enabled {
t.Error("Image.Hosted map is shared")
}
if !orig.Image.Local["sdxl"].Enabled {
t.Error("Image.Local map is shared")
}
}