Files
sam 93db9a6395
deploy / gate (push) Successful in 7m52s
deploy / agent-image (push) Successful in 12s
deploy / dist-zip (push) Skipped
deploy / archied-image (push) Successful in 2m33s
feat(extensions): typed extension settings (number, boolean, duration, list, select)
2026-11-08 16:14:23 +11:00

58 lines
3.0 KiB
Go

package webui
import (
"maps"
"testing"
"github.com/samcharles93/archie-core/internal/domain/storepkg"
)
// An extension's settings accept only what its package declares, and a secret
// only as a reference: a pasted credential must never reach stored settings.
func TestDeclaredSettings(t *testing.T) {
schema := []storepkg.Setting{
{Key: "imap_addr", Label: "IMAP address", Required: true},
{Key: "password_ref", Label: "Password", Secret: true, Required: true},
{Key: "ratio", Label: "Ratio", Type: "number"},
{Key: "tls", Label: "Use TLS", Type: "boolean"},
{Key: "poll", Label: "Poll interval", Type: "duration"},
{Key: "folders", Label: "Folders", Type: "list"},
{Key: "mode", Label: "Mode", Type: "select", Options: []string{"fast", "safe"}},
}
tests := []struct {
name string
give map[string]string
want map[string]string
wantErr bool
}{
{name: "declared values are trimmed", give: map[string]string{"imap_addr": " mail:993 ", "password_ref": "bws:mail"}, want: map[string]string{"imap_addr": "mail:993", "password_ref": "bws:mail"}},
{name: "empty values are dropped", give: map[string]string{"imap_addr": "", "password_ref": " "}, want: map[string]string{}},
{name: "undeclared key", give: map[string]string{"smtp_addr": "mail:587"}, wantErr: true},
{name: "raw secret", give: map[string]string{"password_ref": "hunter2"}, wantErr: true},
{name: "reference without a key", give: map[string]string{"password_ref": "bws:"}, wantErr: true},
{name: "reference without an engine", give: map[string]string{"password_ref": ":mail"}, wantErr: true},
{name: "number accepted", give: map[string]string{"ratio": "0.5"}, want: map[string]string{"ratio": "0.5"}},
{name: "number refused", give: map[string]string{"ratio": "half"}, wantErr: true},
{name: "boolean accepted", give: map[string]string{"tls": "false"}, want: map[string]string{"tls": "false"}},
{name: "boolean refused", give: map[string]string{"tls": "yes"}, wantErr: true},
{name: "duration accepted", give: map[string]string{"poll": "30s"}, want: map[string]string{"poll": "30s"}},
{name: "duration unparsable", give: map[string]string{"poll": "soon"}, wantErr: true},
{name: "duration not positive", give: map[string]string{"poll": "0s"}, wantErr: true},
{name: "list is normalised", give: map[string]string{"folders": "INBOX , Sent,Archive"}, want: map[string]string{"folders": "INBOX,Sent,Archive"}},
{name: "list with an empty item", give: map[string]string{"folders": "INBOX,,Sent"}, wantErr: true},
{name: "select accepted", give: map[string]string{"mode": "safe"}, want: map[string]string{"mode": "safe"}},
{name: "select refused", give: map[string]string{"mode": "reckless"}, wantErr: true},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got, err := declaredSettings(schema, tt.give)
if (err != nil) != tt.wantErr {
t.Fatalf("err = %v, wantErr %v", err, tt.wantErr)
}
if !tt.wantErr && !maps.Equal(got, tt.want) {
t.Fatalf("got %v, want %v", got, tt.want)
}
})
}
}