Files
sam db346b159d fix(webui): mark cookies Secure behind a TLS proxy; run gosec in the gate (#1919)
Cookies took Secure from r.TLS, which is nil behind a proxy that terminates
TLS, so sign-in cookies went out without it. Every dashboard cookie now goes
through one builder that reads the scheme the way the origin check does.

The worktree reset and the agent worker's chown walk use os.Root, so a
symlink swapped in mid-walk can't point them outside the worktree.

gosec runs in golangci-lint, tests included. G104, G115, G204 and G304 are
excluded in config; each remaining finding is fixed or suppressed at the site
with its reason.
2026-11-13 03:16:15 +11:00

233 lines
6.9 KiB
Go

package setup
import (
"context"
"strings"
"testing"
"github.com/samcharles93/archie-core/internal/infrastructure/configuration"
"github.com/samcharles93/archie-core/internal/infrastructure/configuration/tomlwrite"
)
// fakePrompter answers prompts from maps keyed by the exact prompt text and
// records what it was asked, so a test can pin both the answers and that the
// bundled database was actually offered.
type fakePrompter struct {
selectAnswers map[string]int
lineAnswers map[string]string
confirmAnswer bool
selects []recordedSelect
lines []recordedLine
}
type recordedSelect struct {
prompt string
options []string
}
type recordedLine struct {
prompt string
defaultValue string
}
func (f *fakePrompter) Select(_ context.Context, prompt string, options []string) (int, error) {
f.selects = append(f.selects, recordedSelect{prompt: prompt, options: options})
if ans, ok := f.selectAnswers[prompt]; ok {
return ans, nil
}
return 0, nil
}
func (f *fakePrompter) ReadLine(_ context.Context, prompt, defaultValue string) (string, error) {
f.lines = append(f.lines, recordedLine{prompt: prompt, defaultValue: defaultValue})
if ans, ok := f.lineAnswers[prompt]; ok {
return ans, nil
}
return defaultValue, nil
}
func (f *fakePrompter) ReadSecret(context.Context, string) (string, error) { return "", nil }
func (f *fakePrompter) Confirm(context.Context, string, bool) (bool, error) {
return f.confirmAnswer, nil
}
// fakeSink records Put calls by engine/key.
type fakeSink struct {
puts map[string]string
}
func (s *fakeSink) Put(engine, key, value string) error {
if s.puts == nil {
s.puts = map[string]string{}
}
s.puts[engine+"/"+key] = value
return nil
}
func (s *fakeSink) Commit() error { return nil }
// databasePrompt is the re-run database choice; bundledChoice is the index of
// the bundled database option in that menu.
const (
databasePrompt = "Database:"
bundledChoice = 1
differentURL = 2
)
func bundledURL() string {
return "postgres://archie_runtime@/archie?host=" + configuration.DefaultPostgresSocketDir()
}
func bundledMigrationURL() string {
return "postgres://archie_migrator@/archie?host=" + configuration.DefaultPostgresSocketDir()
}
// TestRunParamsDatabaseChoice pins the re-run database step at the setup API
// level: with an existing database_url the flow must offer the bundled
// database as an explicit choice, switching to it must generate PGPASSWORD
// into the sink, and keeping must leave the existing URL untouched.
func TestRunParamsDatabaseChoice(t *testing.T) {
const existing = "postgres://operator:secret@db.internal:5432/archie" //nolint:gosec // G101: a fake database URL.
tests := []struct {
name string
// existing is the prefilled database_url; empty means fresh install.
existing string
// param is Params.DatabaseURL (the -database-url flag).
param string
selectAnswers map[string]int
lineAnswers map[string]string
wantURL string
wantMigrationURL string // empty means the flow must not write one
wantPassword bool
wantChoice bool // a database Select menu must be presented
}{
{
name: "re-run keep existing is the default choice",
existing: existing,
selectAnswers: map[string]int{databasePrompt: 0},
wantURL: existing,
wantChoice: true,
},
{
name: "re-run switch to the bundled database",
existing: existing,
selectAnswers: map[string]int{databasePrompt: bundledChoice},
wantURL: bundledURL(),
wantMigrationURL: bundledMigrationURL(),
wantPassword: true,
wantChoice: true,
},
{
name: "re-run enter a different URL",
existing: existing,
selectAnswers: map[string]int{databasePrompt: differentURL},
lineAnswers: map[string]string{"PostgreSQL 18 URL: ": "postgres://other.internal/archie"},
wantURL: "postgres://other.internal/archie",
wantChoice: true,
},
{
name: "re-run blank answer on the different-URL prompt keeps existing",
existing: existing,
selectAnswers: map[string]int{databasePrompt: differentURL},
lineAnswers: map[string]string{"PostgreSQL 18 URL: ": ""},
wantURL: existing,
wantChoice: true,
},
{
name: "fresh install blank answer means the bundled database",
existing: "",
lineAnswers: map[string]string{"PostgreSQL 18 URL (blank for the bundled database with a generated password): ": ""},
wantURL: bundledURL(),
wantMigrationURL: bundledMigrationURL(),
wantPassword: true,
wantChoice: false,
},
{
name: "database-url flag wins without prompting",
existing: existing,
param: "postgres://flag.internal/archie",
wantURL: "postgres://flag.internal/archie",
wantChoice: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
p := &fakePrompter{
selectAnswers: tt.selectAnswers,
lineAnswers: tt.lineAnswers,
confirmAnswer: false,
}
sink := &fakeSink{}
params := Params{
DatabaseURL: tt.param,
BotUser: "archie-bot",
ForgeType: "none",
Provider: "ollama",
Model: "llama3",
}
edits, err := RunParams(context.Background(), p, nil, sink, ExistingValues{DatabaseURL: tt.existing}, params)
if err != nil {
t.Fatalf("RunParams: %v", err)
}
var gotURL, gotMigrationURL string
for _, e := range edits {
if e.Table != "" {
continue
}
switch e.Key {
case "database_url":
gotURL = e.Value
case "migration_database_url":
gotMigrationURL = e.Value
}
}
if gotURL != tomlwrite.String(tt.wantURL) {
t.Errorf("database_url = %s, want %s", gotURL, tomlwrite.String(tt.wantURL))
}
wantMigrationURL := ""
if tt.wantMigrationURL != "" {
wantMigrationURL = tomlwrite.String(tt.wantMigrationURL)
}
if gotMigrationURL != wantMigrationURL {
t.Errorf("migration_database_url = %q, want %q", gotMigrationURL, wantMigrationURL)
}
password, hasPassword := sink.puts["env/PGPASSWORD"]
if hasPassword != tt.wantPassword {
t.Fatalf("PGPASSWORD stored = %v, want %v", hasPassword, tt.wantPassword)
}
if tt.wantPassword && len(password) != 48 {
t.Errorf("PGPASSWORD = %q, want a 48-character hex password", password)
}
var offered []string
for _, sel := range p.selects {
if sel.prompt == databasePrompt {
offered = sel.options
}
}
if tt.wantChoice {
if offered == nil {
t.Fatalf("no database choice was presented on a re-run; prompts seen: %+v", p.selects)
}
bundled := false
for _, opt := range offered {
if strings.Contains(strings.ToLower(opt), "bundled") {
bundled = true
}
}
if !bundled {
t.Errorf("database choice options %v do not offer the bundled database", offered)
}
} else if offered != nil {
t.Errorf("database choice was presented (%v) where the flow should not ask", offered)
}
})
}
}