package webhook import ( "context" "crypto/hmac" "crypto/sha256" "encoding/hex" "log/slog" "net/http" "net/http/httptest" "os" "strings" "testing" "time" "github.com/samcharles93/archie-core/internal/channels" "github.com/samcharles93/archie-core/internal/domain/messaging" ) type fakeChatContract struct { messaging.ChatContract routeFunc func(ctx context.Context, in messaging.Inbound) (messaging.ChatReply, error) } func (f *fakeChatContract) Route(ctx context.Context, in messaging.Inbound) (messaging.ChatReply, error) { if f.routeFunc != nil { return f.routeFunc(ctx, in) } return messaging.ChatReply{Text: "ok"}, nil } func TestName(t *testing.T) { g := New("", 0, nil, slog.Default()) if g.Name() != "webhook" { t.Errorf("Name() = %q", g.Name()) } } func TestExtractText(t *testing.T) { body := []byte(`{"issue":{"title":"fix bug","body":"details"}}`) if got := extractText(body, "issue.title"); got != "fix bug" { t.Errorf("extract issue.title = %q", got) } if got := extractText(body, "issue.body"); got != "details" { t.Errorf("extract issue.body = %q", got) } if got := extractText(body, ""); got != `{"issue":{"title":"fix bug","body":"details"}}` { t.Errorf("empty path should return raw body: %q", got) } if got := extractText(body, "nonexistent"); got != "" { t.Errorf("nonexistent path: %q", got) } } func TestWebhookHandlerMethodNotAllowed(t *testing.T) { g := New("", 0, []RouteConfig{{Path: "/hook"}}, slog.Default()) handler := g.WebhookHandler() rec := httptest.NewRecorder() handler.ServeHTTP(rec, httptest.NewRequestWithContext(context.Background(), http.MethodGet, "/hook", nil)) if rec.Code != http.StatusMethodNotAllowed { t.Errorf("status = %d, want 405", rec.Code) } } func TestWebhookHandlerEmptyBody(t *testing.T) { g := New("", 0, []RouteConfig{{Path: "/hook"}}, slog.Default()) handler := g.WebhookHandler() rec := httptest.NewRecorder() handler.ServeHTTP(rec, httptest.NewRequestWithContext(context.Background(), http.MethodPost, "/hook", nil)) if rec.Code != http.StatusBadRequest { t.Errorf("status = %d, want 400", rec.Code) } } func TestWebhookHandlerNotStarted(t *testing.T) { g := New("", 0, []RouteConfig{{Path: "/hook"}}, slog.Default()) handler := g.WebhookHandler() rec := httptest.NewRecorder() body := strings.NewReader(`{"text":"hello"}`) handler.ServeHTTP(rec, httptest.NewRequestWithContext(context.Background(), http.MethodPost, "/hook", body)) if rec.Code != http.StatusServiceUnavailable { t.Errorf("status = %d, want 503", rec.Code) } } func TestWebhookHandlerRoute(t *testing.T) { log := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelWarn})) g := New("", 0, []RouteConfig{{Path: "/hook"}}, log) var got messaging.Inbound g.client = &fakeChatContract{ routeFunc: func(_ context.Context, in messaging.Inbound) (messaging.ChatReply, error) { got = in return messaging.ChatReply{Text: "ok"}, nil }, } handler := g.WebhookHandler() payload := `{"text":"hello from webhook"}` rec := httptest.NewRecorder() handler.ServeHTTP(rec, httptest.NewRequestWithContext(context.Background(), http.MethodPost, "/hook", strings.NewReader(payload))) if rec.Code != http.StatusAccepted { t.Errorf("status = %d, want 202", rec.Code) } // A webhook has no per-caller identity, and the route path is not one: // several consumers read SenderID as a person // (internal/app/archied/chat_identity.go, sessioncurator), and criterion // 7 of docs/prds/memory-engine-unification.md says a route path must // never become one. It still keys this message's inbound rate limit, so // it travels in the transport-only BudgetKey instead -- see // internal/ratelimit and config.RateLimitConfig. if got.Message.SenderID != "" { t.Errorf("SenderID = %q, want empty: a route path is not a person", got.Message.SenderID) } if got.BudgetKey != "/hook" { t.Errorf("BudgetKey = %q, want the route path", got.BudgetKey) } if got.Message.ConversationID.ChannelID != "/hook" { t.Errorf("ConversationID.ChannelID = %q, want the route path", got.Message.ConversationID.ChannelID) } } // TestWebhookHandlerRateLimitedDeliveryIsRejected pins archie-core-1173: a // rate-limited webhook delivery must be surfaced to the origin as an // observable rejection (429), never as chat prose echoed back with a 200, and // never as a 202 that claims a dropped event was accepted (the origin would // then never retry it). func TestWebhookHandlerRateLimitedDeliveryIsRejected(t *testing.T) { for _, deliverTo := range []string{"origin", ""} { t.Run("DeliverTo="+deliverTo, func(t *testing.T) { log := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelWarn})) g := New("", 0, []RouteConfig{{Path: "/hook", DeliverTo: deliverTo}}, log) g.client = &fakeChatContract{ routeFunc: func(context.Context, messaging.Inbound) (messaging.ChatReply, error) { return messaging.ChatReply{Text: "You're sending messages too quickly. Please wait a moment and try again.", RateLimited: true}, nil }, } handler := g.WebhookHandler() rec := httptest.NewRecorder() handler.ServeHTTP(rec, httptest.NewRequestWithContext(context.Background(), http.MethodPost, "/hook", strings.NewReader(`{"text":"hello"}`))) if rec.Code != http.StatusTooManyRequests { t.Errorf("status = %d, want 429 so the origin can back off and retry", rec.Code) } if strings.Contains(rec.Body.String(), "too quickly") { t.Errorf("body = %q, want no chat prose echoed to a webhook origin", rec.Body.String()) } }) } } func TestWebhookHandlerInvalidSignature(t *testing.T) { g := New("", 0, []RouteConfig{{Path: "/hook", Secret: "secret"}}, slog.Default()) g.client = &fakeChatContract{} handler := g.WebhookHandler() rec := httptest.NewRecorder() handler.ServeHTTP(rec, httptest.NewRequestWithContext(context.Background(), http.MethodPost, "/hook", strings.NewReader(`{"text":"x"}`))) if rec.Code != http.StatusUnauthorized { t.Errorf("status = %d, want 401", rec.Code) } } func TestWebhookHandlerValidSignature(t *testing.T) { secret := "secret" body := []byte(`{"text":"hello"}`) mac := hmac.New(sha256.New, []byte(secret)) mac.Write(body) sig := "sha256=" + hex.EncodeToString(mac.Sum(nil)) g := New("", 0, []RouteConfig{{Path: "/hook", Secret: secret}}, slog.Default()) g.client = &fakeChatContract{} handler := g.WebhookHandler() req := httptest.NewRequestWithContext(context.Background(), http.MethodPost, "/hook", strings.NewReader(string(body))) req.Header.Set("X-Hub-Signature-256", sig) rec := httptest.NewRecorder() handler.ServeHTTP(rec, req) if rec.Code != http.StatusAccepted { t.Errorf("status = %d, want 202", rec.Code) } } func TestWebhookStartStop(t *testing.T) { log := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelWarn})) g := New("127.0.0.1", 18645, nil, log) ctx, cancel := context.WithTimeout(context.Background(), 200*time.Millisecond) defer cancel() client := &fakeChatContract{} go func() { _ = g.Start(ctx, client, channels.Lifecycle{}) }() time.Sleep(30 * time.Millisecond) _ = g.Stop(context.Background()) } func TestExtractTextJSONRoundTrip(t *testing.T) { data := []byte(`{"action":"push","repo":{"name":"archie-core"}}`) if got := extractText(data, "action"); got != "push" { t.Errorf("action = %q", got) } if got := extractText(data, "repo.name"); got != "archie-core" { t.Errorf("repo.name = %q", got) } } // Compile-time guard. var _ channels.Channel = (*Gateway)(nil)