gate output: stop discarding it, put the real error in the park reason #956

Closed
opened 2026-10-27 13:38:27 +00:00 by sam · 0 comments
Owner

Part of #450.

StageBaselineGate in internal/domain/workflow/implement.go runs each
[[repos.gate]] command via cmd.CombinedOutput(), clips the output to
200 characters into a tc.Log.Warn call, and discards the rest. The
eventual park error (baseline red -- %s fails and builder could not auto-fix (status: %s)) is built from res.Status alone.

Write the full CombinedOutput() to the task's log sink (see #451 for the
sink itself; this can land first using a plain file write if the sink isn't
ready yet, then be migrated) and put a bounded tail (~2KB, not 200 bytes) of
it into the returned error so it reaches the park reason.

Red-then-green: write a test against StageBaselineGate that asserts the
returned error contains gate output beyond 200 characters when the gate
command fails with a long message, confirm it fails today, then fix.


Imported from beads archie-core-1786637501129-428-accd2926 · GitHub #451 · type task · priority P2 · created 2026-08-09 · closed 2026-08-09

Part of #450. `StageBaselineGate` in `internal/domain/workflow/implement.go` runs each `[[repos.gate]]` command via `cmd.CombinedOutput()`, clips the output to 200 characters into a `tc.Log.Warn` call, and discards the rest. The eventual park error (`baseline red -- %s fails and builder could not auto-fix (status: %s)`) is built from `res.Status` alone. Write the full `CombinedOutput()` to the task's log sink (see #451 for the sink itself; this can land first using a plain file write if the sink isn't ready yet, then be migrated) and put a bounded tail (~2KB, not 200 bytes) of it into the returned error so it reaches the park reason. Red-then-green: write a test against `StageBaselineGate` that asserts the returned error contains gate output beyond 200 characters when the gate command fails with a long message, confirm it fails today, then fix. --- _Imported from beads `archie-core-1786637501129-428-accd2926` · GitHub #451 · type task · priority P2 · created 2026-08-09 · closed 2026-08-09_
sam added the mediumtask labels 2026-10-27 13:38:27 +00:00
sam self-assigned this 2026-10-27 13:38:27 +00:00
sam closed this issue 2026-10-27 13:38:27 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#956