cfg.Label is a top-level Config.Label field (internal/config/config.go:364) -- a different field from [dispatch.labels], which maps task states (queued/working/waiting/pr/parked) to their forge labels for a different purpose. It's easy to configure [dispatch.labels] and reasonably assume the label-trigger match target is covered, while leaving the actual label field that controls trigger matching unset.
GitHubClient.IssuesWithLabel (internal/forge/github.go:103) passes that straight through as Labels: []string{label} to the GitHub issues-list API. With label == "", GitHub does not filter by label at all -- it returns every open issue in the repo.
Impact (live incident, 2026-08-09)
Deployed dispatch.trigger = "label" on carina without setting label. The daemon queued 124 unrelated open issues in one poll cycle (everything from epics to unrelated feature requests), and one reached a running agent container before it was caught and stopped manually.
Expected
pollIssuesWithConfig's "label" branch should refuse to poll (log an error and return, same as any other misconfiguration) when cfg.Label is empty, rather than silently falling through to an unfiltered API call. Ideally this is also caught at config-validation time (internal/infrastructure/configuration/validate.go) when dispatch.trigger is "label" or "either" and label is blank.
Close reason
Fixed in fix/label-dispatch-empty-label (31efdcf): pollIssuesWithConfig/pollEitherWithConfig now refuse the label poll when cfg.Label is empty, and validateDispatch rejects the misconfiguration at load time. Adversarially reviewed; one weak test strengthened to actually verify assignee matches survive.
Imported from beads archie-core-1786637501009-424-5b8332dd · GitHub #445 · type bug · priority P2 · created 2026-08-08 · closed 2026-08-20
`internal/daemon/daemon.go` `pollIssuesWithConfig()`, the `"label"` (and `"either"`) trigger branch calls:
```go
issues, err := fg.IssuesWithLabel(ctx, repo.Owner, repo.Name, cfg.Label)
```
`cfg.Label` is a top-level `Config.Label` field (`internal/config/config.go:364`) -- a different field from `[dispatch.labels]`, which maps task *states* (queued/working/waiting/pr/parked) to their forge labels for a different purpose. It's easy to configure `[dispatch.labels]` and reasonably assume the label-trigger match target is covered, while leaving the actual `label` field that controls trigger matching unset.
`GitHubClient.IssuesWithLabel` (`internal/forge/github.go:103`) passes that straight through as `Labels: []string{label}` to the GitHub issues-list API. With `label == ""`, GitHub does not filter by label at all -- it returns every open issue in the repo.
### Impact (live incident, 2026-08-09)
Deployed `dispatch.trigger = "label"` on carina without setting `label`. The daemon queued 124 unrelated open issues in one poll cycle (everything from epics to unrelated feature requests), and one reached a running agent container before it was caught and stopped manually.
### Expected
`pollIssuesWithConfig`'s `"label"` branch should refuse to poll (log an error and return, same as any other misconfiguration) when `cfg.Label` is empty, rather than silently falling through to an unfiltered API call. Ideally this is also caught at config-validation time (`internal/infrastructure/configuration/validate.go`) when `dispatch.trigger` is `"label"` or `"either"` and `label` is blank.
### Close reason
Fixed in fix/label-dispatch-empty-label (31efdcf): pollIssuesWithConfig/pollEitherWithConfig now refuse the label poll when cfg.Label is empty, and validateDispatch rejects the misconfiguration at load time. Adversarially reviewed; one weak test strengthened to actually verify assignee matches survive.
---
_Imported from beads `archie-core-1786637501009-424-5b8332dd` · GitHub #445 · type bug · priority P2 · created 2026-08-08 · closed 2026-08-20_
sam
added the mediumbug labels 2026-10-27 13:38:26 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
internal/daemon/daemon.gopollIssuesWithConfig(), the"label"(and"either") trigger branch calls:cfg.Labelis a top-levelConfig.Labelfield (internal/config/config.go:364) -- a different field from[dispatch.labels], which maps task states (queued/working/waiting/pr/parked) to their forge labels for a different purpose. It's easy to configure[dispatch.labels]and reasonably assume the label-trigger match target is covered, while leaving the actuallabelfield that controls trigger matching unset.GitHubClient.IssuesWithLabel(internal/forge/github.go:103) passes that straight through asLabels: []string{label}to the GitHub issues-list API. Withlabel == "", GitHub does not filter by label at all -- it returns every open issue in the repo.Impact (live incident, 2026-08-09)
Deployed
dispatch.trigger = "label"on carina without settinglabel. The daemon queued 124 unrelated open issues in one poll cycle (everything from epics to unrelated feature requests), and one reached a running agent container before it was caught and stopped manually.Expected
pollIssuesWithConfig's"label"branch should refuse to poll (log an error and return, same as any other misconfiguration) whencfg.Labelis empty, rather than silently falling through to an unfiltered API call. Ideally this is also caught at config-validation time (internal/infrastructure/configuration/validate.go) whendispatch.triggeris"label"or"either"andlabelis blank.Close reason
Fixed in fix/label-dispatch-empty-label (31efdcf): pollIssuesWithConfig/pollEitherWithConfig now refuse the label poll when cfg.Label is empty, and validateDispatch rejects the misconfiguration at load time. Adversarially reviewed; one weak test strengthened to actually verify assignee matches survive.
Imported from beads
archie-core-1786637501009-424-5b8332dd· GitHub #445 · type bug · priority P2 · created 2026-08-08 · closed 2026-08-20