secret engine plugin: bws (Bitwarden Secrets Manager) #938

Closed
opened 2026-10-27 13:38:22 +00:00 by sam · 0 comments
Owner

Ship a yaegi-loaded secrets engine plugin wrapping the bws CLI (os/exec), following the internal/secret Engine interface from archie-core-xec.

Close reason

Already delivered as a compiled-in engine, not a plugin. internal/secret/bws.go implements secret.Engine and shells out to the bws CLI via os/exec (commit 3ae59c9, 2026-07-31); NewRegistry/DefaultRegistry register it under the name "bws" alongside "env". It is documented in config.example.toml and ARCHITECTURE.md:208, and config.example.toml:64 uses it as the worked example. Shipping a second yaegi implementation under examples/secret-engines/ would register the same name "bws", and Registry.Register is last-write-wins over LoadDir, so the plugin would silently shadow the compiled-in engine -- two authoritative paths for one behaviour, which the architecture contract prohibits. Reopen only if the intent is to REPLACE the compiled-in engine with a plugin (which would also need bws removed from NewRegistry and the docs updated).


Imported from beads archie-core-1786637500602-410-7a461d4d · GitHub #431 · type task · priority P2 · created 2026-08-08 · closed 2026-08-20

Ship a yaegi-loaded secrets engine plugin wrapping the bws CLI (os/exec), following the internal/secret Engine interface from archie-core-xec. ### Close reason Already delivered as a compiled-in engine, not a plugin. internal/secret/bws.go implements secret.Engine and shells out to the bws CLI via os/exec (commit 3ae59c9, 2026-07-31); NewRegistry/DefaultRegistry register it under the name "bws" alongside "env". It is documented in config.example.toml and ARCHITECTURE.md:208, and config.example.toml:64 uses it as the worked example. Shipping a second yaegi implementation under examples/secret-engines/ would register the same name "bws", and Registry.Register is last-write-wins over LoadDir, so the plugin would silently shadow the compiled-in engine -- two authoritative paths for one behaviour, which the architecture contract prohibits. Reopen only if the intent is to REPLACE the compiled-in engine with a plugin (which would also need bws removed from NewRegistry and the docs updated). --- _Imported from beads `archie-core-1786637500602-410-7a461d4d` · GitHub #431 · type task · priority P2 · created 2026-08-08 · closed 2026-08-20_
sam added the mediumtask labels 2026-10-27 13:38:22 +00:00
sam self-assigned this 2026-10-27 13:38:22 +00:00
sam closed this issue 2026-10-27 13:38:22 +00:00
sam added a new dependency 2026-10-27 13:42:12 +00:00
sam added a new dependency 2026-10-27 13:42:13 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#938