isForgeDisabled is duplicated in cmd/archied #861

Closed
opened 2026-10-27 13:38:03 +00:00 by sam · 0 comments
Owner

resolveForge in cmd/archied/main.go needs the none/off/disabled predicate, but the identical helper in internal/infrastructure/configuration is unexported, so 518a1a0 copied it with a comment noting the duplication. Two copies of a validation predicate drift: adding a fourth disabled-alias in one place silently leaves the other accepting it.

Acceptance Criteria

One definition of the disabled-forge predicate, referenced by both the configuration package and cmd/archied. The comment noting the duplication is removed with it.

Close reason

Exported ForgeDisabled as the single predicate in internal/infrastructure/configuration; removed the duplicated copy from cmd/archied. Tests: TestForgeDisabled table + discriminating warn-log assertions in TestResolveForgeDegradesInsteadOfFailing (verified to fail under re-inline drift). task check scoped: go test ./... green, gofumpt/vet clean, golangci-lint zero findings in changed files.


Imported from beads archie-core-1786637498451-328-976f53c2 · GitHub #349 · type task · priority P2 · created 2026-08-08 · closed 2026-08-14

resolveForge in cmd/archied/main.go needs the none/off/disabled predicate, but the identical helper in internal/infrastructure/configuration is unexported, so 518a1a0 copied it with a comment noting the duplication. Two copies of a validation predicate drift: adding a fourth disabled-alias in one place silently leaves the other accepting it. ### Acceptance Criteria One definition of the disabled-forge predicate, referenced by both the configuration package and cmd/archied. The comment noting the duplication is removed with it. ### Close reason Exported ForgeDisabled as the single predicate in internal/infrastructure/configuration; removed the duplicated copy from cmd/archied. Tests: TestForgeDisabled table + discriminating warn-log assertions in TestResolveForgeDegradesInsteadOfFailing (verified to fail under re-inline drift). task check scoped: go test ./... green, gofumpt/vet clean, golangci-lint zero findings in changed files. --- _Imported from beads `archie-core-1786637498451-328-976f53c2` · GitHub #349 · type task · priority P2 · created 2026-08-08 · closed 2026-08-14_
sam added the mediumtask labels 2026-10-27 13:38:03 +00:00
sam self-assigned this 2026-10-27 13:38:03 +00:00
sam closed this issue 2026-10-27 13:38:03 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#861