[EPIC] Tools: central registry, MCP client, guardrails #665

Open
opened 2026-10-27 13:37:15 +00:00 by sam · 0 comments
Owner

Narrowed from an epic to a migration. Already shipped - do not rebuild: the central tool registry (internal/tools/toolentry.go ToolEntry, registry.go Registry) carrying name, toolset, schema, handler and an availability CheckFn, consumed dynamically via provider.Engine.Discover and index.RegisterBatch, with the agent loop building its set from it at internal/agentexec/loop_runner.go:84; the MCP client across stdio/HTTP/SSE with per-server config; guardrails (loop detection, idempotent/mutating classification, warn vs hard-stop); and progressive disclosure.

Remaining: (1) migrate the last hand-built core.ToolSet maps into registry providers - scriptToolSet, pluginToolSet and captureToolSet at internal/agentexec/loop_runner.go:172,256,365, plus reviewerToolSet at internal/app/agentworker/review.go:190 - so no per-invocation map construction remains; (2) wire ContextPressureGate into the agentexec loop, which today only archied/main.go applies.

Correction: the earlier claim that a central registry replacing per-invocation ToolSet construction was still pending is wrong - that work is done. Reworded 2026-09-22 from an acceptance check; original text in Dolt history.

Notes

docs/prds/hermes-gap-analysis.md (referenced above) was intentionally deleted in commit 65aa5b4 ('chore: cleanup', 2026-07-28) after it had already spawned this and ~14 sibling beads issues from its 60 identified gaps — it is not a broken link to restore. This issue's description is the surviving record of its slice of that analysis.
Maintainer 2026-09-22: UPDATE, do not close. Evidence: the MCP client across stdio/HTTP/SSE exists (internal/tools/provider/mcp/) along with guardrails (approval.go, availability.go, budget.go). The remaining piece is the central tool registry with dynamic discovery, which would replace the hand-built core.ToolSet maps. Next: narrow the epic to that remaining piece and reword.
Acceptance check 2026-09-22 (read-only, file:line): registry SHIPPED tools/toolentry.go:42 + tools/registry.go:15/:30/:120, discovery provider/provider.go:26/:349, consumed at agentexec/loop_runner.go:84; MCP SHIPPED tools/mcp/transport.go:29, transport_http.go:12, transport_sse.go:15 (reconnect backoff :38), per-server config config.go:328, registered bootstrap.go:1116-1133; guardrails SHIPPED tools/guardrail.go:126/:139/:159/:191 + classification.go:13-45, wired bootstrap.go:1052,1273, consumed domain/workflow/agent.go:169,195 - note only the workflow-agent path instantiates one, the gateway chat loop does not; progressive disclosure SHIPPED tools/disclosure.go:19-21/:238/:354, wired archied/main.go:90-96 (gateway chat only; agentexec never builds the gate). Tests settling it: tools/registry_test.go, guardrail_test.go, disclosure_test.go, mcp/transport_*_test.go.


Imported from beads archie-core-1786637493439-140-2cee2e9b · GitHub #161 · type epic · priority P2 · created 2026-08-08

Narrowed from an epic to a migration. Already shipped - do not rebuild: the central tool registry (internal/tools/toolentry.go ToolEntry, registry.go Registry) carrying name, toolset, schema, handler and an availability CheckFn, consumed dynamically via provider.Engine.Discover and index.RegisterBatch, with the agent loop building its set from it at internal/agentexec/loop_runner.go:84; the MCP client across stdio/HTTP/SSE with per-server config; guardrails (loop detection, idempotent/mutating classification, warn vs hard-stop); and progressive disclosure. Remaining: (1) migrate the last hand-built core.ToolSet maps into registry providers - scriptToolSet, pluginToolSet and captureToolSet at internal/agentexec/loop_runner.go:172,256,365, plus reviewerToolSet at internal/app/agentworker/review.go:190 - so no per-invocation map construction remains; (2) wire ContextPressureGate into the agentexec loop, which today only archied/main.go applies. Correction: the earlier claim that a central registry replacing per-invocation ToolSet construction was still pending is wrong - that work is done. Reworded 2026-09-22 from an acceptance check; original text in Dolt history. ### Notes docs/prds/hermes-gap-analysis.md (referenced above) was intentionally deleted in commit 65aa5b4 ('chore: cleanup', 2026-07-28) after it had already spawned this and ~14 sibling beads issues from its 60 identified gaps — it is not a broken link to restore. This issue's description is the surviving record of its slice of that analysis. Maintainer 2026-09-22: UPDATE, do not close. Evidence: the MCP client across stdio/HTTP/SSE exists (internal/tools/provider/mcp/) along with guardrails (approval.go, availability.go, budget.go). The remaining piece is the central tool registry with dynamic discovery, which would replace the hand-built core.ToolSet maps. Next: narrow the epic to that remaining piece and reword. Acceptance check 2026-09-22 (read-only, file:line): registry SHIPPED tools/toolentry.go:42 + tools/registry.go:15/:30/:120, discovery provider/provider.go:26/:349, consumed at agentexec/loop_runner.go:84; MCP SHIPPED tools/mcp/transport.go:29, transport_http.go:12, transport_sse.go:15 (reconnect backoff :38), per-server config config.go:328, registered bootstrap.go:1116-1133; guardrails SHIPPED tools/guardrail.go:126/:139/:159/:191 + classification.go:13-45, wired bootstrap.go:1052,1273, consumed domain/workflow/agent.go:169,195 - note only the workflow-agent path instantiates one, the gateway chat loop does not; progressive disclosure SHIPPED tools/disclosure.go:19-21/:238/:354, wired archied/main.go:90-96 (gateway chat only; agentexec never builds the gate). Tests settling it: tools/registry_test.go, guardrail_test.go, disclosure_test.go, mcp/transport_*_test.go. --- _Imported from beads `archie-core-1786637493439-140-2cee2e9b` · GitHub #161 · type epic · priority P2 · created 2026-08-08_
sam added the mediumepic labels 2026-10-27 13:37:15 +00:00
sam self-assigned this 2026-10-27 13:37:15 +00:00
sam added the deferred label 2026-11-15 17:26:23 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#665