TaskContext interface refactor: Forge/Store/Trees as trimmed interfaces #592

Closed
opened 2026-10-27 13:36:57 +00:00 by sam · 0 comments
Owner

Groundwork for archie-core-5zh.4. workflow.TaskContext currently types Forge/Store/Trees as concrete daemon types (forge.Forge interface already, *store.Store, *worktree.Manager). Define trimmed interfaces in internal/workflow scoped to exactly the methods stages call (Forge: Comment/CloseIssue/CreatePR/SetStateLabel; Store: Update/Transition; Trees: Prepare/CommitAll/Push/Diff/ChangedFiles/ChangedLines) so storerpc.Client, forgerpc.Client, and a worktreerpc-backed implementation can satisfy them from inside archie-agent, while *store.Store/*worktree.Manager and the real forge.Forge implementations keep satisfying them unchanged for the daemon's existing inprocess/subprocess paths.

Acceptance Criteria

TaskContext.Forge/Store/Trees are interface-typed; daemon.go compiles and all existing tests pass unchanged (concrete types satisfy the new interfaces structurally); no behavior change for inprocess/subprocess modes.


Imported from beads archie-core-1786637491474-64-f086bf4c · GitHub #85 · type task · priority P2 · created 2026-08-08 · closed 2026-08-08

Groundwork for archie-core-5zh.4. workflow.TaskContext currently types Forge/Store/Trees as concrete daemon types (forge.Forge interface already, *store.Store, *worktree.Manager). Define trimmed interfaces in internal/workflow scoped to exactly the methods stages call (Forge: Comment/CloseIssue/CreatePR/SetStateLabel; Store: Update/Transition; Trees: Prepare/CommitAll/Push/Diff/ChangedFiles/ChangedLines) so storerpc.Client, forgerpc.Client, and a worktreerpc-backed implementation can satisfy them from inside archie-agent, while *store.Store/*worktree.Manager and the real forge.Forge implementations keep satisfying them unchanged for the daemon's existing inprocess/subprocess paths. ### Acceptance Criteria TaskContext.Forge/Store/Trees are interface-typed; daemon.go compiles and all existing tests pass unchanged (concrete types satisfy the new interfaces structurally); no behavior change for inprocess/subprocess modes. --- _Imported from beads `archie-core-1786637491474-64-f086bf4c` · GitHub #85 · type task · priority P2 · created 2026-08-08 · closed 2026-08-08_
sam added the mediumtask labels 2026-10-27 13:36:57 +00:00
sam self-assigned this 2026-10-27 13:36:57 +00:00
sam closed this issue 2026-10-27 13:36:57 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#592