Resolve pre-existing task check gate blockers (lint + jsdom) #530

Closed
opened 2026-10-27 13:36:41 +00:00 by sam · 0 comments
Owner

Two pre-existing blockers keep the authoritative task check gate red, independently of the progressive-tool-disclosure wiring (issue #167):

  1. golangci-lint: 5 issues in files untouched by #167:

    • internal/app/archied/bootstrap.go:316 (cyclop: setupObservability complexity 16 > 15)
    • internal/app/archied/bootstrap.go:405 (nestif)
    • internal/app/archied/telegram_setup_test.go:64 (usetesting: os.Setenv -> t.Setenv)
    • internal/releaseupdate/install_script_test.go:143,160 (noctx: exec.Command -> CommandContext)

    All 5 confirmed reproducible on clean main (git stash comparison) and match the documented non-green lint baseline in the archie-build-and-env skill.

  2. task test:ui fails because ui/node_modules is not installed (ERR_MODULE_NOT_FOUND: jsdom, declared at ui/package.json:16). Needs npm install before the ui test can run.

Blockers are environmental/baseline, not introduced by the tool-disclosure wiring.

Close reason

task check now fully green (EXIT=0). Remaining noctx finding in internal/releaseupdate/install_script_test.go resolved via QueryRowContext/ExecContext in commit cd2e94a; other baseline lint findings and the ui/jsdom test:ui blocker no longer gate.


Imported from beads archie-core-14cs · GitHub #731 · type task · priority P2 · created 2026-09-05 · closed 2026-09-05

Two pre-existing blockers keep the authoritative task check gate red, independently of the progressive-tool-disclosure wiring (issue #167): 1. golangci-lint: 5 issues in files untouched by #167: - internal/app/archied/bootstrap.go:316 (cyclop: setupObservability complexity 16 > 15) - internal/app/archied/bootstrap.go:405 (nestif) - internal/app/archied/telegram_setup_test.go:64 (usetesting: os.Setenv -> t.Setenv) - internal/releaseupdate/install_script_test.go:143,160 (noctx: exec.Command -> CommandContext) All 5 confirmed reproducible on clean main (git stash comparison) and match the documented non-green lint baseline in the archie-build-and-env skill. 2. task test:ui fails because ui/node_modules is not installed (ERR_MODULE_NOT_FOUND: jsdom, declared at ui/package.json:16). Needs npm install before the ui test can run. Blockers are environmental/baseline, not introduced by the tool-disclosure wiring. ### Close reason task check now fully green (EXIT=0). Remaining noctx finding in internal/releaseupdate/install_script_test.go resolved via QueryRowContext/ExecContext in commit cd2e94a; other baseline lint findings and the ui/jsdom test:ui blocker no longer gate. --- _Imported from beads `archie-core-14cs` · GitHub #731 · type task · priority P2 · created 2026-09-05 · closed 2026-09-05_
sam added the mediumtask labels 2026-10-27 13:36:41 +00:00
sam self-assigned this 2026-10-27 13:36:41 +00:00
sam closed this issue 2026-10-27 13:36:41 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#530