Validate workflow conditions and retry durations #53

Closed
opened 2026-10-27 13:34:45 +00:00 by sam · 0 comments
Owner

The step editor accepts what as a condition and yes or what as a retry duration without feedback. Trace the actual workflow grammar and parser, reproduce validation at edit/save boundaries, and reuse those contracts for inline feedback and syntax guidance.

Acceptance criteria

Invalid retry durations and invalid conditions produce useful field errors and cannot be saved. Valid expressions and durations round-trip unchanged. The UI explains supported condition syntax and preserves invalid drafts for correction.

Notes

The server already rejects invalid conditions and retry durations. Added editor/YAML feedback using the existing flow grammar, preserved invalid duration input with an accessible error, and blocked Save until corrected. Browser regression covers what/yes, correction, fractional duration and unit conversion; parser regression cases reproduce the original acceptance gap.

Close reason

Implemented and verified in 57456b3e. Full quality gate passed, seven targeted local browser checks passed, and real audit-name save/readback was verified with the original setting restored. Per-issue acceptance evidence is recorded in notes.


Imported from beads archie-core-3z4fd.4 · GitHub #1687 · type task · priority P1 · created 2026-10-16 · closed 2026-10-16

The step editor accepts what as a condition and yes or what as a retry duration without feedback. Trace the actual workflow grammar and parser, reproduce validation at edit/save boundaries, and reuse those contracts for inline feedback and syntax guidance. ### Acceptance criteria Invalid retry durations and invalid conditions produce useful field errors and cannot be saved. Valid expressions and durations round-trip unchanged. The UI explains supported condition syntax and preserves invalid drafts for correction. ### Notes The server already rejects invalid conditions and retry durations. Added editor/YAML feedback using the existing flow grammar, preserved invalid duration input with an accessible error, and blocked Save until corrected. Browser regression covers what/yes, correction, fractional duration and unit conversion; parser regression cases reproduce the original acceptance gap. ### Close reason Implemented and verified in 57456b3e. Full quality gate passed, seven targeted local browser checks passed, and real audit-name save/readback was verified with the original setting restored. Per-issue acceptance evidence is recorded in notes. --- _Imported from beads `archie-core-3z4fd.4` · GitHub #1687 · type task · priority P1 · created 2026-10-16 · closed 2026-10-16_
sam added the hightask labels 2026-10-27 13:34:45 +00:00
sam self-assigned this 2026-10-27 13:34:45 +00:00
sam closed this issue 2026-10-27 13:34:45 +00:00
sam added a new dependency 2026-11-14 14:45:19 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#53