release.sh component closure cannot see packaging/install changes, so a packaging-only fix cannot be released mechanically #529

Closed
opened 2026-10-27 13:36:41 +00:00 by sam · 0 comments
Owner

Found while fixing archie-core-1c01 (archie-messaging missing from the shipped host install).

PROBLEM
tools/release.sh decides each component's changelog by matching changed files against the binary's go list -deps closure plus a few explicit paths (cmd/archied, Dockerfile.archied, cmd/archie-ui, internal/app/archieui). The files that actually define a host install -- .github/workflows/deploy.yml (the dist zip), install.sh, scripts/archie-update-install, Taskfile.yml -- are in NO component's closure.

CONSEQUENCE
A fix that changes only what the release SHIPS (which binaries are packaged, what the updater installs) produces an empty section for every component, so the standing rule says 'skip both' and there is no release. But the updater resolves versions from component tags, so with no tag bump nobody is ever offered the fix -- the packaging bug is unshippable through the very mechanism it broke.

WORKAROUND USED
Force the patch explicitly: task release:prepare VERSION=X.Y.Z sets a section even when the generated body is empty ('- chore: no user-facing changes'), so a deliberate bump is possible. That is a manual escape from the mechanical rule rather than the rule being right.

FIX DIRECTION
Either (a) extend the archied closure with the packaging/install files, since they are part of that release artifact, or (b) add an explicit release-time assertion that the packaged set and the installer's set agree, so a packaging change cannot be forgotten rather than merely unnoticed. (a) is the single-source-of-truth fix; (b) is the guard. Doing both is defensible: one makes the change visible, the other makes drift impossible.

Close reason

Fixed: 06800c62 attributes Taskfile.yml, deploy.yml, install.sh and the update scripts to the archied release, so a packaging-only change produces a release (fix a); 98bbadfe adds every shipped binary's closure; 323870a9 (archie-core-1faq) guards that the release build and updater cover every host service the installers manage (fix b).


Imported from beads archie-core-12rp · GitHub #1114 · type bug · priority P2 · created 2026-09-21 · closed 2026-09-27

Found while fixing archie-core-1c01 (archie-messaging missing from the shipped host install). PROBLEM tools/release.sh decides each component's changelog by matching changed files against the binary's go list -deps closure plus a few explicit paths (cmd/archied, Dockerfile.archied, cmd/archie-ui, internal/app/archieui). The files that actually define a host install -- .github/workflows/deploy.yml (the dist zip), install.sh, scripts/archie-update-install, Taskfile.yml -- are in NO component's closure. CONSEQUENCE A fix that changes only what the release SHIPS (which binaries are packaged, what the updater installs) produces an empty section for every component, so the standing rule says 'skip both' and there is no release. But the updater resolves versions from component tags, so with no tag bump nobody is ever offered the fix -- the packaging bug is unshippable through the very mechanism it broke. WORKAROUND USED Force the patch explicitly: task release:prepare VERSION=X.Y.Z sets a section even when the generated body is empty ('- chore: no user-facing changes'), so a deliberate bump is possible. That is a manual escape from the mechanical rule rather than the rule being right. FIX DIRECTION Either (a) extend the archied closure with the packaging/install files, since they are part of that release artifact, or (b) add an explicit release-time assertion that the packaged set and the installer's set agree, so a packaging change cannot be forgotten rather than merely unnoticed. (a) is the single-source-of-truth fix; (b) is the guard. Doing both is defensible: one makes the change visible, the other makes drift impossible. ### Close reason Fixed: 06800c62 attributes Taskfile.yml, deploy.yml, install.sh and the update scripts to the archied release, so a packaging-only change produces a release (fix a); 98bbadfe adds every shipped binary's closure; 323870a9 (archie-core-1faq) guards that the release build and updater cover every host service the installers manage (fix b). --- _Imported from beads `archie-core-12rp` · GitHub #1114 · type bug · priority P2 · created 2026-09-21 · closed 2026-09-27_
sam added the mediumbug labels 2026-10-27 13:36:41 +00:00
sam self-assigned this 2026-10-27 13:36:41 +00:00
sam closed this issue 2026-10-27 13:36:41 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#529