task-policy: reject userinfo and query in notify_webhook #497

Closed
opened 2026-10-27 13:36:33 +00:00 by sam · 1 comment
Owner

notify_webhook accepts URL userinfo/query, so a credential can ride a URL into sys_audit. Reject both at validation, matching the provider BaseURL rule.


Imported from beads archie-core-wwhoz.12 · GitHub #1896 · type task · priority P2 · created 2026-10-25

notify_webhook accepts URL userinfo/query, so a credential can ride a URL into sys_audit. Reject both at validation, matching the provider BaseURL rule. --- _Imported from beads `archie-core-wwhoz.12` · GitHub #1896 · type task · priority P2 · created 2026-10-25_
sam added the mediumtask labels 2026-10-27 13:36:33 +00:00
sam self-assigned this 2026-10-27 13:36:33 +00:00
sam closed this issue 2026-10-28 12:53:44 +00:00
Author
Owner

Fixed in e3b1103f.

internal/infrastructure/controlplanestore/task_policy.go now refuses a notify_webhook that carries userinfo or a query string, including a bare trailing ? (url.URL.ForceQuery). Covered by a 9-case table test in task_policy_test.go. Verified with task check.

Fixed in `e3b1103f`. `internal/infrastructure/controlplanestore/task_policy.go` now refuses a `notify_webhook` that carries userinfo or a query string, including a bare trailing `?` (`url.URL.ForceQuery`). Covered by a 9-case table test in `task_policy_test.go`. Verified with `task check`.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#497